Gson proguard is not working properly after upgrading to AGP 8.8 [394185143]

Fixed

Bug

Status Update

No update yet.

Description

co...@jasonkhew96.dev

created issue #1

Feb 4, 2025 11:24AM

Gson proguard rules is not working properly after upgrading to AGP 8.8

after a lot of testing, I believe this commit in R8 broke it, causing R8 to remove <init>() method

https://r8.googlesource.com/r8/+/8cf0a585a4bcdcb8c6390616d30f26e60e1748ea

unfortunately, I can not reproduce this bug in a new project

the bug is still occurs in latest commit 5f9f76f286c6ea3cae34de83d8ab8ab9d74d398b

Comments

ch...@google.com <ch...@google.com> #2Feb 4, 2025 11:27AM

Reassigned to ch...@google.com.

I believe you've been looking into this

        at com.android.tools.idea.gradle.project.sync.idea.SdkSyncUtil.findMatchingSdkForAddon(SdkSyncUtil.kt:175)
        at com.android.tools.idea.gradle.project.sync.idea.SdkSyncUtil.computeSdkReloadingAsNeeded(SdkSyncUtil.kt:127)

ch...@google.com <ch...@google.com> #3Feb 5, 2025 01:24PM

hm, in fact let's discuss how we handle SDKs/addons etc. and also bootlclasspath. We have an open issue with not supporting useLibrary which we need to fix.

ap...@google.com <ap...@google.com> #4Feb 5, 2025 01:30PM

Marked as fixed.

The issue seems to be in

// Find the path to the android.jar, so we can match this to the sdks and find which one is in use.
  val androidJarPath = bootClasspath.map { path ->
    File(path)
  }.firstOrNull { file ->
    file.name == FN_FRAMEWORK_LIBRARY
  } ?: return null

  // There is no android.jar file in the bootClasspath, we can't find the SDK
  // TODO: Maybe log here, this condition should never happen AFAIK.

  return allAndroidSdks.first { sdk ->
    sdk.rootProvider.getFiles(CLASSES).any { sdkFile ->
      filesEqual(virtualToIoFile(sdkFile), androidJarPath)
    }
  }

i.e. it seems that android.jar from the bootclasspath (as reported by AGP) is not found in any of Android SDKs registered with the IDE.

Al, do you modify bootclasspath for you project in some way? Also, can you please share a small project that reproduces the issue?

Bradley, you made some changes in this area in the past, does this ring a bell?

ap...@google.com <ap...@google.com> #5Feb 5, 2025 02:17PM

We have a custom SDK which we pull from our own servers. It's a modified API Level 32 that includes framework classes so that folk can work on a custom Launcher without needing to get into AOSP experience.

Unfortunately I can't share that publicly, but would that trigger the issue? Is there some kind of filter on allAndroidSdks which only includes Google sourced SDKs? The reason I'm asking is we've seen issues trying to run apps from AS where our custom SDK is selected, and compiles the code without an issue, but AS pops up a "Please select an Android SDK" error.

ap...@google.com <ap...@google.com> #6Feb 5, 2025 02:17PM

This is probably caused by https://issuetracker.google.com/238235638. Are you adding a custom SDK? If so, allAndroidSdks will be empty, and even though there is file with name android.jar in bootclasspath, the code above will fail?

ap...@google.com <ap...@google.com> #7Feb 5, 2025 02:18PM

That's very plausible. In which case could the exception be caught and the error be more meaningful (e.g. "Please install a Google-provided Android SDK"). Currently, in my opinion, the error doesn't give the user a lot of indication of the cause of the error and what they can do to resolve it.

ap...@google.com <ap...@google.com> #8Feb 5, 2025 02:18PM

Thanks for confirming that, we'll aim to fix this issue.

ap...@google.com <ap...@google.com> #9Feb 5, 2025 02:20PM

This will be fixed in upcoming Android Studio Flamingo canaries/betas.

Change: I10b962c387dbac48d047efafddcb7b4d4de3257d

ga...@linecorp.com <ga...@linecorp.com> #10Feb 6, 2025 12:09AM

Hello. I tried to check with this change.
But https://storage.googleapis.com/r8-releases/raw/com/android/tools/r8/8.8.31/r8-8.8.31.pom is not available, yet.

<Error>
  <Code>NoSuchKey</Code>
  <Message>The specified key does not exist.</Message>
  <Details>No such object: r8-releases/raw/com/android/tools/r8/8.8.31/r8-8.8.31.pom</Details>
</Error>

ap...@google.com <ap...@google.com> #11Feb 6, 2025 07:58AM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101181

Version 8.8.32

Expand for full commit details

Version 8.8.32 
 
Bug: b/394185143 
Change-Id: I2b4a23b67aabfa2582d2011ce811ac3f8f3fcdb2

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: 2aed3efa54f965c7f02f69ce980e8178f9fd3db9
Date: Thu Feb 06 08:46:34 2025

ch...@google.com <ch...@google.com> #12Feb 6, 2025 07:59AM

Sorry about that, there was an error archiving 8.8.31. Please try with 8.8.32.

an...@google.com <an...@google.com> #13Feb 18, 2025 01:59PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Meerkat | 2024.3.1 RC 2
Android Gradle Plugin 8.9.0-rc02

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

an...@google.com <an...@google.com> #14Feb 26, 2025 05:51PM

The fixes for this issue are now also available in:

Android Studio Ladybug Feature Drop | 2024.2.2 Patch 2
Android Gradle Plugin 8.8.2

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

op...@gmail.com <op...@gmail.com> #15Mar 12, 2025 04:17AM

Need to apply one default progaurd file and one KOP4J Libray .progaurd file. When apply with .kts structure gradle like below with agp = "8.8.2" given me issue,

proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
kop.ruleFiles.put(name, [kop.getDefaultKopFile('kop-android-default.txt'), '

altice-kop-rules1.pro'])

Issue:

java.lang.IllegalStateException: The value for this file collection cannot be changed any further

ch...@google.com <ch...@google.com> #16Mar 12, 2025 07:06AM

Re: comment#15: This sounds like a different issue. Please open a new issue at http://issuetracker.google.com/issues/new?component=326787.