Gson proguard is not working properly after upgrading to AGP 8.8 [394185143]

Fixed

Bug

Status Update

No update yet.

Description

co...@jasonkhew96.dev

created issue #1

Feb 4, 2025 11:24AM

Gson proguard rules is not working properly after upgrading to AGP 8.8

after a lot of testing, I believe this commit in R8 broke it, causing R8 to remove <init>() method

https://r8.googlesource.com/r8/+/8cf0a585a4bcdcb8c6390616d30f26e60e1748ea

unfortunately, I can not reproduce this bug in a new project

the bug is still occurs in latest commit 5f9f76f286c6ea3cae34de83d8ab8ab9d74d398b

Comments

ch...@google.com <ch...@google.com> #2Feb 4, 2025 11:27AM

Reassigned to ch...@google.com.

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Ladybug Feature Drop | 2024.2.2 Canary 3
Android Gradle Plugin 8.8.0-alpha03

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

ch...@google.com <ch...@google.com> #3Feb 5, 2025 01:24PM

Thanks for sharing a reproduction and for correctly identifying the culprit. A fix is up for review and will be merged to the relevant release branches soon.

ap...@google.com <ap...@google.com> #4Feb 5, 2025 01:30PM

Marked as fixed.

Project: r8
Branch: main
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101140

Reproduce and fix inadequate keeping of Gson <init>s

Expand for full commit details

Reproduce and fix inadequate keeping of Gson <init>s 
 
Fixes: b/394185143 
Change-Id: I4657735beffd0b7899323c8b7fba499eee45dfee

Files:

M src/main/java/com/android/tools/r8/shaking/ifrules/MaterializedSubsequentRulesOptimizer.java
A src/test/java/com/android/tools/r8/shaking/ifrule/IfRuleReductionWithMembersTest.java

Hash: 79108feec75e30472f65e098ce1b5db6ad3a9930
Date: Wed Feb 05 14:16:49 2025

ap...@google.com <ap...@google.com> #5Feb 5, 2025 02:17PM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101148

Version 8.8.31

Expand for full commit details

Version 8.8.31 
 
Bug: b/394185143 
Change-Id: I36c072774b2d068478e653adf5c6fdace449eeb5

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: c43822639e26e541a3175cc3b38e78309f822b75
Date: Wed Feb 05 14:32:40 2025

ap...@google.com <ap...@google.com> #6Feb 5, 2025 02:17PM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101165

Reproduce and fix inadequate keeping of Gson <init>s

Expand for full commit details

Reproduce and fix inadequate keeping of Gson <init>s 
 
Fixes: b/394185143 
Change-Id: I4657735beffd0b7899323c8b7fba499eee45dfee

Files:

M src/main/java/com/android/tools/r8/shaking/ifrules/MaterializedSubsequentRulesOptimizer.java
A src/test/java/com/android/tools/r8/shaking/ifrule/IfRuleReductionWithMembersTest.java

Hash: 1f1341c669a7f8b446e520c6ef6201a49b90c3e4
Date: Wed Feb 05 14:32:32 2025

ap...@google.com <ap...@google.com> #7Feb 5, 2025 02:18PM

Project: r8
Branch: 8.9
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101164

Reproduce and fix inadequate keeping of Gson <init>s

Expand for full commit details

Reproduce and fix inadequate keeping of Gson <init>s 
 
Fixes: b/394185143 
Change-Id: I4657735beffd0b7899323c8b7fba499eee45dfee

Files:

M src/main/java/com/android/tools/r8/shaking/ifrules/MaterializedSubsequentRulesOptimizer.java
A src/test/java/com/android/tools/r8/shaking/ifrule/IfRuleReductionWithMembersTest.java

Hash: aa453d30de611726dad19eac53181f2ac29237a5
Date: Wed Feb 05 14:31:58 2025

ap...@google.com <ap...@google.com> #8Feb 5, 2025 02:18PM

Project: r8
Branch: 8.9
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101147

Version 8.9.25

Expand for full commit details

Version 8.9.25 
 
Bug: b/394185143 
Change-Id: Iffbf27b00445091fdc1f27b4f826b6180fcb5251

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: e9553fdfed74d010e16e0b624a26f3a71d18feba
Date: Wed Feb 05 14:32:06 2025

ap...@google.com <ap...@google.com> #9Feb 5, 2025 02:20PM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101165

Reproduce and fix inadequate keeping of Gson <init>s

Expand for full commit details

Reproduce and fix inadequate keeping of Gson <init>s 
 
Fixes: b/394185143 
Change-Id: I4657735beffd0b7899323c8b7fba499eee45dfee

Files:

M src/main/java/com/android/tools/r8/shaking/ifrules/MaterializedSubsequentRulesOptimizer.java
A src/test/java/com/android/tools/r8/shaking/ifrule/IfRuleReductionWithMembersTest.java

Hash: 1f1341c669a7f8b446e520c6ef6201a49b90c3e4
Date: Wed Feb 05 14:32:32 2025

ga...@linecorp.com <ga...@linecorp.com> #10Feb 6, 2025 12:09AM

Hello. I tried to check with this change.
But https://storage.googleapis.com/r8-releases/raw/com/android/tools/r8/8.8.31/r8-8.8.31.pom is not available, yet.

<Error>
  <Code>NoSuchKey</Code>
  <Message>The specified key does not exist.</Message>
  <Details>No such object: r8-releases/raw/com/android/tools/r8/8.8.31/r8-8.8.31.pom</Details>
</Error>

ap...@google.com <ap...@google.com> #11Feb 6, 2025 07:58AM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101181

Version 8.8.32

Expand for full commit details

Version 8.8.32 
 
Bug: b/394185143 
Change-Id: I2b4a23b67aabfa2582d2011ce811ac3f8f3fcdb2

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: 2aed3efa54f965c7f02f69ce980e8178f9fd3db9
Date: Thu Feb 06 08:46:34 2025

ch...@google.com <ch...@google.com> #12Feb 6, 2025 07:59AM

Sorry about that, there was an error archiving 8.8.31. Please try with 8.8.32.

an...@google.com <an...@google.com> #13Feb 18, 2025 01:59PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Meerkat | 2024.3.1 RC 2
Android Gradle Plugin 8.9.0-rc02

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

an...@google.com <an...@google.com> #14Feb 26, 2025 05:51PM

The fixes for this issue are now also available in:

Android Studio Ladybug Feature Drop | 2024.2.2 Patch 2
Android Gradle Plugin 8.8.2

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Issue 394185143

Description

Issue summary

Comments

ch...@google.com <ch...@google.com> #2Feb 4, 2025 11:27AM

ch...@google.com <ch...@google.com> #3Feb 5, 2025 01:24PM

ap...@google.com <ap...@google.com> #4Feb 5, 2025 01:30PM

ap...@google.com <ap...@google.com> #5Feb 5, 2025 02:17PM

ap...@google.com <ap...@google.com> #6Feb 5, 2025 02:17PM

ap...@google.com <ap...@google.com> #7Feb 5, 2025 02:18PM

ap...@google.com <ap...@google.com> #8Feb 5, 2025 02:18PM

ap...@google.com <ap...@google.com> #9Feb 5, 2025 02:20PM

ga...@linecorp.com <ga...@linecorp.com> #10Feb 6, 2025 12:09AM

ap...@google.com <ap...@google.com> #11Feb 6, 2025 07:58AM

ch...@google.com <ch...@google.com> #12Feb 6, 2025 07:59AM

an...@google.com <an...@google.com> #13Feb 18, 2025 01:59PM

an...@google.com <an...@google.com> #14Feb 26, 2025 05:51PM

Add comment

Issue metadata