IssueTracker

Component used: Jetpack macrobenchmark Version used: 1.4.0-alpha07 Devices/Android versions reproduced on: Pixel 4 XL Android 14 aosp

Sometimes there are resynced frames when frame is prepared for too long: "Choreographer#doFrame - resynced to 8643135 in 21,7ms" and there is logic added here to filter these out in FrameTimingQuery:

 val groupedData =
            slices
                .filter { it.dur > 0 } // drop non-terminated slices
                .filter { !it.name.contains("resynced") } // drop "#doFrame - resynced to" slices
                .groupBy {
                    when {
                        // note: we use "startsWith" as starting in S, all of these will end
                        // with frame ID (or GPU completion frame ID)
                        it.name.startsWith("Choreographer#doFrame") -> FrameSliceType.UiThread
                        it.name.startsWith("DrawFrame") -> FrameSliceType.RenderThread
                        it.name.startsWith("actual ") -> FrameSliceType.Actual
                        it.name.startsWith("expected ") -> FrameSliceType.Expected
                        else -> throw IllegalStateException("Unexpected slice $it")
                    }
                }

But there's a check later that checks if all slices have frameId:

 check(slices.none { it.frameId == null }) {
                "Observed frame in trace missing id, please report bug and attach perfetto trace."
            }

Frame id is number that comes after "Choreographer#doFrame" And it checks for frameId in unfiltered slices where Choreographer#doFrame - resynced to 8643135 in 21,7ms is present. It tries to convert "-" to id, fails to do so and returns null.

It results in test failing because of that check.

Should be easy fix - just filter first and check for frameIds presence in filtered traces