java.lang.IllegalStateException: Place was called on a node which was placed already [394760799]

Assigned

Bug

Status Update

No update yet.

Description

wa...@gmail.com

created issue #1

Feb 6, 2025 12:23PM

Jetpack Compose version: 2025.01.01

Jetpack Compose component used: FlowRow, HorizontalPager

Android Studio Build: Ladybug Feature Drop 2024.2.2

Kotlin version: 2.1.10

Steps to Reproduce or Code Sample to Reproduce:

Run the code sample
Use keyboard to navigate through chips
Press right arrow multiple times on keyboard to move focus at the right

The way to fix this issue is to replace beyondViewportPageCount with a value like 999, or even 1. However, maybe we should also introduce a constant to ensure that all items are rendered to prevent this problem?

Code

import android.os.Bundle
import androidx.activity.compose.setContent
import androidx.appcompat.app.AppCompatActivity
import androidx.compose.foundation.layout.*
import androidx.compose.foundation.pager.HorizontalPager
import androidx.compose.foundation.pager.rememberPagerState
import androidx.compose.material.*
import androidx.compose.runtime.Composable
import androidx.compose.runtime.remember
import androidx.compose.ui.Modifier
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import ru.x5.omni.presentation.compose.composables.AppScaffold
import ru.x5.omni.presentation.compose.theme.AppTheme

class TestActivity : AppCompatActivity() {
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContent {
            MaterialTheme {
                Box(modifier = Modifier
                    .fillMaxSize()
                    .safeContentPadding()) {
                    val state = rememberPagerState(0) { 2 }
                    HorizontalPager(state) {
                        when (it) {
                            0 -> {
                                val newState = rememberPagerState(0) { 2 }
                                HorizontalPager(state = newState, beyondViewportPageCount = Int.MAX_VALUE) {
                                    when (it) {
                                        0 -> Content()
                                        1 -> Content()
                                    }
                                }
                            }
                            1 -> Card(modifier = Modifier.fillMaxWidth().height(100.dp), onClick = {}) {
                                Text(text = "Test")
                            }
                        }
                    }
                }
            }
        }
    }

    @OptIn(ExperimentalLayoutApi::class)
    @Composable
    private fun Content() {
        FlowRow(
            horizontalArrangement = Arrangement.spacedBy(4.dp),
            modifier = Modifier.fillMaxWidth()
        ) {
            val filters = remember {
                listOf(
                    "TEST", // All
                    "TEST2",
                    "TEST3",
                )
            }

            val selectedFilter = filters.first()

            for (tag in filters) {
                FilterChip(
                    onClick = {
                    },
                    selected = tag == selectedFilter,
                    colors = ChipDefaults.filterChipColors(
                        selectedBackgroundColor = AppTheme.colors.primary,
                        selectedContentColor = AppTheme.colors.white,
                        backgroundColor = AppTheme.colors.white,
                        contentColor = AppTheme.colors.darkBlack,
                    ),
                ) {
                    Text(
                        text = tag,
                        style = AppTheme.typography.body14sp,
                        fontWeight = FontWeight.W500,
                    )
                }
            }
        }
    }
}

Stack trace (if applicable):

                 java.lang.IllegalStateException: Place was called on a node which was placed already
                 	at androidx.compose.ui.internal.InlineClassHelperKt.throwIllegalStateException(InlineClassHelper.kt:26)
                 	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.onNodePlaced$ui_release(LayoutNodeLayoutDelegate.kt:2061)
                 	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.placeOuterCoordinator-MLgxB_4(LayoutNodeLayoutDelegate.kt:863)
                 	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.placeSelf-MLgxB_4(LayoutNodeLayoutDelegate.kt:839)
                 	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.placeAt-f8xVGno(LayoutNodeLayoutDelegate.kt:765)
                 	at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:35)
                 	at androidx.compose.ui.layout.Placeable$PlacementScope.placeRelativeWithLayer-aW-9-wM(Placeable.kt:626)
                 	at androidx.compose.ui.layout.Placeable$PlacementScope.placeRelativeWithLayer-aW-9-wM$default(Placeable.kt:280)
                 	at androidx.compose.foundation.pager.MeasuredPage.place(MeasuredPage.kt:106)
                 	at androidx.compose.foundation.pager.PagerMeasureKt$measurePager$14.invoke(PagerMeasure.kt:457)
                 	at androidx.compose.foundation.pager.PagerMeasureKt$measurePager$14.invoke(PagerMeasure.kt:455)
                 	at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$Scope$layout$1.placeChildren(SubcomposeLayout.kt:923)
                 	at androidx.compose.foundation.pager.PagerMeasureResult.placeChildren(Unknown Source:2)
                 	at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$createMeasurePolicy$1$measure-3p2s80s$$inlined$createMeasureResult$2.placeChildren(SubcomposeLayout.kt:1015)
                 	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate$layoutChildrenBlock$1.invoke(LayoutNodeLayoutDelegate.kt:429)
                 	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate$layoutChildrenBlock$1.invoke(LayoutNodeLayoutDelegate.kt:424)
                 	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:503)
                 	at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:502)
                 	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:258)
                 	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:133)
                 	at androidx.compose.ui.node.OwnerSnapshotObserver.observeLayoutSnapshotReads$ui_release(OwnerSnapshotObserver.kt:83)
                 	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.layoutChildren(LayoutNodeLayoutDelegate.kt:457)
                 	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.onNodePlaced$ui_release(LayoutNodeLayoutDelegate.kt:627)
                 	at androidx.compose.ui.node.InnerNodeCoordinator.onAfterPlaceAt(InnerNodeCoordinator.kt:182)
                 	at androidx.compose.ui.node.InnerNodeCoordinator.placeAt-f8xVGno(InnerNodeCoordinator.kt:169)
                 	at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:35)
                 	at androidx.compose.ui.layout.Placeable$PlacementScope.placeWithLayer(Placeable.kt:646)
                 	at androidx.compose.ui.layout.Placeable$PlacementScope.placeWithLayer$default(Placeable.kt:327)
                 	at androidx.compose.ui.graphics.SimpleGraphicsLayerModifier$measure$1.invoke(GraphicsLayerModifier.kt:648)
                 	at androidx.compose.ui.graphics.SimpleGraphicsLayerModifier$measure$1.invoke(GraphicsLayerModifier.kt:647)
                 	at androidx.compose.ui.node.LookaheadCapablePlaceable$layout$1.placeChildren(LookaheadDelegate.kt:223)
                 	at androidx.compose.ui.node.LayoutModifierNodeCoordinator.onAfterPlaceAt(LayoutModifierNodeCoordinator.kt:270)
                 	at androidx.compose.ui.node.LayoutModifierNodeCoordinator.placeAt-f8xVGno(LayoutModifierNodeCoordinator.kt:247)
                 	at androidx.compose.ui.layout.Placeable.access$placeAt-f8xVGno(Placeable.kt:35)
                 	at androidx.compose.ui.layout.Placeable$PlacementScope.placeWithLayer-aW-9-wM(Placeable.kt:649)
15:11:25.677  E  	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate$placeOuterCoordinatorBlock$1.invoke(LayoutNodeLayoutDelegate.kt:570)
                 	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate$placeOuterCoordinatorBlock$1.invoke(LayoutNodeLayoutDelegate.kt:552)
                 	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2441)
                 	at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:502)
                 	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:258)
                 	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:133)
                 	at androidx.compose.ui.node.OwnerSnapshotObserver.observeLayoutModifierSnapshotReads$ui_release(OwnerSnapshotObserver.kt:98)
                 	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.placeOuterCoordinator-MLgxB_4(LayoutNodeLayoutDelegate.kt:871)
                 	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.replace(LayoutNodeLayoutDelegate.kt:889)
                 	at androidx.compose.ui.node.LayoutNode.replace$ui_release(LayoutNode.kt:987)
                 	at androidx.compose.ui.node.MeasureAndLayoutDelegate.measureAndLayout-0kLqBqw(MeasureAndLayoutDelegate.kt:465)
                 	at androidx.compose.ui.platform.AndroidComposeView.measureAndLayout-0kLqBqw(AndroidComposeView.android.kt:1280)
                 	at androidx.compose.ui.node.LayoutNode.forceRemeasure(LayoutNode.kt:1296)
                 	at androidx.compose.foundation.pager.PagerState.performScroll(PagerState.kt:279)
                 	at androidx.compose.foundation.pager.PagerState.access$performScroll(PagerState.kt:152)
                 	at androidx.compose.foundation.pager.PagerState$scrollableState$1.invoke(PagerState.kt:213)
                 	at androidx.compose.foundation.pager.PagerState$scrollableState$1.invoke(PagerState.kt:213)
                 	at androidx.compose.foundation.gestures.DefaultScrollableState$scrollScope$1.scrollBy(ScrollableState.kt:184)
                 	at androidx.compose.foundation.gestures.ScrollingLogic.performScroll-3eAAhYA(Scrollable.kt:717)
                 	at androidx.compose.foundation.gestures.ScrollingLogic.access$performScroll-3eAAhYA(Scrollable.kt:642)
                 	at androidx.compose.foundation.gestures.ScrollingLogic$nestedScrollScope$1.scrollBy-OzD1aCk(Scrollable.kt:683)
                 	at androidx.compose.foundation.gestures.ContentInViewNode$launchAnimation$2$1$1.invoke(ContentInViewNode.kt:215)
                 	at androidx.compose.foundation.gestures.ContentInViewNode$launchAnimation$2$1$1.invoke(ContentInViewNode.kt:201)
                 	at androidx.compose.foundation.gestures.UpdatableAnimationState$animateToZero$4.invoke(UpdatableAnimationState.kt:134)
                 	at androidx.compose.foundation.gestures.UpdatableAnimationState$animateToZero$4.invoke(UpdatableAnimationState.kt:101)
                 	at androidx.compose.runtime.BroadcastFrameClock$FrameAwaiter.resume(BroadcastFrameClock.kt:42)
                 	at androidx.compose.runtime.BroadcastFrameClock.sendFrame(BroadcastFrameClock.kt:76)
                 	at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$1.invoke(Recomposer.kt:592)
                 	at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$1.invoke(Recomposer.kt:585)
                 	at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:41)
                 	at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.android.kt:109)
                 	at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.android.kt:41)
                 	at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:69)
                 	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1404)
                 	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1415)
                 	at android.view.Choreographer.doCallbacks(Choreographer.java:1015)
                 	at android.view.Choreographer.doFrame(Choreographer.java:941)
                 	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1389)
                 	at android.os.Handler.handleCallback(Handler.java:959)
15:11:25.681  E  	at android.os.Handler.dispatchMessage(Handler.java:100)
                 	at android.os.Looper.loopOnce(Looper.java:232)
                 	at android.os.Looper.loop(Looper.java:317)
                 	at android.app.ActivityThread.main(ActivityThread.java:8705)
                 	at java.lang.reflect.Method.invoke(Native Method)
                 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
                 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:886)
                 	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [androidx.compose.ui.platform.MotionDurationScaleImpl@40617a1, androidx.compose.runtime.BroadcastFrameClock@9514dc6, Standalon

Comments

jo...@google.com <jo...@google.com> Feb 7, 2025 06:23PM

Reassigned to le...@google.com.

le...@google.com <le...@google.com> #2Feb 21, 2025 01:13PM

Automatic regression verification started for measurement:

ChromiumPerf/android-pixel6-perf/system_health.memory_mobile/memory:chrome:all_processes:reported_by_chrome:malloc:max_committed_size_avg/browse_news

Verification workflow id: projects/62121018386/locations/us-central1/workflows/sandwich-verification-workflow-prod/executions/f430dab5-4642-48dd-a3d6-a50904c1d68e

Message last modified on Feb 21, 2025 01:15PM

Issue 394760799

Description

Issue summary

Comments

jo...@google.com <jo...@google.com> Feb 7, 2025 06:23PM

le...@google.com <le...@google.com> #2Feb 21, 2025 01:13PM

Add comment

Issue metadata