IssueTracker

I've been getting a significant number of StringIndexOutOfBoundsExceptions from textview on Android 15 (enough to push my Crash rate to exceed the overall bad behavior threshold). The typical exception is below.

Exception java.lang.StringIndexOutOfBoundsException:
  at java.lang.String.checkBoundsBeginEnd (String.java:4500)
  at java.lang.String.substring (String.java:2527)
  at java.lang.String.subSequence (String.java:2577)
  at android.widget.TextView.onProvideStructure (TextView.java:14002)
  at android.view.View.onProvideContentCaptureStructure (View.java:9636)
  at android.view.contentcapture.MainContentCaptureSession.prepareViewStructures (MainContentCaptureSession.java:969)
  at android.view.contentcapture.MainContentCaptureSession.lambda$notifyContentCaptureEvents$7 (MainContentCaptureSession.java:931)
  at android.view.contentcapture.MainContentCaptureSession.$r8$lambda$anKP29NRI_kE85D6_Du0O3NBs_o (Unknown Source)
  at android.view.contentcapture.MainContentCaptureSession$$ExternalSyntheticLambda2.run (D8$$SyntheticClass)
  at android.view.contentcapture.MainContentCaptureSession.runOnUiThread (MainContentCaptureSession.java:1151)
  at android.view.contentcapture.MainContentCaptureSession.notifyContentCaptureEvents (MainContentCaptureSession.java:930)
  at android.view.ViewRootImpl.notifyContentCaptureEvents (ViewRootImpl.java:4610)
  at android.view.ViewRootImpl.performTraversals (ViewRootImpl.java:4387)
  at android.view.ViewRootImpl.doTraversal (ViewRootImpl.java:2977)
  at android.view.ViewRootImpl$TraversalRunnable.run (ViewRootImpl.java:10429)
  at android.view.Choreographer$CallbackRecord.run (Choreographer.java:1415)
  at android.view.Choreographer$CallbackRecord.run (Choreographer.java:1424)
  at android.view.Choreographer.doCallbacks (Choreographer.java:1024)
  at android.view.Choreographer.doFrame (Choreographer.java:953)
  at android.view.Choreographer$FrameDisplayEventReceiver.run (Choreographer.java:1398)
  at android.os.Handler.handleCallback (Handler.java:991)
  at android.os.Handler.dispatchMessage (Handler.java:102)
  at android.os.Looper.loopOnce (Looper.java:232)
  at android.os.Looper.loop (Looper.java:317)
  at android.app.ActivityThread.main (ActivityThread.java:8787)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:591)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:871)

and here's the code from TextView that appears to be causing the issue.

if (expandedTopChar > 0 || expandedBottomChar < text.length()) {
  // Cap the offsets to avoid an OOB exception. That can happen if the
  // displayed/layout text, on which these offsets are calculated, is longer
  // than the original text (such as when the view is translated by the
  // platform intelligence).
  // TODO(b/196433694): Figure out how to better handle the offset
  // calculations for this case (so we don't unnecessarily cutoff the original
  // text, for example).
  expandedTopChar = Math.min(expandedTopChar, text.length());
  expandedBottomChar = Math.min(expandedBottomChar, text.length());
  text = text.subSequence(expandedTopChar, expandedBottomChar);
}

Clearly from this code the index can end up as text.length() instead of text.length() - 1 causing the StringIndexOutOfBoundsException.

The textview code i was looking at is from here:

https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/widget/TextView.java

I'm not sure if that's the latest.