Status Update
No update yet.
Comments
rk...@google.com
rk...@google.com
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
or...@gmail.com
rk...@google.com
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
or...@gmail.com
I created the VMs via the Android Studio wizard.
One path:
Android Studio Meerkat Feature Drop | 2024.3.2 Canary 4
1. New virtual device
2. Pixel 1
3. Oreo x86 PLAY, nothing changed in advanced settings
4. Finish
5. Fails to boot
rk...@google.com
You could try our latest build:
I removed allocating of CMA (to save memory) if another allocator is available (we introduced it around API29), but I am not sure why this affects API26. I can try 35.2.7 tomorrow, but so far I was not able to repro.
rk...@google.com
jp...@google.com
Hi
For info, I was not able to reproduce the problem as well ( like mentioned in
I tried to current canary (35.5.2) but also the 35.2.6 and 35.2.7, and I was able to boot properly an AVD based on API29 (Google Play) on a Pixel skin.
As proposed in #6, did you try our latest build as well?
Thanks
or...@gmail.com
I don't have issue with the API 29 image or newer. Only with versions below API 29.
rk...@google.com
Unfortunately, we cannot reproduce. API26 (OSR1.170901.043, playstore, x86) boots on 35.2.7 (12265550).
Could you please attach Library/Android/sdk/system-images/android-26/default/x86/advancedFeatures.ini? Maybe it contains GLDirectMem (it should not).
jp...@google.com
Hi
Sorry for the misunderstanding. I thought we were talking about "API 29 included".
However, as said in #9, even API26 is booting for us on Mac Intel , on emulator 35.2.7 and 35.5.2
As proposed above, please attach your ~/Library/Android/sdk/system-images/android-26/default/x86/advancedFeatures.ini
Thanks
or...@gmail.com
I attached the file. I tried to add GLDirectMem = off now, but it does not have any effect. If I create a kernel_cmdline.txt file with the cma param above, it boots correctly.
rk...@google.com
I don't know why the Emulator thinks that GLDirectMem is enabled in API26. You could try passing -feature -GLDirectMem on the Emulator command line to check if it makes a difference. Maybe you have advancedFeatures.ini somewhere on your machine which the Emulator happens reading. You can try debugging/grepping yourself.
Description
Emulators fail to boot under API 29. They worked in a earlier version of the emulator.
I attached the relevant boot logs. The WM-s were created with default settings.