Deeplink matches with wrong url when sharing deeplink action [395712033]

Fixed

Bug

Status Update

No update yet.

Description

cl...@google.com

created issue #1

Feb 10, 2025 11:14PM

If a NavGraph has multiple NavDestinations, each with a deeplink that share the same action i.e.

composable(
    route = "A",
    deepLinks = listOf(
        navDeepLink {
            uriPattern = "https://example.com/{id}"
            action = Intent.ACTION_VIEW
        },
    ),
    ...
)

composable(
    route = "B",
    deepLinks = listOf(
        navDeepLink {
            uriPattern = "https://completelyDifferentUrl.com"
            action = Intent.ACTION_VIEW
        },
    ),
    ...
)

Deeplink "https://example.com/2" would actually match with https://completelyDifferentUrl.com rather than the exact match https://example.com/{id}.

We would expect deeplink to match with the url that has a better path + argument match.

Comments

lo...@gmail.com <lo...@gmail.com> #2Feb 12, 2025 10:11AM

Hi,

Thank you for your feedback. Could you help provide logs when the issue occurs and if possible a code snippet of the part that uses CameraX, it will help us find the root cause.

A quick question: does this issue occur on other devices, or only on Samsung Galaxy M55.

Message last modified on Feb 12, 2025 10:12AM

cl...@google.com <cl...@google.com> #3Feb 12, 2025 05:55PM

Hey,
attaching the logs.
The issue is only reproducible of M55. We have not met this on any other.

cl...@google.com <cl...@google.com> Feb 19, 2025 05:37PM

Accepted by cl...@google.com.

cl...@google.com <cl...@google.com> #4Feb 19, 2025 10:50PM

Marked as fixed.

Thank you,

CameraX uses OpenGL for sharing stream between Preview and VideoCapture to provide use case combinations beyond device's native capabilities. When using Preview + ImageAnalysis or Preview + VideoCapture, the device capabilities are usually not exceeded, so stream sharing is not used. So this could be a device specified issue related to OpenGL.

We will attempt to acquire the reported device model for testing.

ap...@google.com <ap...@google.com> #5Feb 19, 2025 10:50PM

Thanks for the update,
Yes I'm aware that stream sharing is not a hardware supported feature.
Please let me know if we could assist in any way to solve the issue.

ba...@gocity.com <ba...@gocity.com> #6Feb 27, 2025 12:37PM

Hey guys,
Is there any update on this? Were you able to find the phone? Could we assist here somehow?

cl...@google.com <cl...@google.com> #7Feb 27, 2025 07:24PM

Thank you for your kind reply! I think we will receive the phone in a while and we will update if we find anything.

Message last modified on Feb 27, 2025 07:24PM

e....@gmail.com <e....@gmail.com> #8Mar 4, 2025 10:29AM

Hi,

We got the device and did some investigating. The root cause seems to be that Samsung M55 has issues when using ImageAnalysis with another stream that uses TEMPLATE_RECORD, which is typically used by VideoCapture or by a stream shared between VideoCapture and Preview.

The issue also occurs when only ImageAnalysis and VideoCapture are bound. The video can only obtain the first few frames in this case.

We will fix this issues in a future release. One workaround you can try is to bind an additional ImageCaputre usecase (binds all 4 usecases), it seems the stream is normal in this situation.

Thanks for finding this bug!

ba...@gocity.com <ba...@gocity.com> #9Mar 11, 2025 09:08AM

Hi,
thank you for the information provided.
Is it possible that the bug will be fixed in 1.3.* release? It seems quite severe as it blocks main functionality.

cl...@google.com <cl...@google.com> #10Mar 11, 2025 03:52PM

Since in #comment1 the error was reported for the 1.4.1 release, maybe you meant 1.4.* release?

We will fix on both the 1.4 stable release, and the current 1.5 release. For 1.3, it is recommended to migrate to the 1.4 stable version. Or use one of the following workarounds:

bind an addiotional ImageCapture use case
use Camera2Interop to change VideoCapture builder's CONTROL_CAPTURE_INTENT to CONTROL_CAPTURE_INTENT_PREVIEW. As in the following code snippet:

VideoCapture.Builder<Recorder> videoCaptureBuilder = new VideoCapture.Builder<>(recorder);
new Camera2Interop.Extender<>(videoCaptureBuilder).setCaptureRequestOption(CaptureRequest.CONTROL_CAPTURE_INTENT, CaptureRequest.CONTROL_CAPTURE_INTENT_PREVIEW);