Status Update
Comments
sc...@google.com <sc...@google.com>
mi...@google.com <mi...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <
Link:
Clean-up SavedState Serialization Reified functions
Expand for full commit details
Clean-up SavedState Serialization Reified functions
- Ensure their positioning and "call hierarchy" match each other.
- Make the KDocs consistent with KTX Serialization.
RelNote: "N/A"
Bug: b/399629301
Test: N/A
Change-Id: Icb6924b6f1929d4a3c00ded922c74e83fbe163f1
Files:
- M
lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/serialization/SavedStateHandleDelegates.kt
- M
savedstate/savedstate/api/current.txt
- M
savedstate/savedstate/api/restricted_current.txt
- M
savedstate/savedstate/bcv/native/current.txt
- M
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateDecoder.kt
- M
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateEncoder.kt
- M
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateRegistryOwnerDelegates.kt
Hash: 4f4e3cf53813a572ddd78967a279e9d5415ac615
Date: Mon Feb 24 13:54:34 2025
an...@revolut.com <an...@revolut.com> #3
Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <
Link:
Rename file SavedStateDelegates to SavedStateDelegate
Expand for full commit details
Rename file SavedState*Delegates to SavedState*Delegate
- File name now matches the class name `SavedState*Delegate`.
- That is consistent with `SavedStateDecoder.kt` and `SavedStateEncoder.kt` that are named after the `internal class` but expose only top-level functions (`SavedStateDecoderKt.method()` or `SavedStateEncoderKt.method()`).
RelNote: "Rename `SavedState*Delegates` to `SavedState*Delegate`."
Bug: 399629301
Test: N/A
Change-Id: I8589b62294646cb4529869228ea0185dac6087e6
Files:
- M
lifecycle/lifecycle-viewmodel-savedstate/api/current.txt
- M
lifecycle/lifecycle-viewmodel-savedstate/api/restricted_current.txt
- M
lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/serialization/SavedStateHandleDelegateTest.kt
- M
lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/serialization/SavedStateHandleDelegate.kt
- M
savedstate/savedstate/api/current.txt
- M
savedstate/savedstate/api/restricted_current.txt
- M
savedstate/savedstate/bcv/native/current.txt
- M
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateRegistryOwnerDelegate.kt
- M
savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/SavedStateRegistryOwnerDelegateTest.kt
Hash: d749bb5032edfe9547da480963da3c559b874023
Date: Fri Feb 28 14:18:38 2025
mi...@google.com <mi...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <
Link:
Rename SavedStateConfig to SavedStateConfiguration
Expand for full commit details
Rename SavedStateConfig to SavedStateConfiguration
- Previously called `SavedStateConfig`, we have decide to match the name used by the other KotlinX Serialization format configs.
RelNote: "Rename `SavedStateConfig` to `SavedStateConfiguration`."
Bug: 399629301
Test: N/A
Change-Id: I043a5be95276ef617588559f5e3fcdb15905b793
Files:
- M
lifecycle/lifecycle-viewmodel-savedstate/api/current.txt
- M
lifecycle/lifecycle-viewmodel-savedstate/api/restricted_current.txt
- M
lifecycle/lifecycle-viewmodel-savedstate/bcv/native/current.txt
- M
lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/serialization/SavedStateHandleDelegatesTest.kt
- M
lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/serialization/SavedStateHandleDelegates.kt
- M
savedstate/savedstate-compose/src/androidInstrumentedTest/kotlin/androidx/savedstate/compose/serialization/serializers/MutableStateSerializerTest.android.kt
- M
savedstate/savedstate-samples/src/main/java/androidx/savedstate/SavedStateCodecSamples.kt
- M
savedstate/savedstate/api/current.txt
- M
savedstate/savedstate/api/restricted_current.txt
- M
savedstate/savedstate/bcv/native/current.txt
- M
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/ClassDiscriminatorMode.kt
- M
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateConfiguration.kt
- M
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateDecoder.kt
- M
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateEncoder.kt
- M
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateRegistryOwnerDelegates.kt
- M
savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateCodecTest.kt
- M
savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateCodecTestUtils.kt
- M
savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/MutableStateFlowSerializerTest.kt
- M
savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/SavedStateCodecClassDiscriminatorAllObjectsTest.kt
- M
savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/SavedStateCodecClassDiscriminatorPolymorphicTest.kt
- M
savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/SavedStateCodecEncodeDefaultsTest.kt
- M
savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/SavedStateRegistryOwnerDelegatesTest.kt
- M
savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/utils/SavedStateSerializationBaseTest.kt
Hash: db71d74194b21d66c591aebfa5b6ea0398f0cd51
Date: Mon Feb 24 14:33:00 2025
an...@revolut.com <an...@revolut.com> #5
Android API Change
This bug was referenced by a recent CL that changed the Android API surface area.
The
We'll wait until you mark this bug as 'Fixed' before starting our review, but please reach out if you'd like us to review it sooner.
Changes to lifecycle/lifecycle-viewmodel-savedstate/api/current.txt
- androidx.lifecycle.serialization
- androidx.lifecycle.serialization.SavedStateHandleDelegateKt
- androidx.lifecycle.serialization.SavedStateHandleDelegatesKt
Changes to savedstate/savedstate/api/current.txt
- androidx.savedstate.serialization
- androidx.savedstate.serialization.SavedStateRegistryOwnerDelegateKt
- androidx.savedstate.serialization.SavedStateRegistryOwnerDelegatesKt
[Gerrit:https://android-review.googlesource.com/3517474]
[API-Approvers:
[Branch:androidx-main]
[LIBRARY_API_REVIEW_TAG:lifecycle/lifecycle-viewmodel-savedstate/api/current.txt]
[LIBRARY_API_REVIEW_TAG:savedstate/savedstate/api/current.txt]
an...@revolut.com <an...@revolut.com> #6
Android API Change
This bug was referenced by a recent CL that changed the Android API surface area.
The
We'll wait until you mark this bug as 'Fixed' before starting our review, but please reach out if you'd like us to review it sooner.
Changes to lifecycle/lifecycle-viewmodel-savedstate/api/current.txt
- androidx.lifecycle.serialization
- androidx.lifecycle.serialization.SavedStateHandleDelegatesKt
Changes to savedstate/savedstate/api/current.txt
- androidx.savedstate.serialization
- androidx.savedstate.serialization.SavedStateConfig
- androidx.savedstate.serialization.SavedStateConfig.Builder
- androidx.savedstate.serialization.SavedStateConfig.Companion
- androidx.savedstate.serialization.SavedStateConfigKt
- androidx.savedstate.serialization.SavedStateConfiguration
- androidx.savedstate.serialization.SavedStateConfiguration.Builder
- androidx.savedstate.serialization.SavedStateConfiguration.Companion
- androidx.savedstate.serialization.SavedStateConfigurationKt
- androidx.savedstate.serialization.SavedStateDecoderKt
- androidx.savedstate.serialization.SavedStateEncoderKt
- androidx.savedstate.serialization.SavedStateRegistryOwnerDelegatesKt
[Gerrit:https://android-review.googlesource.com/3506352]
[API-Approvers:
[Branch:androidx-main]
[LIBRARY_API_REVIEW_TAG:lifecycle/lifecycle-viewmodel-savedstate/api/current.txt]
[LIBRARY_API_REVIEW_TAG:savedstate/savedstate/api/current.txt]
mi...@google.com <mi...@google.com> #7
Android API Change
This bug was referenced by a recent CL that changed the Android API surface area.
The
We'll wait until you mark this bug as 'Fixed' before starting our review, but please reach out if you'd like us to review it sooner.
Changes to savedstate/savedstate/api/current.txt
- androidx.savedstate.serialization
- androidx.savedstate.serialization.SavedStateDecoderKt
- androidx.savedstate.serialization.SavedStateEncoderKt
[Gerrit:https://android-review.googlesource.com/3506351]
[API-Approvers:
[Branch:androidx-main]
[LIBRARY_API_REVIEW_TAG:savedstate/savedstate/api/current.txt]
mi...@google.com <mi...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <
Link:
Simplify SavedStateReader.contentDeepToString
Expand for full commit details
Simplify `SavedStateReader.contentDeepToString`
- This change simplifies `SavedStateReader.contentDeepToString` by:
- Removing redundant delegation to `SavedState.contentDeepToString()` and `contentDeepToStringInternal()`.
- Eliminating one method call.
- Renaming `contentDeepToStringInternal` to `contentDeepToString` for clarity.
- The behavior of the method remains unchanged.
Test: SavedStateTest
Bug: b/399629301
Change-Id: Ia63e780faa89eaeddea3916649c20751ab411584
Files:
- M
savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateReader.android.kt
- M
savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateReader.nonAndroid.kt
Hash: 841315abc416eabc22ac0ec69f53ff84524563f9
Date: Wed Mar 12 11:53:52 2025
an...@revolut.com <an...@revolut.com> #9
Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <
Link:
Improve SavedStateReader KDocs
Expand for full commit details
Improve SavedStateReader KDocs
- This change updates the SavedStateReader KDocs to:
- Accurately reflect exception behavior for `get*` methods following API changes (aosp/3500556, aosp/3523152, aosp/3523154)
- Clarify the definition of a "valid value" within SavedState.
- Enhance `getOrNull` method KDocs, including auto-boxing notes where relevant (aosp/3523151).
- Correct grammatical errors (e.g., "an Array", pluralization).
Test: N/A
Bug: b/399629301
Change-Id: I35734fa13e9e846df25aba0709e62e53943e2281
Files:
- M
savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateReader.android.kt
- M
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateReader.kt
Hash: 4447f2ce4c6f0c84d79ab80fac4a417252254167
Date: Wed Mar 12 11:48:01 2025
mi...@google.com <mi...@google.com> #10
Hi
Since in
We will fix on both the 1.4 stable release, and the current 1.5 release. For 1.3, it is recommended to migrate to the 1.4 stable version. Or use one of the following workarounds:
- bind an addiotional
ImageCapture
use case - use
to changeCamera2Interop VideoCapture
builder'sCONTROL_CAPTURE_INTENT
to . As in the following code snippet:CONTROL_CAPTURE_INTENT_PREVIEW
VideoCapture.Builder<Recorder> videoCaptureBuilder = new VideoCapture.Builder<>(recorder);
new Camera2Interop.Extender<>(videoCaptureBuilder).setCaptureRequestOption(CaptureRequest.CONTROL_CAPTURE_INTENT, CaptureRequest.CONTROL_CAPTURE_INTENT_PREVIEW);
an...@revolut.com <an...@revolut.com> #11
you're correct I meant 1.4.*.
Thanks for the clarification!
mi...@google.com <mi...@google.com>
ap...@google.com <ap...@google.com> #12
Project: platform/frameworks/support
Branch: androidx-main
Author: mingdatsai <
Link:
Fix preview freeze when using ImageAnalysis with a TEMPLATE_RECORD stream
Expand for full commit details
Fix preview freeze when using ImageAnalysis with a TEMPLATE_RECORD stream
Fixed preview freeze issue when using ImageAnalysis with another stream
using TEMPLATE_RECORD.
Relnote: "Fixed preview freeze issue when using ImageAnalysis with another stream that uses TEMPLATE_RECORD on Samsung SM-M556B device."
Bug: 395822788
Test: manual test and ./gradlew bOS
Change-Id: Ic1a6a019c1525f30d7b863f732d421e36e5c978c
Files:
- A
camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/compat/quirk/AbnormalStreamWhenImageAnalysisBindWithTemplateRecordQuirk.kt
- M
camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/compat/quirk/CameraQuirks.kt
- M
camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/compat/workaround/TemplateParamsOverride.kt
- A
camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/AbnormalStreamWhenImageAnalysisBindWithTemplateRecordQuirk.java
- M
camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/CameraQuirks.java
- M
camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/workaround/TemplateParamsOverride.java
Hash: 5b6e8ca646e994efd623332cfe36445ef09d3c23
Date: Mon Mar 10 13:00:18 2025
an...@revolut.com <an...@revolut.com> #13
I took a look at the fix and I guess it might be a slight problem with it. It only fixes "SM-M556B" but we are positive that the problem also exists for "SM-M556E".
mi...@google.com <mi...@google.com> #14
Thank you for catching this, I will make a change for this.
ap...@google.com <ap...@google.com> #15
Project: platform/frameworks/support
Branch: androidx-main
Author: mingdatsai <
Link:
Apply AbnormalStreamWhenImageAnalysisBindWithTemplateRecordQuirk for other M55 models
Expand for full commit details
Apply AbnormalStreamWhenImageAnalysisBindWithTemplateRecordQuirk for other M55 models
Bug: 395822788
Test: manual test and ./gradlew bOS
Change-Id: I1768c199f0a4a62e82c7d75f89af574c3eda8604
Files:
- M
camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/compat/quirk/AbnormalStreamWhenImageAnalysisBindWithTemplateRecordQuirk.kt
- M
camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/AbnormalStreamWhenImageAnalysisBindWithTemplateRecordQuirk.java
Hash: 0425e0aeba7e562f6d6f99a8d976355f6d563dae
Date: Wed Mar 12 11:55:49 2025
mi...@google.com <mi...@google.com> #16
Hi,
The fix has been merged. It will be released in the subsequest CameraX version, probably 1.4.2 (also on the current 1.5 branch).
I will close the bug, please feel free to reopen it if there are any issues.
Description
Please describe your issue and include details such as the version of CameraX you are using and any relevant logs related to your issue.
// If at all possible, capture an Android logcat (
CAMERAX VERSION 1.4.1
ANDROID OS BUILD NUMBER: UP1A.231005.007.M556EXXS4AYA1
DEVICE NAME: Samsung Galaxy M55
DESCRIPTION:
Hey,
We've encountered a problem with Samsung Galaxy M55 5G device.
In our app preview freezes after rendering a few frames. We use image analysis, video recording and preview use cases. If I disable image analysis or video recording use case preview works as intended. Stream sharing is active and log cat has messages like hat in the output:
"62479362 updateSurface: has no frame
EglImage dataspace changed, need recreate"
Implementation mode is set to COMPATIBLE(tested PERFORMANCE as well - same result).
EXPECTED RESULTS: Preview doesn't freeze
REPRODUCIBILITY: 100%