New beta autofill doesn't work properly for password type [395911609]

Fixed

Bug

Status Update

No update yet.

Description

te...@gmail.com

created issue #1

Feb 12, 2025 08:40AM

Jetpack Compose version: 1.8.0-beta01

Jetpack Compose component used: androidx.compose.ui:ui-tooling

Android Studio Build: #AI-242.23339.11.2421.12700392

Kotlin version: 2.0.20

When you try to use the new autofill semantics functionality on a textfield with a visualTransformation the password manager will store asterisks as the password instead of the actual value, e.g ******** instead of password, rendering the feature useless. If I remove the visual transformation everything works as intended.

Steps to Reproduce or Code Sample to Reproduce:

OutlinedTextField(
  visualTransformation = if (showPassword) VisualTransformation.None else PasswordVisualTransformation(),
  modifier = Modifier.semantics {
    contentType = ContentType.Password
  }
  ...
)

Comments

so...@google.com <so...@google.com> Feb 13, 2025 09:59PM

Reassigned to an...@google.com.

ra...@google.com <ra...@google.com> #2Feb 13, 2025 10:01PM

Reassigned to ra...@google.com.

Hi, thanks for reporting. Should be an easy fix!

I'm guessing it should work find until ~ 2^23 items = ~ 8M items. How did you come across this bug? Do you have a ViewPager2 with that many items?

ch...@gmail.com <ch...@gmail.com> #3Feb 14, 2025 09:17AM

Hi, good to hear that.

We have an implementation of RecyclerView.Adapter that supports "infinite looping". So when the infinite looping is enabled, the adapter's getItemCount() reports Int.MAX_VALUE items. We also call setCurrentItem to somewhere in the middle of item count on the ViewPager2, so that's how we got that far.

ap...@google.com <ap...@google.com> #4Feb 18, 2025 08:14PM

For future reference: first item for which it fails is probably when mCurrentItem = (1 << 25) + 2

ma...@google.com <ma...@google.com> #5Feb 18, 2025 09:37PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 2e9f35536432bed0677171c8ae59b4f67850915a
Author: Jelle Fresen <jellefresen@google.com>
Date: Fri Jul 12 14:26:10 2019

Use double instead of float for decimal positions

A position ranges from 0 to Integer.MAX_VALUE, but floats only have a 23
bit mantissa. Values over 2^23 are rounded to a nearby value.

Solve this by using double instead of float when we need to represent a
position with a fractional component. A double has a mantissa of 52 bit
and can therefore represent all 2^32 possible int values.

Bug: 134858960
Test: ./gradlew viewpager2:cC
Change-Id: I08b97df6fac600caa83366ccab8671541e2c1e7f

A viewpager2/src/androidTest/java/androidx/viewpager2/test/ui/SparseAdapter.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/FakeDragTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/OffscreenPageLimitTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/PageChangeCallbackTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/PageTransformerTest.kt
M viewpager2/src/androidTest/java/androidx/viewpager2/widget/SetItemWhileScrollInProgressTest.kt
M viewpager2/src/main/java/androidx/viewpager2/widget/ScrollEventAdapter.java
M viewpager2/src/main/java/androidx/viewpager2/widget/ViewPager2.java

https://android-review.googlesource.com/1014538

https://goto.google.com/android-sha1/2e9f35536432bed0677171c8ae59b4f67850915a

ap...@google.com <ap...@google.com> #6Feb 19, 2025 10:28PM

Fixed in now released beta03 -

https://developer.android.com/jetpack/androidx/releases/viewpager2#1.0.0-beta03

ra...@google.com <ra...@google.com> Feb 20, 2025 07:39AM

Marked as fixed.

da...@well.co <da...@well.co> #7Mar 3, 2025 04:34PM

Megan can we use the deprecated autofill APIs on beta01/02. So we can update to the latest version but will use deprecated until beta03?

ma...@google.com <ma...@google.com> #8Mar 7, 2025 06:22PM

Hi David! Beta03 is now out, no need to use deprecated APIs