New beta autofill doesn't work properly for password type [395911609]

Fixed

Bug

Status Update

No update yet.

Description

te...@gmail.com

created issue #1

Feb 12, 2025 08:40AM

Jetpack Compose version: 1.8.0-beta01

Jetpack Compose component used: androidx.compose.ui:ui-tooling

Android Studio Build: #AI-242.23339.11.2421.12700392

Kotlin version: 2.0.20

When you try to use the new autofill semantics functionality on a textfield with a visualTransformation the password manager will store asterisks as the password instead of the actual value, e.g ******** instead of password, rendering the feature useless. If I remove the visual transformation everything works as intended.

Steps to Reproduce or Code Sample to Reproduce:

OutlinedTextField(
  visualTransformation = if (showPassword) VisualTransformation.None else PasswordVisualTransformation(),
  modifier = Modifier.semantics {
    contentType = ContentType.Password
  }
  ...
)

Comments

so...@google.com <so...@google.com> Feb 13, 2025 09:59PM

Reassigned to an...@google.com.

ra...@google.com <ra...@google.com> #2Feb 13, 2025 10:01PM

Reassigned to ra...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

ch...@gmail.com <ch...@gmail.com> #3Feb 14, 2025 09:17AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ap...@google.com <ap...@google.com> #4Feb 18, 2025 08:14PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

ma...@google.com <ma...@google.com> #5Feb 18, 2025 09:37PM

Hi all, we are intently working on fixing this bug. Please do not use Autofill APIs in beta02 or beta01 in any production apps for now. This will be fixed in beta03.

Please let us know if you have any other issues.
-Meghan

ap...@google.com <ap...@google.com> #6Feb 19, 2025 10:28PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Ralston Da Silva <ralu@google.com>
Link: https://android-review.googlesource.com/3499897

Introduce InputText Semantics Property

Expand for full commit details

Introduce InputText Semantics Property 
 
TextFields have an EditableText semantics property which 
stores the text value after output transformation. Autofill 
needs access to the text value after input transformation 
but before output transformation. Adding this semantics 
property helps send the right information to the Autofill 
service. 
 
Bug: 395911609 
Bug: 176949051 
Test: Added new tests and updated existing tests 
Relnote: "Added a new semantics property InputText that captures 
a textfield's value before output transformation is applied." 
 
Change-Id: Iae46a52e7fbb1a3558e897c5afebd125089befbb

Files:

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/input/BasicTextFieldSemanticsTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/input/internal/CoreTextFieldSemanticsModifier.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/input/internal/TextFieldDecoratorModifier.kt
M compose/ui/ui-test/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/ErrorMessagesTest.kt
M compose/ui/ui-test/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/FindersTest.kt
M compose/ui/ui-test/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/assertions/AssertText.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Assertions.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Filters.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/bcv/native/current.txt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/UiDemos.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/autofill/TextFieldAutofillDemo.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/autofill/AndroidAutofillManagerTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/autofill/AndroidAutofillManager.android.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt

Hash: dee965267730e9b0b1a865a991db3515cdfc4b25
Date: Tue Feb 18 16:11:58 2025

ra...@google.com <ra...@google.com> Feb 20, 2025 07:39AM

Marked as fixed.

da...@well.co <da...@well.co> #7Mar 3, 2025 04:34PM

Megan can we use the deprecated autofill APIs on beta01/02. So we can update to the latest version but will use deprecated until beta03?

ma...@google.com <ma...@google.com> #8Mar 7, 2025 06:22PM

Hi David! Beta03 is now out, no need to use deprecated APIs