IssueTracker

Component used: Navigation Safe-Args (navigation-safe-args-gradle-plugin)

Version used: 2.7.7, 2.8.7, 2.9.0-alpha06

Devices/Android versions reproduced on: Android 10 (compileSdk 34)

Navigation with not nullable args (at least boolean) produces incorrect code (to build/generated/source/navigation-args).

<fragment
        android:id="@+id/profileDetailFragment"
        android:name="com.example.ProfileDetailFragment"
        tools:layout="@layout/fragment_profile_detail">
        <argument
            android:name="deletingCapability"
            app:argType="boolean"
            android:defaultValue="true"/>
    </fragment>

public class ProfileListFragmentDirections {
  private ProfileListFragmentDirections() {
  }
...
  public static class ActionProfileListFragmentToProfileDetailFragment implements NavDirections {
    private final HashMap arguments = new HashMap();

    @NonNull
    @SuppressWarnings("unchecked")
    public ActionProfileListFragmentToProfileDetailFragment setDeletingCapability(
        boolean deletingCapability) {
      this.arguments.put("deletingCapability", deletingCapability);
      return this;
    }

    @NonNull
    @SuppressWarnings("unchecked")
    public ActionProfileListFragmentToProfileDetailFragment setDeletingCapability(
        boolean deletingCapability) {
      this.arguments.put("deletingCapability", deletingCapability);
      return this;
    }

    @Override
    @SuppressWarnings("unchecked")
    @NonNull
    public Bundle getArguments() {
      Bundle __result = new Bundle();
      if (arguments.containsKey("deletingCapability")) {
        boolean deletingCapability = (boolean) arguments.get("deletingCapability");
        __result.putBoolean("deletingCapability", deletingCapability);
      } else {
        __result.putBoolean("deletingCapability", true);
      }
      return __result;
    }

    @SuppressWarnings("unchecked")
    public boolean getDeletingCapability() {
      return (boolean) arguments.get("deletingCapability");
    }

    @Override
    public int hashCode() {
      int result = 1;
      result = 31 * result + (getDeletingCapability() ? 1 : 0);
      result = 31 * result + getActionId();
      return result;
    }

    @Override
    public String toString() {
      return "ActionProfileListFragmentToProfileDetailFragment(actionId=" + getActionId() + "){"
          + "deletingCapability=" + getDeletingCapability()
          + "}";
    }
}

SafeArgs produces getDeletingCapability method with base non-nullable type without safe casting or using default values. It's boolean in example, but the same happens for integer and other basic types. So in my case app crashes in NavDirections.onString()

FATAL EXCEPTION: main
Process: com.example, PID: 16259
java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference
  at com.example.ProfileListFragmentDirections$ActionProfileListFragmentToProfileDetailFragment.getDeletingCapability(ProfileListFragmentDirections.java:131)
  at com.example.ProfileListFragmentDirections$ActionProfileListFragmentToProfileDetailFragment.toString(ProfileListFragmentDirections.java:182)
  at java.lang.String.valueOf(String.java:2924)
  at java.lang.StringBuilder.append(StringBuilder.java:132)
  at ru.signalcom.androidtoken.activities.settings.UtilsKt.safeNavigate(UtilsKt.kt:113)