Assigned
Status Update
No update yet.
Comments
jl...@google.com
rp...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
de...@gmail.com
bo...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ca...@google.com
Hey Bo, I tried a fresh install of Iguana Patch 1 on my Windows 11 and set the sdk to install at the user/document folder and the emulator launched fine.
Description
Steps to Reproduce:
Install Android Studio on a Windows system.
Complete the installation process, including the installation of the Android SDK and emulator.
Attempt to launch an Android Virtual Device (AVD) from within Android Studio.
Observe that the emulator fails to start and reports an error similar to:
Process finished with exit code -1073741515 (0xC0000135)
Emulator terminated with exit code -1073741515
The emulator process for AVD <avd_name> has terminated.
Check the system PATH environment variable and observe that the emulator directory (e.g., C:\AndroidStudioSDK\emulator\) is not included.
Expected Behavior:
The Android Studio installer should automatically add the emulator directory (e.g., C:\AndroidStudioSDK\emulator\) to the system's PATH environment variable during the installation process. This would ensure that the emulator can locate its required DLL files and launch successfully without requiring manual intervention.
Actual Behavior:
The emulator directory is not added to the system PATH during installation. This results in the emulator failing to launch and reporting a STATUS_DLL_NOT_FOUND error. Users must manually add the emulator directory to the PATH to resolve the issue.
Impact:
User Frustration: Users, especially those new to Android development, may be confused and frustrated when the emulator fails to launch.
Time Loss: Users must spend time troubleshooting and manually configuring the PATH variable, which is an unnecessary burden.
Poor First Impression: This issue can create a negative first impression of Android Studio for new users.
Inconsistency: The emulator is installed as part of the Android SDK, and other tools in the SDK are added to the PATH automatically. The emulator should be added as well.
Environment:
Operating System: Windows (likely affects all Windows versions)
Android Studio Version: (Specify the version you encountered the issue with, e.g., Android Studio Iguana | 2023.2.1 Patch 1)
Emulator Version: (Specify the emulator version, e.g., 35.3.11.0)
Android SDK: (Specify the SDK version, e.g., 31)
Suggested Solution:
Modify the Android Studio installer to automatically add the emulator directory to the system's PATH environment variable. This should be done during the installation process, similar to how other Android SDK tools are added to the PATH.
Additional Information:
The issue can be resolved by manually adding the emulator directory to the PATH.
The error code -1073741515 (or 0xC0000135) is a strong indicator of this problem.
The emulator directory is usually located in C:\<AndroidSDK>\emulator.