Assigned
Status Update
No update yet.
Comments
jp...@google.com
The R8 build does include these files in our jar and they are not used/needed. I'll amend our build to avoid including them and merge it to the release branches.
bl...@google.com
Project: r8
Branch: master
commit 80533c96c4561ab997f18ce65dd2c0c6a37a33b5
Author: Ian Zerny <zerny@google.com>
Date: Thu Jan 24 10:32:09 2019
Don't include kotlin module files in distribution.
Bug: 123310328
Change-Id: Ie70d4b15f08ffc0e7b754c558079002bd6a84334
M build.gradle
https://r8-review.googlesource.com/33381
Branch: master
commit 80533c96c4561ab997f18ce65dd2c0c6a37a33b5
Author: Ian Zerny <zerny@google.com>
Date: Thu Jan 24 10:32:09 2019
Don't include kotlin module files in distribution.
Bug: 123310328
Change-Id: Ie70d4b15f08ffc0e7b754c558079002bd6a84334
M build.gradle
jp...@google.com
Project: r8
Branch: d8-1.3
commit 73a2e504b0edd45eac64b6f242346b2793eae1fe
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Jan 25 09:23:25 2019
Version 1.3.54
Manually applied: Don't include kotlin module files in distribution.
CL:https://r8-review.googlesource.com/c/r8/+/33381
Bug: 123310328
Change-Id: Ifa5057f0c09d864295e200c287fb3d54cd3c79bf
M build.gradle
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/33485
Branch: d8-1.3
commit 73a2e504b0edd45eac64b6f242346b2793eae1fe
Author: Søren Gjesse <sgjesse@google.com>
Date: Fri Jan 25 09:23:25 2019
Version 1.3.54
Manually applied: Don't include kotlin module files in distribution.
CL:
Bug: 123310328
Change-Id: Ifa5057f0c09d864295e200c287fb3d54cd3c79bf
M build.gradle
M src/main/java/com/android/tools/r8/Version.java
Description
Description
The documentation for Google Chat events mention a platform enum that allows the developer to determine if the event originates from WEB, IOS or ANDROID:
This enum is currently not supported by chat apps.
I propose that support be added for this enum to allow developers to determine which platform triggered the event.
Impact
Without this enum, it's difficult to build Google Chat app UIs that look great on both web and mobile.
There are many situations where 2-column cards look great on desktop, but do not function well on mobile devices.
Being able to determine web vs/ mobile interactions would allow developers to return a UI optimized for the device type requesting it.