Fix warnings shown when targeting Kotlin 2.0 [397736115]

In Progress

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Feb 19, 2025 09:16PM

AndroidX is preparing to move to target Kotlin language version 2.0. In order to make this transition smooth, please help fix these warnings ahead of this switch. You can reproduce it with the following command:

./gradlew -p lifecycle build -Pandroidx.forceKotlin20Target=true

> Task :lifecycle:lifecycle-common:compileKotlinJvm
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-common/src/jvmMain/kotlin/androidx/lifecycle/Lifecycle.jvm.kt:23:11 This code uses error suppression for 'ACTUAL_WITHOUT_EXPECT'. While it might compile and work, the compiler behavior is UNSPECIFIED and WON'T BE PRESERVED. Please report your use case to the Kotlin issue tracker instead: https://kotl.in/issue
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-common/src/jvmMain/kotlin/androidx/lifecycle/Lifecycle.jvm.kt:24:8 Annotation `@RestrictTo(value = [Scope.LIBRARY_GROUP] type=kotlin.Array<out androidx.annotation.RestrictTo.Scope> varargElementType=androidx.annotation.RestrictTo.Scope)` is missing on actual declaration.
All annotations from expect `androidx.lifecycle.AtomicReference` must be present with the same arguments on actual `java.util.concurrent.atomic.AtomicReference`, otherwise they might behave incorrectly.

> Task :lifecycle:lifecycle-runtime:compileReleaseKotlinAndroid
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:43:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:49:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:55:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:61:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:66:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:71:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.

> Task :lifecycle:lifecycle-viewmodel:compileReleaseKotlinAndroid
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/src/androidMain/kotlin/androidx/lifecycle/ViewModelProvider.android.kt:89:12 Annotation `@MainThread` is missing on actual declaration.
All annotations from expect `androidx.lifecycle.ViewModelProvider.get` must be present with the same arguments on actual `androidx.lifecycle.ViewModelProvider.get`, otherwise they might behave incorrectly.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/src/androidMain/kotlin/androidx/lifecycle/ViewModelProvider.android.kt:106:12 Annotation `@MainThread` is missing on actual declaration.
All annotations from expect `androidx.lifecycle.ViewModelProvider.get` must be present with the same arguments on actual `androidx.lifecycle.ViewModelProvider.get`, otherwise they might behave incorrectly.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/src/commonMain/kotlin/androidx/lifecycle/viewmodel/internal/SynchronizedObject.kt:36:16 Leaked in-place lambda 'crossinline action: () -> T'.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/src/commonMain/kotlin/androidx/lifecycle/viewmodel/internal/SynchronizedObject.kt:36:16 Wrong invocation kind 'EXACTLY_ONCE' for 'crossinline action: () -> T' specified, the actual invocation kind is 'AT_MOST_ONCE'.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/src/commonMain/kotlin/androidx/lifecycle/viewmodel/internal/SynchronizedObject.kt:37:35 Leaked in-place lambda 'crossinline action: () -> T'.

Comments

mg...@google.com <mg...@google.com> Feb 20, 2025 06:26PM

Accepted by mg...@google.com.

mg...@google.com <mg...@google.com> #2Feb 27, 2025 03:25PM

Annotation @RestrictTo(value = [Scope.LIBRARY_GROUP] type=kotlin.Array<out androidx.annotation.RestrictTo.Scope> varargElementType=androidx.annotation.RestrictTo.Scope) is missing on actual declaration.

Since the actual declaration is a typealias, we can't resolve the warnings in lifecycle.common until b/320544977 is fixed.

Message last modified on Feb 27, 2025 04:29PM

ap...@google.com <ap...@google.com> #3Feb 27, 2025 05:06PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3514032

Fix KotlinTarget 2 in savedstate

Expand for full commit details

Fix KotlinTarget 2 in `savedstate` 
 
Bug: 397736115 
Test: N/A 
Change-Id: I475a442180fa274e4ad36955757d1c4c66867e8d

Files:

M savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/internal/SynchronizedObject.kt

Hash: 5a0d860a6eb7e445ad93b865f353044e8babb79b
Date: Thu Feb 27 16:20:30 2025

ap...@google.com <ap...@google.com> #4Feb 27, 2025 05:14PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3514031

Fix KotlinTarget 2 in lifecycle.runtime

Expand for full commit details

Fix KotlinTarget 2 in `lifecycle.runtime` 
 
Bug: 397736115 
Test: N/A 
Change-Id: I181b6b50b07c7d617e1afa202961e0ea6e033566

Files:

M lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt

Hash: 15b24bb3eff6b157a8e615a97b9e968840f0cde0
Date: Thu Feb 27 16:12:31 2025

ap...@google.com <ap...@google.com> #5Feb 27, 2025 08:25PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3514130

Fix KotlinTarget 2 in lifecycle.viewmodel

Expand for full commit details

Fix KotlinTarget 2 in `lifecycle.viewmodel` 
 
RelNote: "Add `@MainThread` annotation to `ViewModelProvider.get` in all supported KMP platforms." 
Bug: 397736115 
Test: N/A 
Change-Id: I7e8ddcd37a714fe511719aea74650f48acb85847

Files:

M lifecycle/lifecycle-viewmodel/api/current.txt
M lifecycle/lifecycle-viewmodel/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel/src/androidMain/kotlin/androidx/lifecycle/ViewModelProvider.android.kt
M lifecycle/lifecycle-viewmodel/src/commonMain/kotlin/androidx/lifecycle/viewmodel/internal/SynchronizedObject.kt

Hash: e9f4c91901111325c8371006a393a6b2a4f0a23f
Date: Thu Feb 27 16:19:06 2025

au...@google.com <au...@google.com> #6Feb 28, 2025 12:54AM

Can you explain further what the issue is in #2?

mg...@google.com <mg...@google.com> #7Mar 5, 2025 12:09AM

comment#3:

We have an expect class AtomicReference annotated with RestrictTo in common.

There's an actual class AtomicReference with RestrictTo in nonJvm.

However, in android, we have an actual typealias Atomic, which results in the warning:

Annotation RestrictTo(...) is missing on actual declaration.

The issue is that RestrictTo needs to be in the common source (since the type is restricted), but RestrictTo currently cannot target typealias (see b/320544977). A likely solution is to add AnnotationTarget.TYPEALIAS to RestrictTo and ensure tooling supports the new target.

That said, I'm not sure what RestrictTo would mean when applied to a typealias, since the aliased type itself may not be restricted.

As far as I know, this warning cannot be suppressed with @Suppress("...")

Message last modified on Mar 5, 2025 12:11AM

om...@google.com <om...@google.com> #8Mar 6, 2025 03:22PM

Why dont we just switch from a typealias to an actual class implementation that just delegates to the Java one. See aosp/3527694

ap...@google.com <ap...@google.com> #9Mar 7, 2025 03:02PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Omar Ismail <omarismail@google.com>
Link: https://android-review.googlesource.com/3527694

switch from a typealias to an actual class impl that delegates to the Java class

Expand for full commit details

switch from a typealias to an actual class impl that delegates to the Java class 
 
This removes the error we see in b/397736115 
 
BUG: 397736115 
TESTED: Ran ./gradlew  :lifecycle:lifecycle-common:compileKotlinJvm and no warnings appeared 
Change-Id: I6abbf31029af2e92360dbc3ce0da34cccac3bbc5

Files:

M lifecycle/integration-tests/kotlintestapp/lint-baseline.xml
M lifecycle/lifecycle-common/src/jvmMain/kotlin/androidx/lifecycle/Lifecycle.jvm.kt

Hash: b3d343bfbea66190f4d989690c9832fee9a7cbb0
Date: Thu Mar 06 15:19:13 2025

Issue 397736115

Description

Issue summary

Comments

mg...@google.com <mg...@google.com> Feb 20, 2025 06:26PM

mg...@google.com <mg...@google.com> #2Feb 27, 2025 03:25PM

ap...@google.com <ap...@google.com> #3Feb 27, 2025 05:06PM

ap...@google.com <ap...@google.com> #4Feb 27, 2025 05:14PM

ap...@google.com <ap...@google.com> #5Feb 27, 2025 08:25PM

au...@google.com <au...@google.com> #6Feb 28, 2025 12:54AM

mg...@google.com <mg...@google.com> #7Mar 5, 2025 12:09AM

om...@google.com <om...@google.com> #8Mar 6, 2025 03:22PM

ap...@google.com <ap...@google.com> #9Mar 7, 2025 03:02PM

Add comment

Issue metadata