Fix warnings shown when targeting Kotlin 2.0 [397736115]

In Progress

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Feb 19, 2025 09:16PM

AndroidX is preparing to move to target Kotlin language version 2.0. In order to make this transition smooth, please help fix these warnings ahead of this switch. You can reproduce it with the following command:

./gradlew -p lifecycle build -Pandroidx.forceKotlin20Target=true

> Task :lifecycle:lifecycle-common:compileKotlinJvm
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-common/src/jvmMain/kotlin/androidx/lifecycle/Lifecycle.jvm.kt:23:11 This code uses error suppression for 'ACTUAL_WITHOUT_EXPECT'. While it might compile and work, the compiler behavior is UNSPECIFIED and WON'T BE PRESERVED. Please report your use case to the Kotlin issue tracker instead: https://kotl.in/issue
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-common/src/jvmMain/kotlin/androidx/lifecycle/Lifecycle.jvm.kt:24:8 Annotation `@RestrictTo(value = [Scope.LIBRARY_GROUP] type=kotlin.Array<out androidx.annotation.RestrictTo.Scope> varargElementType=androidx.annotation.RestrictTo.Scope)` is missing on actual declaration.
All annotations from expect `androidx.lifecycle.AtomicReference` must be present with the same arguments on actual `java.util.concurrent.atomic.AtomicReference`, otherwise they might behave incorrectly.

> Task :lifecycle:lifecycle-runtime:compileReleaseKotlinAndroid
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:43:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:49:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:55:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:61:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:66:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:71:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.

> Task :lifecycle:lifecycle-viewmodel:compileReleaseKotlinAndroid
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/src/androidMain/kotlin/androidx/lifecycle/ViewModelProvider.android.kt:89:12 Annotation `@MainThread` is missing on actual declaration.
All annotations from expect `androidx.lifecycle.ViewModelProvider.get` must be present with the same arguments on actual `androidx.lifecycle.ViewModelProvider.get`, otherwise they might behave incorrectly.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/src/androidMain/kotlin/androidx/lifecycle/ViewModelProvider.android.kt:106:12 Annotation `@MainThread` is missing on actual declaration.
All annotations from expect `androidx.lifecycle.ViewModelProvider.get` must be present with the same arguments on actual `androidx.lifecycle.ViewModelProvider.get`, otherwise they might behave incorrectly.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/src/commonMain/kotlin/androidx/lifecycle/viewmodel/internal/SynchronizedObject.kt:36:16 Leaked in-place lambda 'crossinline action: () -> T'.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/src/commonMain/kotlin/androidx/lifecycle/viewmodel/internal/SynchronizedObject.kt:36:16 Wrong invocation kind 'EXACTLY_ONCE' for 'crossinline action: () -> T' specified, the actual invocation kind is 'AT_MOST_ONCE'.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/src/commonMain/kotlin/androidx/lifecycle/viewmodel/internal/SynchronizedObject.kt:37:35 Leaked in-place lambda 'crossinline action: () -> T'.

Comments

mg...@google.com <mg...@google.com> Feb 20, 2025 06:26PM

Accepted by mg...@google.com.

mg...@google.com <mg...@google.com> #2Feb 27, 2025 03:25PM

Would you like to move it to android.hardware.biometrics? It looks like the problem is deeper than androidx.

Message last modified on Feb 27, 2025 04:29PM

ap...@google.com <ap...@google.com> #3Feb 27, 2025 05:06PM

Native Android 10 BiometricPrompt has exactly the same issue. If fixing this in the platform is impractical, maybe AndroidX Biometrics library can implement some workaround?

ap...@google.com <ap...@google.com> #4Feb 27, 2025 05:14PM

exxbrain@ can you attach a bugreport?

ap...@google.com <ap...@google.com> #5Feb 27, 2025 08:25PM

I've created two sample projects (see attachment): one with android.hardware.biometrics (TestBiometricQ), other with androidx.biometric:biometric:1.0.0 (TestBiometricX).
They both have the same issue with setDeviceCredentialAllowed(true) (see #1).

Bug reports:

https://drive.google.com/file/d/1fx4EyHdfJ1koRIt2KZ1emQeRdSDnNOkG/view?usp=drive_web (biometric_q_report.zip)

https://drive.google.com/file/d/1PASxQhxXvLp62t91mYis28QhGqvHBfD5/view?usp=drive_web (biometric_x_report.zip)

On attached screenshots you can see "onAuthenticationError" toast alongside device pattern UI.

au...@google.com <au...@google.com> #6Feb 28, 2025 12:54AM

Some clarifications:
1. The issue applies to any non-biometric unlock method (pattern, PIN, or password), if fingerprint is configured too. Not sure about face recognition.
2. "onAuthenticationSucceeded" is not called after providing correct pattern/PIN/password.

mg...@google.com <mg...@google.com> #7Mar 5, 2025 12:09AM

There is no bug report - just inconsistent behavior. From my point of view Authentication shouldn’t be cancelled in the moment when user chooses “Use pin” in a biometric prompt.

Message last modified on Mar 5, 2025 12:11AM

om...@google.com <om...@google.com> #8Mar 6, 2025 03:22PM

Well, I would still call it a bug. Documentation for setDeviceCredentialAllowed() method says that user will be "given the option to authenticate with their device PIN, pattern, or password" - and this does not work: the user can enter PIN/password/pattern, but cannot authenticate, because the app always gets onAuthenticationError callback.

ap...@google.com <ap...@google.com> #9Mar 7, 2025 03:02PM

Absolutely agree.