Fix warnings shown when targeting Kotlin 2.0 [397736115]

In Progress

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Feb 19, 2025 09:16PM

AndroidX is preparing to move to target Kotlin language version 2.0. In order to make this transition smooth, please help fix these warnings ahead of this switch. You can reproduce it with the following command:

./gradlew -p lifecycle build -Pandroidx.forceKotlin20Target=true

> Task :lifecycle:lifecycle-common:compileKotlinJvm
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-common/src/jvmMain/kotlin/androidx/lifecycle/Lifecycle.jvm.kt:23:11 This code uses error suppression for 'ACTUAL_WITHOUT_EXPECT'. While it might compile and work, the compiler behavior is UNSPECIFIED and WON'T BE PRESERVED. Please report your use case to the Kotlin issue tracker instead: https://kotl.in/issue
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-common/src/jvmMain/kotlin/androidx/lifecycle/Lifecycle.jvm.kt:24:8 Annotation `@RestrictTo(value = [Scope.LIBRARY_GROUP] type=kotlin.Array<out androidx.annotation.RestrictTo.Scope> varargElementType=androidx.annotation.RestrictTo.Scope)` is missing on actual declaration.
All annotations from expect `androidx.lifecycle.AtomicReference` must be present with the same arguments on actual `java.util.concurrent.atomic.AtomicReference`, otherwise they might behave incorrectly.

> Task :lifecycle:lifecycle-runtime:compileReleaseKotlinAndroid
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:43:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:49:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:55:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:61:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:66:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:71:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.

> Task :lifecycle:lifecycle-viewmodel:compileReleaseKotlinAndroid
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/src/androidMain/kotlin/androidx/lifecycle/ViewModelProvider.android.kt:89:12 Annotation `@MainThread` is missing on actual declaration.
All annotations from expect `androidx.lifecycle.ViewModelProvider.get` must be present with the same arguments on actual `androidx.lifecycle.ViewModelProvider.get`, otherwise they might behave incorrectly.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/src/androidMain/kotlin/androidx/lifecycle/ViewModelProvider.android.kt:106:12 Annotation `@MainThread` is missing on actual declaration.
All annotations from expect `androidx.lifecycle.ViewModelProvider.get` must be present with the same arguments on actual `androidx.lifecycle.ViewModelProvider.get`, otherwise they might behave incorrectly.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/src/commonMain/kotlin/androidx/lifecycle/viewmodel/internal/SynchronizedObject.kt:36:16 Leaked in-place lambda 'crossinline action: () -> T'.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/src/commonMain/kotlin/androidx/lifecycle/viewmodel/internal/SynchronizedObject.kt:36:16 Wrong invocation kind 'EXACTLY_ONCE' for 'crossinline action: () -> T' specified, the actual invocation kind is 'AT_MOST_ONCE'.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/src/commonMain/kotlin/androidx/lifecycle/viewmodel/internal/SynchronizedObject.kt:37:35 Leaked in-place lambda 'crossinline action: () -> T'.

Comments

mg...@google.com <mg...@google.com> Feb 20, 2025 06:26PM

Accepted by mg...@google.com.

mg...@google.com <mg...@google.com> #2Feb 27, 2025 03:25PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c9e90d1e5671b7e6a8880aecbe32bb13f4b37560
Author: Siyamed Sinir <siyamed@google.com>
Date: Thu Oct 31 11:30:30 2019

Remove font related TODOs

- Ability to read font weight from the font

b/143700963

- Support for font collections

b/122476423

- Support for variable fonts

b/143703328

- support for multiple font family

b/127483182

- BaselineShift.lerp

b/143699225

Test: ./gradlew ui:ui-text:test
Test: ./gradlew ui:ui-text:connectedAndroidTest

Bug: 141645236
Bug: 143700963
Bug: 122476423
Bug: 143703328
Bug: 127483182
Bug: 143699225
Change-Id: I4ff001fd1e0fff4cd3aa0c64efae929057e8d5de

M ui/ui-text/api/0.1.0-dev03.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev03.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev03.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/main/java/androidx/ui/text/font/Font.kt
M ui/ui-text/src/main/java/androidx/ui/text/platform/AndroidParagraphHelper.kt
M ui/ui-text/src/main/java/androidx/ui/text/platform/TypefaceAdapter.kt
M ui/ui-text/src/main/java/androidx/ui/text/style/BaselineShift.kt
M ui/ui-text/src/test/java/androidx/ui/text/font/FontFamilyTest.kt
M ui/ui-text/src/test/java/androidx/ui/text/font/FontTest.kt

https://android-review.googlesource.com/1156568

https://goto.google.com/android-sha1/c9e90d1e5671b7e6a8880aecbe32bb13f4b37560

Message last modified on Feb 27, 2025 04:29PM

ap...@google.com <ap...@google.com> #3Feb 27, 2025 05:06PM

from dupped ticket

"CSS has font-variation-settings attribute
Also check if there are commonly used settings that we can add to the API.

Note:
Tracking ticket based on

https://docs.google.com/document/d/1MzK83egP-Jghc2ZW8IcIcJkud_vMM7jgDClCv4CkO_c/edit#bookmark=id.nyju92hr2ygw"

ap...@google.com <ap...@google.com> #4Feb 27, 2025 05:14PM

bulk comment, fyi: we have added icebox to all the tickets because it was suggested by blintz in order to prevent auto-close tickets. we want to keep our Compose tickets to remain opened.

see

b/123001228#comment6

ap...@google.com <ap...@google.com> #5Feb 27, 2025 08:25PM

discussion from aosp/1672420

variable font settings can be included during font creation (for Font() functions.)

there are two parts of the story:

This font is weight X
I want to render the text in weight Y (regardless of the font weight)

au...@google.com <au...@google.com> #6Feb 28, 2025 12:54AM

important for Material.

mg...@google.com <mg...@google.com> #7Mar 5, 2025 12:09AM

Project: platform/frameworks/support
Branch: androidx-main

commit 8766bf0012613dfa48fdc969d03bd64217a4460c
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 13:17:37 2022

Add font variations to Android font constructors

On O+ this will allow configuring font variation settings.

Bug:

b/143703328

Test: ./gradle :compose:ui:ui-text:cAT
Relnote: "Font constructors now accept a list of FontVariation.Setting for configuring variable fonts on O+ devices."
Change-Id: I11a9d69d73429e9a875fd7096a00981a0cbd8a47

M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/testutils/AsyncTestFonts.kt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/AndroidFontTest.kt
A compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidLoadableFonts.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
A testutils/testutils-fonts/src/androidMain/assets/subdirectory/asset_variable_font.ttf
A testutils/testutils-fonts/src/font_ttx/variable_font.ttx
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidFont.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/FontFamilyResolverImplTest.kt
A compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/AndroidVariableFontTest.kt
A testutils/testutils-fonts/src/commonMain/resources/font/variable_font.ttf

https://android-review.googlesource.com/2162835

Message last modified on Mar 5, 2025 12:11AM

om...@google.com <om...@google.com> #8Mar 6, 2025 03:22PM

Project: platform/frameworks/support
Branch: androidx-main

commit ef1fff276087529659dc11ae29b219fcc2e5c790
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 13:14:04 2022

FontVariation definition

Bug:

b/143703328

Relnote: "Add FontVariation API for defining and using variable fonts."
Test: ./gradlew :compose:ui:ui-text:test
Change-Id: I3c40c6c8b4cee02cacda9482955ec16587ae62a5

M compose/ui/ui-text/lint-baseline.xml
A compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/FontVariation.kt
A compose/ui/ui-text/src/test/java/androidx/compose/ui/text/font/FontVariationTest.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/2161039

ap...@google.com <ap...@google.com> #9Mar 7, 2025 03:02PM

Project: platform/frameworks/support
Branch: androidx-main

commit 80e8419233f7f46dbca44236c11df5a3692030c2
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Aug 03 11:01:22 2022

Add VariableFonts to ResourceFont

Add support on Android API26+

Test: New demo
Test: ./gradlew :com:ui:ui-text:cAT && ./gradlew :com:ui;ui-text:test

Relnote: "Resource Fonts now support setting font variation settings (API 26+)."
Bug:

b/143703328

Change-Id: I900dde1f539e580a66db9c14d389ada691377c91

M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidFontLoader.android.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/VariableFontsDemo.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/Font.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
A compose/ui/ui-text/src/test/java/androidx/compose/ui/text/font/ResourceFontVariationSettingsTest.kt

https://android-review.googlesource.com/2172940

Issue 397736115

Description

Issue summary

Comments

mg...@google.com <mg...@google.com> Feb 20, 2025 06:26PM

mg...@google.com <mg...@google.com> #2Feb 27, 2025 03:25PM

ap...@google.com <ap...@google.com> #3Feb 27, 2025 05:06PM

ap...@google.com <ap...@google.com> #4Feb 27, 2025 05:14PM

ap...@google.com <ap...@google.com> #5Feb 27, 2025 08:25PM

au...@google.com <au...@google.com> #6Feb 28, 2025 12:54AM

mg...@google.com <mg...@google.com> #7Mar 5, 2025 12:09AM

om...@google.com <om...@google.com> #8Mar 6, 2025 03:22PM

ap...@google.com <ap...@google.com> #9Mar 7, 2025 03:02PM

Add comment

Issue metadata