Fix warnings shown when targeting Kotlin 2.0 [397736115]

In Progress

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Feb 19, 2025 09:16PM

AndroidX is preparing to move to target Kotlin language version 2.0. In order to make this transition smooth, please help fix these warnings ahead of this switch. You can reproduce it with the following command:

./gradlew -p lifecycle build -Pandroidx.forceKotlin20Target=true

> Task :lifecycle:lifecycle-common:compileKotlinJvm
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-common/src/jvmMain/kotlin/androidx/lifecycle/Lifecycle.jvm.kt:23:11 This code uses error suppression for 'ACTUAL_WITHOUT_EXPECT'. While it might compile and work, the compiler behavior is UNSPECIFIED and WON'T BE PRESERVED. Please report your use case to the Kotlin issue tracker instead: https://kotl.in/issue
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-common/src/jvmMain/kotlin/androidx/lifecycle/Lifecycle.jvm.kt:24:8 Annotation `@RestrictTo(value = [Scope.LIBRARY_GROUP] type=kotlin.Array<out androidx.annotation.RestrictTo.Scope> varargElementType=androidx.annotation.RestrictTo.Scope)` is missing on actual declaration.
All annotations from expect `androidx.lifecycle.AtomicReference` must be present with the same arguments on actual `java.util.concurrent.atomic.AtomicReference`, otherwise they might behave incorrectly.

> Task :lifecycle:lifecycle-runtime:compileReleaseKotlinAndroid
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:43:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:49:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:55:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:61:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:66:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-runtime/src/androidMain/kotlin/androidx/lifecycle/ReportFragment.android.kt:71:18 This declaration overrides a deprecated member but is not marked as deprecated itself. Please add the '@Deprecated' annotation or suppress the diagnostic.

> Task :lifecycle:lifecycle-viewmodel:compileReleaseKotlinAndroid
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/src/androidMain/kotlin/androidx/lifecycle/ViewModelProvider.android.kt:89:12 Annotation `@MainThread` is missing on actual declaration.
All annotations from expect `androidx.lifecycle.ViewModelProvider.get` must be present with the same arguments on actual `androidx.lifecycle.ViewModelProvider.get`, otherwise they might behave incorrectly.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/src/androidMain/kotlin/androidx/lifecycle/ViewModelProvider.android.kt:106:12 Annotation `@MainThread` is missing on actual declaration.
All annotations from expect `androidx.lifecycle.ViewModelProvider.get` must be present with the same arguments on actual `androidx.lifecycle.ViewModelProvider.get`, otherwise they might behave incorrectly.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/src/commonMain/kotlin/androidx/lifecycle/viewmodel/internal/SynchronizedObject.kt:36:16 Leaked in-place lambda 'crossinline action: () -> T'.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/src/commonMain/kotlin/androidx/lifecycle/viewmodel/internal/SynchronizedObject.kt:36:16 Wrong invocation kind 'EXACTLY_ONCE' for 'crossinline action: () -> T' specified, the actual invocation kind is 'AT_MOST_ONCE'.
w: file:///usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/lifecycle/lifecycle-viewmodel/src/commonMain/kotlin/androidx/lifecycle/viewmodel/internal/SynchronizedObject.kt:37:35 Leaked in-place lambda 'crossinline action: () -> T'.

Comments

mg...@google.com <mg...@google.com> Feb 20, 2025 06:26PM

Accepted by mg...@google.com.

mg...@google.com <mg...@google.com> #2Feb 27, 2025 03:25PM

As a workaround using reflection

try {
    Class
        .forName("androidx.compose.material3.TabRowKt")
        .getDeclaredField("ScrollableTabRowMinimumTabWidth").apply {
            isAccessible = true
        }.set(this, 0f)
} catch (e: Exception) {
    e.printStackTrace()
}

Message last modified on Feb 27, 2025 04:29PM

ap...@google.com <ap...@google.com> #3Feb 27, 2025 05:06PM

this is still an issue on the latest compose stable version 1.5.4

ap...@google.com <ap...@google.com> #4Feb 27, 2025 05:14PM

can I help resolve this issue?

ap...@google.com <ap...@google.com> #5Feb 27, 2025 08:25PM

Any progress on this?

au...@google.com <au...@google.com> #6Feb 28, 2025 12:54AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jose Figueroa <serniebanders@google.com>
Link: https://android-review.googlesource.com/3501214

[Tabs] Expose minimum scrollable tab width and remove experimental tags for Primary/Secondary variants

Expand for full commit details

[Tabs] Expose minimum scrollable tab width and remove experimental tags for Primary/Secondary variants 
 
Bug: 226665301 
RelNote: "Scrollable tab row's minimum tab width is now a parameter. Primary and Secondary tab row variants are no longer experimental." 
Test: Update unit test tolerance. Manual testing. 
Change-Id: If6f15c267353bf23a8faaa486bd52ed2a61dd29b

Files:

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/bcv/native/current.txt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/TabTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TabRow.kt

Hash: c1ca7e200b4e3c0ae14d4c59ac954ed1a0fd03f5
Date: Wed Feb 19 11:48:55 2025

mg...@google.com <mg...@google.com> #7Mar 5, 2025 12:09AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.4.0-alpha10
androidx.compose.material3:material3-android:1.4.0-alpha10
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha10
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha10

Message last modified on Mar 5, 2025 12:11AM

om...@google.com <om...@google.com> #8Mar 6, 2025 03:22PM

Why dont we just switch from a typealias to an actual class implementation that just delegates to the Java one. See aosp/3527694

ap...@google.com <ap...@google.com> #9Mar 7, 2025 03:02PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Omar Ismail <omarismail@google.com>
Link: https://android-review.googlesource.com/3527694

switch from a typealias to an actual class impl that delegates to the Java class