Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Julia McClellan <
Link:
Enable UnexpectedTestSizeAnnotation lint check on tests
Expand for full commit details
Enable UnexpectedTestSizeAnnotation lint check on tests
This lint check is supposed to be run on tests, but wasn't configured correctly.
Addresses existing violations by removing test size annotations from host tests. Baselines one usage in a window test which causes a platform-dev merge conflict to remove, I'll remove that in a followup.
Bug: 398893818
Test: ./gradlew lint
Change-Id: Idc9a41b79f614f9ad778e5440bd521350bda2d89
Files:
- M
buildSrc/lint.xml - M
camera/camera-camera2-pipe-integration/src/test/java/androidx/camera/camera2/pipe/integration/adapter/FocusMeteringControlTest.kt - M
camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/FocusMeteringControlTest.kt - M
camera/camera-core/src/test/java/androidx/camera/core/internal/compat/workaround/CaptureFailedRetryEnablerTest.kt - M
compose/foundation/foundation/src/androidUnitTest/kotlin/androidx/compose/foundation/text/TextAutoSizeTest.kt - M
compose/foundation/foundation/src/androidUnitTest/kotlin/androidx/compose/foundation/text/selection/SelectableInfoTest.kt - M
compose/foundation/foundation/src/androidUnitTest/kotlin/androidx/compose/foundation/text/selection/SelectionAdjustmentTest.kt - M
compose/foundation/foundation/src/androidUnitTest/kotlin/androidx/compose/foundation/text/selection/SelectionLayoutStartSlot2DTest.kt - M
compose/foundation/foundation/src/androidUnitTest/kotlin/androidx/compose/foundation/text/selection/SelectionLayoutTest.kt - M
compose/ui/ui-test/src/androidUnitTest/kotlin/androidx/compose/ui/test/inputdispatcher/AdvanceEventTimeTest.kt - M
core/core/src/test/java/androidx/core/content/IntentSanitizerTest.java - M
core/core/src/test/java/androidx/core/content/UriMatcherCompatTest.java - M
core/core/src/test/java/androidx/core/math/MathUtilsTest.kt - M
core/core/src/test/java/androidx/core/view/accessibility/AccessibilityNodeInfoCompatTest.java - M
input/input-motionprediction/src/test/kotlin/androidx/input/motionprediction/kalman/MultiPointerPredictorTest.kt - M
input/input-motionprediction/src/test/kotlin/androidx/input/motionprediction/kalman/SinglePointerPredictorTest.kt - M
navigation/navigation-testing/src/test/java/androidx/navigation/testing/TestSavedStateHandleFactory.kt - M
pdf/pdf-viewer/src/test/java/androidx/pdf/aidl/LinkRectsTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/aidl/MatchRectsTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/aidl/SelectionBoundaryTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/data/ContentOpenableTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/data/RangeTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/find/FindInFileViewTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/util/AnnotationUtilsTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/util/BundleUtilsTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/util/CollectUtilsTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/util/CycleRangeTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/util/EnumKeyGeneratorTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/util/ExposedArrayTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/util/FutureValuesTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/util/GestureTrackerTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/util/IntentsTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/util/QuickScaleBypassDeciderTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/util/SettableFutureValueTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/util/SystemGestureExclusionHelperTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/util/TileBoardTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/util/UrisTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/util/ZoomUtilsTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/viewer/LoadingViewTest.kt - M
pdf/pdf-viewer/src/test/java/androidx/pdf/viewer/PageMosaicViewTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/viewer/PageRangeHandlerTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/viewer/PageSelectionValueObserverTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/viewer/PageViewFactoryTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/viewer/PaginatedViewTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/viewer/PaginationModelTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/viewer/SearchModelTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/viewer/SearchQueryObserverTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/viewer/SelectedMatchTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/viewer/SelectedMatchValueObserverTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/viewer/SingleTapHandlerTest.kt - M
pdf/pdf-viewer/src/test/java/androidx/pdf/viewer/ZoomScrollValueObserverTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/widget/MosaicViewTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/widget/PageIndicatorTest.java - M
pdf/pdf-viewer/src/test/java/androidx/pdf/widget/ZoomViewTest.java - M
pdf/pdf-viewer/src/test/kotlin/androidx/pdf/metrics/GestureRecordingProcessorTest.kt - M
pdf/pdf-viewer/src/test/kotlin/androidx/pdf/search/CyclicSparseArrayIteratorTest.kt - M
pdf/pdf-viewer/src/test/kotlin/androidx/pdf/view/GestureTrackerTest.kt - M
pdf/pdf-viewer/src/test/kotlin/androidx/pdf/view/PageLayoutManagerTest.kt - M
pdf/pdf-viewer/src/test/kotlin/androidx/pdf/view/PaginationModelTest.kt - M
pdf/pdf-viewer/src/test/kotlin/androidx/pdf/view/SelectionStateManagerTest.kt - M
pdf/pdf-viewer/src/test/kotlin/androidx/pdf/viewmodel/PdfViewerViewModelTest.kt - M
wear/protolayout/protolayout-material-core/src/test/java/androidx/wear/protolayout/materialcore/fontscaling/FontScaleConverterFactoryTest.kt - M
wear/wear/src/test/java/androidx/wear/ambient/AmbientDelegateTest.java - M
wear/wear/src/test/java/androidx/wear/ambient/AmbientModeResumeTest.java - M
wear/wear/src/test/java/androidx/wear/ambient/AmbientModeSupportResumeTest.java - M
wear/wear/src/test/java/androidx/wear/ambient/AmbientModeSupportTest.java - M
wear/wear/src/test/java/androidx/wear/ambient/AmbientModeTest.java - A
window/extensions/extensions/lint-baseline.xml - M
window/extensions/extensions/src/test/java/androidx/window/extensions/embedding/AnimationBackgroundTest.java - M
window/extensions/extensions/src/test/java/androidx/window/extensions/embedding/SplitAttributesTest.java
Hash: 80621f2a658b49529a0b5040f45bb22ca4eec7d3
Date: Mon Feb 24 16:14:18 2025
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Julia McClellan <
Link:
Enable LintImplTrimIndent lint check on tests
Expand for full commit details
Enable LintImplTrimIndent lint check on tests
This check is meant to be run on test sources, but wasn't configured correctly.
Addresses existing violations by removing `trimIndent` calls from lint tests where they weren't needed, replacing with `indented`. Using `indented` enables syntax highlighting in the test code samples.
Bug: 398893818
Test: ./gradlew lint
Change-Id: I2ad0aac32d281605c5871114803cb1fa33ba45fb
Files:
- M
activity/activity-compose-lint/src/test/java/androidx/activity/compose/lint/LocalContextCastIssueDetectorTest.kt - M
buildSrc/lint.xml - M
compose/foundation/foundation-lint/src/test/java/androidx/compose/foundation/lint/BoxWithConstraintsDetectorTest.kt - M
compose/lint/internal-lint-checks/src/test/java/androidx/compose/lint/UnnecessaryLambdaCreationDetectorTest.kt - M
compose/runtime/runtime-lint/src/test/java/androidx/compose/runtime/lint/AutoboxingStateValuePropertyDetectorTest.kt - M
compose/runtime/runtime-lint/src/test/java/androidx/compose/runtime/lint/ComposableStateFlowValueDetectorTest.kt - M
constraintlayout/constraintlayout-compose-lint/src/test/java/androidx/constraintlayout/compose/lint/ConstraintLayoutDslDetectorTest.kt - M
fragment/fragment-lint/src/test/java/androidx/fragment/lint/UnsafeRepeatOnLifecycleDetectorTest.kt - M
lifecycle/lifecycle-runtime-compose-lint/src/test/java/androidx/lifecycle/runtime/compose/lint/ComposableLifecycleCurrentStateDetectorTest.kt - M
wear/protolayout/protolayout-lint/src/test/java/EdgeContentLayoutResponsiveDetectorTest.kt - M
wear/protolayout/protolayout-lint/src/test/java/PrimaryLayoutResponsiveDetectorTest.kt
Hash: d1f52902fb607b12f47eadce76c474d5eda6c979
Date: Mon Feb 24 16:22:25 2025
ju...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Julia McClellan <
Link:
Remove unexpected test size annotation from window host test
Expand for full commit details
Remove unexpected test size annotation from window host test
Followup to aosp/3507032 -- resolving the platform-dev merge conflict.
Bug: 398893818
Test: ./gradlew lint
Change-Id: I8eef2802e6fd787b282e13ccf107e9b68c996fc3
Merged-In: I8eef2802e6fd787b282e13ccf107e9b68c996fc3
Files:
- D
window/extensions/extensions/lint-baseline.xml - M
window/extensions/extensions/src/test/java/androidx/window/extensions/embedding/DividerAttributesTest.java
Hash: af557b09e17e311d8508e56f783f3a3330fa5f61
Date: Wed Feb 26 15:09:03 2025
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Julia McClellan <
Link:
Switch some annotations in tests to JSpecify
Expand for full commit details
Switch some annotations in tests to JSpecify
These projects were already switched over to JSpecify anntotations, but the JSpecify lint check wasn't set to run on test sources so some new usages of other nullness annotations were added.
Bug: 398893818
Test: ./gradlew lint, presubmit tests
Change-Id: If1a9fc0916934d4adca36870b24b40f52749c307
Files:
- M
coordinatorlayout/coordinatorlayout/src/androidTest/java/androidx/coordinatorlayout/widget/CoordinatorWithRecyclerViewActivity.java - M
core/core/src/androidTest/java/androidx/core/app/NotificationCompatTest.java - M
core/core/src/androidTest/java/androidx/core/widget/NestedScrollViewNestedScrollingA11yScrollTest.java - M
core/core/src/androidTest/java/androidx/core/widget/NestedScrollViewNestedScrollingFlingTest.java - M
datastore/datastore-rxjava2/src/androidTest/java/androidx/datastore/rxjava2/RxSharedPreferencesMigrationTest.java - M
datastore/datastore-rxjava3/src/androidTest/java/androidx/datastore/rxjava3/RxSharedPreferencesMigrationTest.java - M
transition/transition/src/androidTest/java/androidx/transition/MultipleRootsTest.java - M
wear/watchface/watchface-complications-rendering/src/test/java/androidx/wear/watchface/complications/rendering/ComplicationDrawableTest.java
Hash: f769d52a2d66e3795199838252f350a15d793625
Date: Mon Mar 03 17:13:00 2025
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Julia McClellan <
Link:
Remove MissingTestSizeAnnotation and UnsupportedTestRunner lint checks
Expand for full commit details
Remove MissingTestSizeAnnotation and UnsupportedTestRunner lint checks
The test infrastructure no longer relies on the test size annotations to set timeouts, and so runners which don't support timeouts are fine to use.
Bug: 398893818
Test: ./gradlew lint
Change-Id: Ib36374ba9963a79055d849914bf316187d20dd16
Files:
- M
buildSrc/lint.xml - M
lint-checks/src/main/java/androidx/build/lint/AndroidXIssueRegistry.kt - M
lint-checks/src/main/java/androidx/build/lint/TestSizeAnnotationEnforcer.kt - M
lint-checks/src/test/java/androidx/build/lint/TestSizeAnnotationEnforcerTest.kt
Hash: ea1cb8b43eee42c7633bde60c2813c5d32b6c08c
Date: Tue Mar 04 08:58:02 2025
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Julia McClellan <
Link:
Baseline compose lint issues on test sources
Expand for full commit details
Baseline compose lint issues on test sources
These lint checks were previously disabled for test sources even though the checks are defined with test scope.
Bug: 398893818
Test: `./gradlew lint` for topic
Change-Id: I096a65c8f46dffd453065744fd186c3083ef7ee5
Files:
- A
activity/activity-compose/lint-baseline.xml - A
camera/viewfinder/viewfinder-compose/lint-baseline.xml - M
compose/foundation/foundation/lint-baseline.xml - A
compose/material/material-ripple/benchmark/lint-baseline.xml - M
compose/material/material/lint-baseline.xml - A
compose/material3/adaptive/adaptive-layout/lint-baseline.xml - M
compose/material3/material3/lint-baseline.xml - M
compose/ui/ui-test/lint-baseline.xml - M
compose/ui/ui-tooling/lint-baseline.xml - M
compose/ui/ui/lint-baseline.xml - M
constraintlayout/constraintlayout-compose/lint-baseline.xml - A
hilt/hilt-navigation-compose/lint-baseline.xml - A
lifecycle/lifecycle-runtime-compose/lint-baseline.xml - M
navigation/navigation-compose/lint-baseline.xml - M
wear/compose/compose-foundation/lint-baseline.xml - M
wear/compose/compose-material/lint-baseline.xml - A
wear/compose/compose-material3/lint-baseline.xml
Hash: 11c92b82238f6895a8d44f030db14d2d1905e6a5
Date: Fri Feb 28 12:02:43 2025
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Julia McClellan <
Link:
Baseline instances of UnspecifiedRegisterReceiverFlag in tests
Expand for full commit details
Baseline instances of UnspecifiedRegisterReceiverFlag in tests
This lint check was previously disabled for test sources even though the check was defined with test scope.
Bug: 398893818
Test: `./gradlew lint` for topic
Change-Id: Ia5ad6c5fc2e35177f072d0a5ee243f49d4b48290
Files:
- M
core/core-remoteviews/lint-baseline.xml - M
glance/glance-appwidget/lint-baseline.xml - M
wear/watchface/watchface-complications-data-source/lint-baseline.xml - A
wear/wear-remote-interactions/lint-baseline.xml
Hash: f2baaa2e0eadd8eecddd5b250162c6a703c4ee83
Date: Thu Feb 27 20:44:44 2025
Description
Currently, we disable all lint checks on test sources except for a few. This means there are several checks which are designed to run on test sources which inadvertently are not. We should reenable these on test sources and fix or baseline all current issues.