AGP fails to shrink resources [399252030]

Assigned

Bug

Status Update

No update yet.

Description

li...@pinterest.com

created issue #1

Feb 26, 2025 09:43AM

Following the guidelines from https://developer.android.com/build/shrink-code?utm_source=android-studio#shrink-resources, I am trying to shrink the resources of my app but keep getting build errors.

Sharing my configuration:

AGP 8.3.2

Part of my app.gradle file and I have --debug --stacktrace added in the build command.

        release {
            minifyEnabled true
            shrinkResources true
            proguardFiles(
                    // Includes the default ProGuard rules files that are packaged with
                    // the Android Gradle plugin. To learn more, go to the section about
                    // R8 configuration files.
                    getDefaultProguardFile("proguard-android-optimize.txt"),

                    // Includes a local, custom Proguard rules file
                    "proguard-rules.pro"
            )
        }

The failure log is in the attachment.

android-trigger-internal-track-builds_build_395_android-building-construction-build-app-artifacts-bundle-or-apk.log

57 MB

View

Download

Comments

ch...@google.com <ch...@google.com> #2Feb 26, 2025 09:47AM

Disregard - after adding

enableUnitTestCoverage = false
enableAndroidTestCoverage false

Thinks started to work again.

But for what it is worth - the error message could have been more helpful.

ri...@google.com <ri...@google.com> #3Feb 26, 2025 10:08AM

Well the error message is that it tried to configure jacoco task and failed, so it works for you because you disabled the feature.

So the error message is indicative of a bigger problem. Oviously, 8.2 is pretty old for us, not sure you are interested in trying 8.8.

The easiest would be to have a project reproducing the issue, if that's possible, we'll look into it.

li...@pinterest.com <li...@pinterest.com> #4Feb 26, 2025 04:41PM

We tried bumping things up to 8.8 but that causes other problems that we need to resolve first. There was a long list of issues with name spaces and what not due to clashes across different 3rd part integrations that we have in the app.
Unfortunately we haven't had the resources to keep things up to date for a long time - and now every possible problem is just piling up...

I'll get back once we manage to upgrade to 8.8...

ri...@google.com <ri...@google.com> #5Feb 27, 2025 05:08AM

Reassigned to hu...@google.com.

so do you simply need minifyEnaled true in staging?

Hung might know how this is impacted, I see that we are getting the error from: https://cs.android.com/android-studio/platform/tools/base/+/mirror-goog-studio-main:build-system/gradle-core/src/main/java/com/android/build/api/component/impl/features/AndroidResourcesCreationConfigImpl.kt;l=93;drc=4b04cc73a3bcc9977a51455d649c750bcca6dc0c

Message last modified on Feb 27, 2025 06:10AM

li...@pinterest.com <li...@pinterest.com> #6Feb 27, 2025 03:56PM

Yeah, I have minifyEnaled turned off for some other flavors or build types, I wonder if there's a bug in my gradle description file and still digging into it.

hu...@google.com <hu...@google.com> #7Feb 27, 2025 04:49PM

This seems similar to Issue 379125947. Please inspect your build files or update to a newer AGP version (e.g., 8.9.0-rc02) and see if it helps.

li...@pinterest.com <li...@pinterest.com> #8Mar 5, 2025 06:27PM

Yeah, thanks, this is very similar to the Issue 379125947. In my case, I was using initWith release as well in staging, which is the build type that I am trying to compile. There is a minifyEnabled false in another build type benchmark that I was not building. It seems that minifyEnabled false in the benchmark build type caused the AGP to disable the minifyEnabled for the staging build type that I am building. Commenting out the minifyEnabled false in build type benchmark will let me compile the staging with minifyEnabled and shrinkResources all enabled.

 buildTypes {
        release {
                minifyEnabled true
                shrinkResources true
                proguardFiles(
                        getDefaultProguardFile("proguard-android-optimize.txt"),
                        "proguard-rules.pro"
                )
        }
        staging {
            initWith release
        }
        benchmark {
            initWith release
            // minifyEnabled false // <<<<<<<<<< This is the cause!!!!
        }
    }

hu...@google.com <hu...@google.com> #9Mar 5, 2025 06:37PM

Cool, so this might have been fixed as part of Issue 379125947. But if you still have this issue when using AGP 8.9+, please let us know.