Assigned
Status Update
Comments
rk...@google.com <rk...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
da...@zomato.com <da...@zomato.com> #3
rk...@google.com <rk...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
da...@zomato.com <da...@zomato.com> #5
I simulate a shake effect by rapidly and repeatedly moving any coordinate in virtual sensors. However, this does not work in the following cases:
- When the emulator is detached (removed from the running devices screen).
- After a cold boot, when it fails to read the last saved state.
The shake effect works consistently on a physical device, but the emulator exhibits inconsistent behavior. Sometimes, moving the sensor only a few times triggers the effect, while in the two cases mentioned above, it never works regardless of the input.
bo...@google.com <bo...@google.com> #6
" shake effect works consistently" what does this mean to your app?
does your app have some api call that tells it the phone is shaking?
does your app have some api call that tells it the phone is shaking?
bo...@google.com <bo...@google.com> #7
after a cold boot, if you wait a couple of minutes, does it work better in terms of "shaking"
Description
Please Read:https://developer.android.com/studio/report-bugs.html#emulator-bugs
Android Studio Version: Unknown
Emulator Version (Emulator--> Extended Controls--> Emulator Version): 35.3.12-12990079 Hypervisor Version: HVF 14.6.0
Android SDK Tools: invalid
Host Operating System: macOS 14.6
CPU Manufacturer: Apple CPU Virtualization is supported
Bare metal 64-bit CPU
RAM: 18432 MB
GPU:
Build Fingerprint: google/sdk_gphone64_arm64/emu64a:15/AE3A.240806.036/12592187:user/dev-keys
AVD Details: Name: Pixel_9_Pro_XL-District CPU/ABI: arm64 Path: /Users/dabas.deepanshu@zomato.com /.android/avd/Pixel_9_Pro_XL-District.avd
Target: google_apis_playstore [Google Play] (API level 35)
Skin: pixel_9_pro_xl
SD Card: 512M
AvdId: Pixel_9_Pro_XL-District
PlayStore.enabled: true
avd.ini.displayname: Pixel 9 Pro XL-District
avd.ini.encoding: UTF-8
disk.dataPartition.size: 6442450944
fastboot.chosenSnapshotFile:
fastboot.forceChosenSnapshotBoot: no
fastboot.forceColdBoot: no
fastboot.forceFastBoot: yes
hw.accelerometer: yes
hw.arc: false
hw.audioInput: yes
hw.battery: yes
hw.camera.back: virtualscene
hw.camera.front: emulated
hw.cpu.ncore: 4
hw.dPad: no
hw.device.hash2: MD5:df6942f9ab0ed0550ee98b91920f684e
hw.device.manufacturer: Google
hw.device.name: pixel_9_pro_xl
hw.gps: yes
hw.gpu.enabled: yes
hw.gpu.mode: auto
hw.initialOrientation: portrait
hw.keyboard: yes
hw.lcd.density: 480
hw.lcd.height: 2992
hw.lcd.width: 1344
hw.mainKeys: no
hw.ramSize: 15552
hw.sdCard: yes
hw.sensors.orientation: yes
hw.sensors.proximity: yes
hw.trackBall: no
image.sysdir.1: system-images/android-35/google_apis_playstore/arm64-v8a/
runtime.network.latency: none
runtime.network.speed: full
showDeviceFrame: yes
skin.dynamic: yes
tag.display: Google Play
tag.displaynames: Google Play
tag.id: google_apis_playstore
tag.ids: google_apis_playstore
vm.heapSize: 256
Steps to Reproduce Bug: Expected Behavior: Virtual sensor should produce shake effect
Observed Behavior: Sensor not working correctly