Status Update
Comments
mg...@google.com <mg...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <
Link:
Clean-up SavedState Serialization Reified functions
Expand for full commit details
Clean-up SavedState Serialization Reified functions
- Ensure their positioning and "call hierarchy" match each other.
- Make the KDocs consistent with KTX Serialization.
RelNote: "N/A"
Bug: b/399629301
Test: N/A
Change-Id: Icb6924b6f1929d4a3c00ded922c74e83fbe163f1
Files:
- M
lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/serialization/SavedStateHandleDelegates.kt
- M
savedstate/savedstate/api/current.txt
- M
savedstate/savedstate/api/restricted_current.txt
- M
savedstate/savedstate/bcv/native/current.txt
- M
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateDecoder.kt
- M
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateEncoder.kt
- M
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateRegistryOwnerDelegates.kt
Hash: 4f4e3cf53813a572ddd78967a279e9d5415ac615
Date: Mon Feb 24 13:54:34 2025
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <
Link:
Rename file SavedStateDelegates to SavedStateDelegate
Expand for full commit details
Rename file SavedState*Delegates to SavedState*Delegate
- File name now matches the class name `SavedState*Delegate`.
- That is consistent with `SavedStateDecoder.kt` and `SavedStateEncoder.kt` that are named after the `internal class` but expose only top-level functions (`SavedStateDecoderKt.method()` or `SavedStateEncoderKt.method()`).
RelNote: "Rename `SavedState*Delegates` to `SavedState*Delegate`."
Bug: 399629301
Test: N/A
Change-Id: I8589b62294646cb4529869228ea0185dac6087e6
Files:
- M
lifecycle/lifecycle-viewmodel-savedstate/api/current.txt
- M
lifecycle/lifecycle-viewmodel-savedstate/api/restricted_current.txt
- M
lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/serialization/SavedStateHandleDelegateTest.kt
- M
lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/serialization/SavedStateHandleDelegate.kt
- M
savedstate/savedstate/api/current.txt
- M
savedstate/savedstate/api/restricted_current.txt
- M
savedstate/savedstate/bcv/native/current.txt
- M
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateRegistryOwnerDelegate.kt
- M
savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/SavedStateRegistryOwnerDelegateTest.kt
Hash: d749bb5032edfe9547da480963da3c559b874023
Date: Fri Feb 28 14:18:38 2025
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <
Link:
Rename SavedStateConfig to SavedStateConfiguration
Expand for full commit details
Rename SavedStateConfig to SavedStateConfiguration
- Previously called `SavedStateConfig`, we have decide to match the name used by the other KotlinX Serialization format configs.
RelNote: "Rename `SavedStateConfig` to `SavedStateConfiguration`."
Bug: 399629301
Test: N/A
Change-Id: I043a5be95276ef617588559f5e3fcdb15905b793
Files:
- M
lifecycle/lifecycle-viewmodel-savedstate/api/current.txt
- M
lifecycle/lifecycle-viewmodel-savedstate/api/restricted_current.txt
- M
lifecycle/lifecycle-viewmodel-savedstate/bcv/native/current.txt
- M
lifecycle/lifecycle-viewmodel-savedstate/src/androidInstrumentedTest/kotlin/androidx/lifecycle/serialization/SavedStateHandleDelegatesTest.kt
- M
lifecycle/lifecycle-viewmodel-savedstate/src/commonMain/kotlin/androidx/lifecycle/serialization/SavedStateHandleDelegates.kt
- M
savedstate/savedstate-compose/src/androidInstrumentedTest/kotlin/androidx/savedstate/compose/serialization/serializers/MutableStateSerializerTest.android.kt
- M
savedstate/savedstate-samples/src/main/java/androidx/savedstate/SavedStateCodecSamples.kt
- M
savedstate/savedstate/api/current.txt
- M
savedstate/savedstate/api/restricted_current.txt
- M
savedstate/savedstate/bcv/native/current.txt
- M
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/ClassDiscriminatorMode.kt
- M
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateConfiguration.kt
- M
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateDecoder.kt
- M
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateEncoder.kt
- M
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/serialization/SavedStateRegistryOwnerDelegates.kt
- M
savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateCodecTest.kt
- M
savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/SavedStateCodecTestUtils.kt
- M
savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/MutableStateFlowSerializerTest.kt
- M
savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/SavedStateCodecClassDiscriminatorAllObjectsTest.kt
- M
savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/SavedStateCodecClassDiscriminatorPolymorphicTest.kt
- M
savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/SavedStateCodecEncodeDefaultsTest.kt
- M
savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/SavedStateRegistryOwnerDelegatesTest.kt
- M
savedstate/savedstate/src/commonTest/kotlin/androidx/savedstate/serialization/utils/SavedStateSerializationBaseTest.kt
Hash: db71d74194b21d66c591aebfa5b6ea0398f0cd51
Date: Mon Feb 24 14:33:00 2025
ap...@google.com <ap...@google.com> #5
Android API Change
This bug was referenced by a recent CL that changed the Android API surface area.
The
We'll wait until you mark this bug as 'Fixed' before starting our review, but please reach out if you'd like us to review it sooner.
Changes to lifecycle/lifecycle-viewmodel-savedstate/api/current.txt
- androidx.lifecycle.serialization
- androidx.lifecycle.serialization.SavedStateHandleDelegateKt
- androidx.lifecycle.serialization.SavedStateHandleDelegatesKt
Changes to savedstate/savedstate/api/current.txt
- androidx.savedstate.serialization
- androidx.savedstate.serialization.SavedStateRegistryOwnerDelegateKt
- androidx.savedstate.serialization.SavedStateRegistryOwnerDelegatesKt
[Gerrit:https://android-review.googlesource.com/3517474]
[API-Approvers:
[Branch:androidx-main]
[LIBRARY_API_REVIEW_TAG:lifecycle/lifecycle-viewmodel-savedstate/api/current.txt]
[LIBRARY_API_REVIEW_TAG:savedstate/savedstate/api/current.txt]
ap...@google.com <ap...@google.com> #6
Android API Change
This bug was referenced by a recent CL that changed the Android API surface area.
The
We'll wait until you mark this bug as 'Fixed' before starting our review, but please reach out if you'd like us to review it sooner.
Changes to lifecycle/lifecycle-viewmodel-savedstate/api/current.txt
- androidx.lifecycle.serialization
- androidx.lifecycle.serialization.SavedStateHandleDelegatesKt
Changes to savedstate/savedstate/api/current.txt
- androidx.savedstate.serialization
- androidx.savedstate.serialization.SavedStateConfig
- androidx.savedstate.serialization.SavedStateConfig.Builder
- androidx.savedstate.serialization.SavedStateConfig.Companion
- androidx.savedstate.serialization.SavedStateConfigKt
- androidx.savedstate.serialization.SavedStateConfiguration
- androidx.savedstate.serialization.SavedStateConfiguration.Builder
- androidx.savedstate.serialization.SavedStateConfiguration.Companion
- androidx.savedstate.serialization.SavedStateConfigurationKt
- androidx.savedstate.serialization.SavedStateDecoderKt
- androidx.savedstate.serialization.SavedStateEncoderKt
- androidx.savedstate.serialization.SavedStateRegistryOwnerDelegatesKt
[Gerrit:https://android-review.googlesource.com/3506352]
[API-Approvers:
[Branch:androidx-main]
[LIBRARY_API_REVIEW_TAG:lifecycle/lifecycle-viewmodel-savedstate/api/current.txt]
[LIBRARY_API_REVIEW_TAG:savedstate/savedstate/api/current.txt]
ap...@google.com <ap...@google.com> #7
Android API Change
This bug was referenced by a recent CL that changed the Android API surface area.
The
We'll wait until you mark this bug as 'Fixed' before starting our review, but please reach out if you'd like us to review it sooner.
Changes to savedstate/savedstate/api/current.txt
- androidx.savedstate.serialization
- androidx.savedstate.serialization.SavedStateDecoderKt
- androidx.savedstate.serialization.SavedStateEncoderKt
[Gerrit:https://android-review.googlesource.com/3506351]
[API-Approvers:
[Branch:androidx-main]
[LIBRARY_API_REVIEW_TAG:savedstate/savedstate/api/current.txt]
ap...@google.com <ap...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <
Link:
Simplify SavedStateReader.contentDeepToString
Expand for full commit details
Simplify `SavedStateReader.contentDeepToString`
- This change simplifies `SavedStateReader.contentDeepToString` by:
- Removing redundant delegation to `SavedState.contentDeepToString()` and `contentDeepToStringInternal()`.
- Eliminating one method call.
- Renaming `contentDeepToStringInternal` to `contentDeepToString` for clarity.
- The behavior of the method remains unchanged.
Test: SavedStateTest
Bug: b/399629301
Change-Id: Ia63e780faa89eaeddea3916649c20751ab411584
Files:
- M
savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateReader.android.kt
- M
savedstate/savedstate/src/nonAndroidMain/kotlin/androidx/savedstate/SavedStateReader.nonAndroid.kt
Hash: 841315abc416eabc22ac0ec69f53ff84524563f9
Date: Wed Mar 12 11:53:52 2025
ap...@google.com <ap...@google.com> #9
Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <
Link:
Improve SavedStateReader KDocs
Expand for full commit details
Improve SavedStateReader KDocs
- This change updates the SavedStateReader KDocs to:
- Accurately reflect exception behavior for `get*` methods following API changes (aosp/3500556, aosp/3523152, aosp/3523154)
- Clarify the definition of a "valid value" within SavedState.
- Enhance `getOrNull` method KDocs, including auto-boxing notes where relevant (aosp/3523151).
- Correct grammatical errors (e.g., "an Array", pluralization).
Test: N/A
Bug: b/399629301
Change-Id: I35734fa13e9e846df25aba0709e62e53943e2281
Files:
- M
savedstate/savedstate/src/androidMain/kotlin/androidx/savedstate/SavedStateReader.android.kt
- M
savedstate/savedstate/src/commonMain/kotlin/androidx/savedstate/SavedStateReader.kt
Hash: 4447f2ce4c6f0c84d79ab80fac4a417252254167
Date: Wed Mar 12 11:48:01 2025
Description