IssueTracker

Yoinking from triage

Thanks for taking the time to file this issue!

Would you be able to provide more details about the scene and this error? I tried the following code:

@Preview
@Composable
fun AutofillTextField3() {
    var password by remember { mutableStateOf("") }
    val focusRequester = remember { FocusRequester() }

    LaunchedEffect(Unit) {
        focusRequester.requestFocus()
    }

    Column(Modifier.fillMaxWidth()) {
        Text("Enter password")
        TextField(
            value = password,
            onValueChange = { password = it },
            modifier = Modifier
                .fillMaxWidth()
                .focusRequester(focusRequester)
                .semantics { contentType = ContentType.Password },
            label = { Text("password") },
            placeholder = { Text("type your password here") }
        )
    }
}

but upon the app starting, Autofill displayed the suggestion chips along the keyboard for me. Verified that this is the case for BTF as well.

Were you specifically using the Password content type? The only way I was able to reproduce this was if the same code above instead had ContentType.NewUsername set. In that case, you’re right—when the app starts, no suggestions are displayed. Only long-pressing and triggering autofill from the textbar menu displays the suggestions. I believe that is working as intended (as that is a field marked for new users and thus should not display previously saved data).

Are there any other details in the sample above that are missing?

Ah, I see what you're saying — thanks for the video and code! It seems like there’s two parts to this.

You mean that in a multi-page login, you would expect after selecting a credential chip, Autofill should fill in not only the first “username” on the first screen, but also “password” on the next screen. I believe this is working as intended. On the Compose side, it looks like we’re properly calling the autofill APIs. Looping in Kate from the autofill team to check: Kate, I double checked this with FormGen, and there’s the same behavior here (internal link) as the Compose sample here (internal link). So I assume we can’t expect filling on multi-page logins, and the user must reselect a chip for each page.

The second part is that even if the password field is not immediately filled, the chips disappear after a second of being displayed. Unfortunately I was not able to reproduce this even running the sample code locally ― but I do notice that clicking the displayed chips on the password page does not autofill. Only after clicking autofill in the text toolbar does selecting the chip actually invoke autofill. If the focusRequester is removed from the code, then autofill works fine.

Seems like Compose is still properly sending the requested information over and calling the right APIs. I see that in both instances (in the working version without focusRequester plus the one without it), Compose is calling notifyViewEntered for the password screen, and then populateViewStructure is called. But tapping onto the chip in the version with focusRequester does not trigger autofill (whereas it does without focusRequester). I glanced over the semantic properties we send, and they look identical between both text fields.

I’m attaching some logs for the working version here (internal link) vs non-working version here (internal link), plus a video of the sample with text toolbar autofill vs focus autofill to the comment. Kate, do you think you could take a quick look? We can also chat about this async.

Triage: this P1 is nearly out of SLO.

mnuzen@google.com skxu@google.com Is any of you working on it? Thanks!

Thanks soboleva@google.com, yes, I'm taking a look! I have a WIP CL up that I started before OOO, going to finish this this week.

Project: platform/frameworks/support
Branch: androidx-main
Author: Melba Nuzen <mnuzen@google.com>
Link:      https://android-review.googlesource.com/3506413

Only trigger commit when no autofillable components onscreen

Only trigger `commit` when no autofillable components onscreen 
 
Fixes: 392539099 
Test: `autofillManager_doNotCallCommit_partialRemoval` and others 
 
Autocommit will only be invoked when there are no autofillable components currently displayed and when there were previously autofillable components onscreen. This prevents overeagerly calling `commit` in scenarios such as multipage logins. If developers need a session to be committed, they can still explicitly call `autofillManager.commit()` where needed. 
 
Change-Id: Ic9ed6f9951163da3c39f31a771435eca14a8859a