Obsolete
Status Update
No update yet.
Comments
ch...@appspot.gserviceaccount.com
I highly support this, this way every current FormGroup subclass can define only the functions it needs (Everything besides Address can get rid of the AutofillType API and of the app_locale parameters, many classes could also get rid of the VerificationStatus API, etc.)
AutofillProfile could then implement a GetDataForType(FieldType) -> absl::variant<Address, NameInfo, ...> and provide the current API with visit calls instead of polymorphism.
Description
Internal (Googlers-only) Reports:
- Chromium:
(Legacy) Chromeperf Report:
Top 1 regressions (out of 1, with 0 improvements) in this group:
- ChromiumPerf/mac-intel-perf/rendering.desktop.notracing/motionmark/motionmark_ramp_composite
17.19%: 2032.0038 -> 1682.6459 unitless
Top 1 affected measurements in mac-intel-perf:
- rendering.desktop.notracing/motionmark/motionmark_ramp_composite
17.19%: 2032.0038 -> 1682.6459 unitless
Regressions grouped by rendering.desktop.notracing includes data from the following benchmarks with listed owners:
rendering.desktop.notracing: chrome-gpu-metrics@google.com, jonross@chromium.org
Commits in this range:
Chromium Git Hash:
Chromium Commit Position:
V8 Commit Position:
WebRTC Git Hash: