Status Update
Comments
24...@project.gserviceaccount.com <24...@project.gserviceaccount.com> #2
Tram, can you confirm that the behavior is correct if the modifier is moved to the composable inside the AnimatedPane?
24...@project.gserviceaccount.com <24...@project.gserviceaccount.com> #3
Hi Max, yes when the modifiers are moved to the composable inside the AnimatedPane, the PB animations are better than when the modifiers are in the AnimatedPane itself
vm...@google.com <vm...@google.com> #5
After some investigation, I can conclude this behavior is consistent with other animation "wrapper" composables, e.g. AnimatedVisibility
. Modifiers should indeed be applied to the children in order to properly participate in the animation.
sk...@chromium.org <sk...@chromium.org> #6
The regression range says this regressed last Nov, which would rule out scoped view transitions. But none of the CLs in the range look plausible.
Scoped view transitions is behind a flag (status:experimental) and doesn't affect the lifecycle of document-level view transitions.
Tentatively reassigning back to vmpstr@.
vm...@google.com <vm...@google.com> #7
I think the problem here is that although the testcase has no vt, it triggers during a gc sweep which may have previous test information in it. And yeah, I'm not sure if the regression range is accurate since we should have seen this issue all along. But this is a beta blocker, which presumably means it's a recent regression
ch...@google.com <ch...@google.com> #8
This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone.
All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly.
Thanks for your time! To disable nags, add Disable-Nags (case sensitive) to the Chromium Labels custom field.
ap...@google.com <ap...@google.com> #9
Project: chromium/src
Branch: main
Author: Vladimir Levin <
Link:
vt: Allow kIdle state when destroying VT style tracker
Expand for full commit details
vt: Allow kIdle state when destroying VT style tracker
Since the style tracker can be destroyed before kCapturing phase
(but after kInitial), we need to also allow the kIdle state for the
style tracker.
R=khushalsagar@chromium.org
Bug: 399698557
Change-Id: I3e738fe172dd04735b4fbcf5ebe97f32dd883c01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330377
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1428964}
Files:
- M
third_party/blink/renderer/core/view_transition/view_transition_style_tracker.cc
Hash: 7ec1ac4d8cf7095cf812642a0ab38beea75120cc
Date: Thu Mar 06 08:57:11 2025
vm...@google.com <vm...@google.com> #10
This should be fixed in #9. If possible, please verify
Description
Fuzzer: lcamtuf_cross_fuzz
Job Type: linux_tsan_chrome_mp
Platform Id: linux
Crash Type: CHECK failure
Crash Address:
Crash State:
state_ == State::kFinished in view_transition_style_tracker.cc
logging::CheckNoreturnError::~CheckNoreturnError
blink::ViewTransitionStyleTracker::~ViewTransitionStyleTracker
Sanitizer: thread (TSAN)
Regressed:
Reproducer Testcase:
Issue filed automatically.
To reproduce this, please build the target in this report and run it against the reproducer testcase. Please use the GN arguments provided at bottom of this report when building the binary.
If you have trouble reproducing, please also export the environment variables listed under "[Environment]" in the crash stacktrace.
If you have any feedback on reproducing test cases, let us know at