broken URLs to diff view [40015116]

Fixed

Bug

merge-merged-stable-3.7

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Oct 14, 2022 08:48AM

Affected Version: current master and stable-3.7

What steps will reproduce the problem?
1. setup a Gerrit server with config httpd.listenUrl = proxy-https://127.0.0.1:8080/review/
2. go to the overview screen of a change (URL /review/c/project/+/change)
3. click on a link of one of the changed files

What is the expected output?
The diff view for this file is shown (URL /review/c/project/+/change/patchset/path)

What do you see instead?
The link points to URL /c/project/+/change/patchset/path (note the missing /review), resulting in a 404 error.

What is the output of the JS console log (if applicable)?
none

What is the performance record (see https://developers.google.com/web/tools
/chrome-devtools/evaluate-performance/reference#record)(if applicable)?

Please provide any additional information below.

I could bisect down to these commits:

\* 58a8a4f23fc (refs/changes/76/345876/2, refs/bisect/bad) Fix dependency cycle.  
\*   4dba5ab4b21 Merge "Use display name if it is set for getAccountDisplayName"  
|\    
| \* acbdf00b566 (refs/changes/29/345829/3) Use display name if it is set for getAccountDisplayName  
\* | d8f61e7e16f (refs/changes/95/345595/6) Apply "Move padding from body top to header bottom""  
|/    
\* 6bd846c657c Merge "Fix AttentionSet updated events"  
\*   4f18adf3767 Merge changes I00e11d59,Ib1901b7c,I747d13a8,I8d8c175e  
|\    
| \* 26db742a1fb (refs/changes/23/345823/3) Move generating of repo URLs into repo.ts  
| \* 3868e43391c (refs/changes/22/345822/2) Move generating of settings URLs into settings.ts  
| \* 2148185bcd7 (refs/changes/21/345821/3) Remove edit url generation from gr-navigation  
| \* 3ffed1e7877 (refs/changes/20/345820/2) Add edit_test  
\* | fc2d269d941 Merge "Fix Guest should also have auto mode by default"  
|/    
\* 05b629f70b4 (HEAD) Merge changes I532faa2d,I883d8027,I374e5ca3,Iabb10c69  
\* 804e724bc05 (refs/changes/16/345816/3) Move generating of change URLs into change.ts  
\* 731738b2fcd (refs/changes/15/345815/2) Move generating of diff URLs into diff.ts  
\* 6a0033a35f8 (refs/changes/55/345755/3) Move generating of edit URLs into edit.ts

Comments

br...@google.com <br...@google.com> #2Oct 14, 2022 09:34AM

Accepted by br...@google.com.

I notice the same issue and LogCat shows the following message:
Google Play services out of date. Requires 3159100 but found 3136130

br...@google.com <br...@google.com> #3Oct 14, 2022 09:35AM

Same here.

"Google Play services out of date. Requires 3159100 but found 3136130"

br...@google.com <br...@google.com> #4Oct 14, 2022 10:08AM

me as well....
Google Play services out of date. Requires 3159100 but found 3136130

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #5Oct 14, 2022 01:35PM

I was hopeful that the release of API 18 (4.3) would have created a solution to this, unfortunately it includes version 3158130

gi...@appspot.gserviceaccount.com <gi...@appspot.gserviceaccount.com> #6Oct 14, 2022 09:08PM

Having the same issue:

07-25 00:03:54.998: W/GooglePlayServicesUtil(27293): Google Play services out of date. Requires 3159100 but found 3158130

th...@yahoo.com <th...@yahoo.com> #7Oct 24, 2022 12:43AM

Marked as fixed.

same

is...@google.com <is...@google.com> #8Oct 24, 2022 12:43AM

SAME ! - Google can't do sth working in 100 percent?

IssueTracker

This issue is a part of the Gerrit tracker.