[Merge M134] WebView Prerender: Prerendered pages triggered by speculation rules cannot be activated by loadURL with additional headers [400285699]

Assigned

Bug

Status Update

No update yet.

Description

pe...@google.com

created issue #1

Mar 3, 2025 01:27AM

This is an M134 merge request from crbug/399478939. The following changes were detected on the parent issue:

To proceed with this merge request:

Please update the following custom fields on this issue:
- Code Changes - Change(s) to be merged. (Please add the full Gerrit URL of all trunk changes.)
- OS - OS(s) impacted by the change(s).
- Safe Merge - All change(s) meet Safe Merge Criteria (see below)
- Flag Name - Please provide the experiment flag name or leave blank if not applicable.
Please provide justification of why this merge is required in the comment box.
When ready for review, assign this bug to merges@chromium.org

Safe Merge Criteria

Please only select Yes in the Safe Merge field if all the following apply:

Change(s) are guarded entirely behind a finch flag enabled at less than 5% in the Stable channel.
Change(s) have baked for 24 hours in Canary on all applicable OSs.
Change(s) have been verified in a live Canary against all applicable OSs.
Change(s) do not modify any strings that require translation. (.grd or .grdp files.)
Change(s) do not affect WebView.

Please contact the milestone owner if you have questions.

Owners: lmenezes (ChromeOS), srinivassista (Desktop US), danielyip (Desktop EMEA), govind (Mobile US), eakpobaro (Mobile EMEA)

*This merge request uses Chrome's new merge process. Find more information at go/chrome-merge-quickstart.

Comments

nh...@chromium.org <nh...@chromium.org> #2Mar 3, 2025 01:40AM

Tram, can you confirm that the behavior is correct if the modifier is moved to the composable inside the AnimatedPane?

nh...@chromium.org <nh...@chromium.org> #3Mar 3, 2025 01:43AM

Reassigned to me...@chromium.org.

Hi Max, yes when the modifiers are moved to the composable inside the AnimatedPane, the PB animations are better than when the modifiers are in the AnimatedPane itself

pe...@google.com <pe...@google.com> #4Mar 3, 2025 01:57AM

Given the straightforward workaround in comment#3, I'm going to downgrade the priority of this bug for now

go...@google.com <go...@google.com> #5Mar 3, 2025 05:21AM

After some investigation, I can conclude this behavior is consistent with other animation "wrapper" composables, e.g. AnimatedVisibility. Modifiers should indeed be applied to the children in order to properly participate in the animation.

nh...@chromium.org <nh...@chromium.org> #6Mar 5, 2025 02:17AM

Let me make the priority of this issue aligned with the priority of the original issue (P0).

nh...@chromium.org <nh...@chromium.org> #7Mar 5, 2025 02:21AM

torne@: Friendly ping. This is the CL we want to merge: https://chromium-review.googlesource.com/c/chromium/src/+/6310502

We admit this workaround is not clean. We plan to remove this workaround once the user migrates to the Java-based prerender API.

to...@google.com <to...@google.com> #8Mar 6, 2025 04:02PM

Apologies, didn't see this request - this looks fairly safe to merge given that it's for an experimental opt-in API.

go...@google.com <go...@google.com> #9Mar 6, 2025 04:07PM

Thank you, Torne.

I will review this for the March 18th refresh.

nh...@chromium.org <nh...@chromium.org> #10Mar 6, 2025 04:08PM

Thank you!

IssueTracker

This issue is a part of the Chromium tracker.