Feature Request P3
Status Update
No update yet.
Comments
dc...@chromium.org
Firefox appears to limit it to a max depth of 200.
ea...@chromium.org
Should we implement a depth limit for NG?
ik...@chromium.org
We should seriously consider it -
Verified that FF == 200, I tried with Edge and on my VM they capped out at ~500, they probably don't have a firm limit and might be stack heavy.
We are initially going to be very stack heavy so we'll probably have a lower limit than we do today - we may want to bring this up at the next CSSWG and try to standardize on a reasonable upper limit.
Verified that FF == 200, I tried with Edge and on my VM they capped out at ~500, they probably don't have a firm limit and might be stack heavy.
We are initially going to be very stack heavy so we'll probably have a lower limit than we do today - we may want to bring this up at the next CSSWG and try to standardize on a reasonable upper limit.
ik...@chromium.org
Additional context with NG we'll be able to produce a fragment tree which we can use which will keep the page still interactive if we want even if folks go over this limit. Alternatively we may want to just jump somewhere sane and crash.
dc...@chromium.org
[Empty comment from Monorail migration]
wa...@chromium.org
[Empty comment from Monorail migration]
cl...@chromium.org
[Empty comment from Monorail migration]
cl...@chromium.org
[Empty comment from Monorail migration]
cl...@chromium.org
Automatically applying components based on information from OWNERS files. If this seems incorrect, please apply the Test-Predator-Wrong-Components label.
dc...@chromium.org
[Empty comment from Monorail migration]
wa...@chromium.org
[Empty comment from Monorail migration]
cl...@chromium.org
ClusterFuzz testcase 5614405902663680 is verified as fixed, so closing issue as verified.
If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
dc...@chromium.org
[Empty comment from Monorail migration]
mb...@chromium.org
[Empty comment from Monorail migration]
wa...@chromium.org
[Empty comment from Monorail migration]
wa...@chromium.org
[Empty comment from Monorail migration]
br...@chromium.org
[Empty comment from Monorail migration]
cl...@chromium.org
[Empty comment from Monorail migration]
dc...@chromium.org
[Empty comment from Monorail migration]
br...@chromium.org
[Empty comment from Monorail migration]
ko...@chromium.org
[Empty comment from Monorail migration]
dc...@chromium.org
[Empty comment from Monorail migration]
wa...@chromium.org
[Empty comment from Monorail migration]
wa...@chromium.org
[Empty comment from Monorail migration]
cl...@chromium.org
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/27d732d9364e1f139dafdbacc813318b5a9a852f (Reland Devirtualize LayoutBoxModelObject logical orientation border/margin/padding accessors).
If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
wa...@chromium.org
[Empty comment from Monorail migration]
cl...@chromium.org
ClusterFuzz testcase 4628586229923840 appears to be flaky, updating reproducibility label.
wa...@chromium.org
[Empty comment from Monorail migration]
wa...@chromium.org
[Empty comment from Monorail migration]
ea...@chromium.org
[Empty comment from Monorail migration]
wa...@chromium.org
[Empty comment from Monorail migration]
ko...@chromium.org
[Empty comment from Monorail migration]
ko...@chromium.org
[Empty comment from Monorail migration]
dr...@chromium.org
[Empty comment from Monorail migration]
aj...@google.com
[Empty comment from Monorail migration]
wa...@chromium.org
[Empty comment from Monorail migration]
jm...@chromium.org
blink::NGFragmentItemsBuilder::NGFragmentItemsBuilder
As issue #1138842 duped here, updating latest info.
This is top#16th renderer crash seen on latest beta on android.
89.0.4389.72 23.39% 51----from 34 clients on latest beta
89.0.4389.69 11.47% 25
89.0.4389.57 6.88% 15
89.0.4389.48 4.13% 9
89.0.4389.72 100.04% 2,857 --from 1655 clients on latest stable
Requesting someone from cc'ed dev to update whether this is actionable to avoid spikes in future.
As issue #1138842 duped here, updating latest info.
This is top#16th renderer crash seen on latest beta on android.
89.0.4389.72 23.39% 51----from 34 clients on latest beta
89.0.4389.69 11.47% 25
89.0.4389.57 6.88% 15
89.0.4389.48 4.13% 9
89.0.4389.72 100.04% 2,857 --from 1655 clients on latest stable
Requesting someone from cc'ed dev to update whether this is actionable to avoid spikes in future.
ko...@chromium.org
[Empty comment from Monorail migration]
[Deleted User] <[Deleted User]>
[Empty comment from Monorail migration]
[Deleted User] <[Deleted User]>
[Empty comment from Monorail migration]
jm...@google.com
As issue #1138842 duped here, updating latest info.
blink::NGFragmentItemsBuilder::NGFragmentItemsBuilder
This is top#11th renderer crash seen on latest stable on android.
89.0.4389.105 3.76% 2,118. --latest stable-live for 2 days only
89.0.4389.90 17.91% 10,083 <--- prev stable
88.0.4324.181 5.45% 3,069 <--M88 last build
87.0.4280.141 7.65% 4,306. <--- M87 last build
86.0.4240.198 4.17% 2,349
Updating this as we are seeing spike on latest M89 builds compare to earlier stable builds.
Link to builds where we are seeing crashes:
https://crash.corp.google.com/browse?q=product_name%3D%27Chrome_Android%27+AND+expanded_custom_data.ChromeCrashProto.ptype%3D%27renderer%27+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27blink%3A%3ANGFragmentItemsBuilder%3A%3ANGFragmentItemsBuilder%27+AND+expanded_custom_data.ChromeCrashProto.channel%3D%27%27#-productname:1000,productversion:30,-processtype,-channel,magicsignature:100,magicsignature2:50,stablesignature:50,-day:70,+cpuinfo,experiments:120,-country
Windows:
89.0.4389.90 3.42% 28-from 27 clients -latest stable
89.0.4389.82 2.44% 20
Mac:
89.0.4389.90 9.38% 3 --from 2 clients -latest stable
89.0.4389.82 12.50% 4
Requesting someone from cc'ed dev to update whether this is actionable to avoid spikes in future?
blink::NGFragmentItemsBuilder::NGFragmentItemsBuilder
This is top#11th renderer crash seen on latest stable on android.
89.0.4389.105 3.76% 2,118. --latest stable-live for 2 days only
89.0.4389.90 17.91% 10,083 <--- prev stable
88.0.4324.181 5.45% 3,069 <--M88 last build
87.0.4280.141 7.65% 4,306. <--- M87 last build
86.0.4240.198 4.17% 2,349
Updating this as we are seeing spike on latest M89 builds compare to earlier stable builds.
Link to builds where we are seeing crashes:
Windows:
89.0.4389.90 3.42% 28-from 27 clients -latest stable
89.0.4389.82 2.44% 20
Mac:
89.0.4389.90 9.38% 3 --from 2 clients -latest stable
89.0.4389.82 12.50% 4
Requesting someone from cc'ed dev to update whether this is actionable to avoid spikes in future?
jm...@google.com
As issue #1138842 duped here, updating latest info.
blink::NGFragmentItemsBuilder::NGFragmentItemsBuilder
This is top#15th renderer crash seen on latest stable on android.
90.0.4430.66 0.01% 7 --rolled out only 50%
89.0.4389.105 45.48% 42,421 --from 22400 clients-latest stable
89.0.4389.90 12.11% 11,298
89.0.4389.86 16.12% 15,035
89.0.4389.72 5.31% 4,948
88.0.4324.181 3.42% 3,191
88.0.4324.155 0.06% 60
88.0.4324.152 2.30% 2,142
88.0.4324.141 0.74% 687
88.0.4324.93 1.27% 1,184
87.0.4280.141 4.66% 4,344
Requesting someone from cc'ed dev to update whether this is actionable to avoid spikes in future?
blink::NGFragmentItemsBuilder::NGFragmentItemsBuilder
This is top#15th renderer crash seen on latest stable on android.
90.0.4430.66 0.01% 7 --rolled out only 50%
89.0.4389.105 45.48% 42,421 --from 22400 clients-latest stable
89.0.4389.90 12.11% 11,298
89.0.4389.86 16.12% 15,035
89.0.4389.72 5.31% 4,948
88.0.4324.181 3.42% 3,191
88.0.4324.155 0.06% 60
88.0.4324.152 2.30% 2,142
88.0.4324.141 0.74% 687
88.0.4324.93 1.27% 1,184
87.0.4280.141 4.66% 4,344
Requesting someone from cc'ed dev to update whether this is actionable to avoid spikes in future?
ms...@chromium.org
We should investigate whether we can reduce engine stack usage from time to time.
According to the stack trace, there seems to be many inline formatting contexts nested. Those are quite stack-heavy, but what's the use case for nesting those so heavily? Oh well, beside the point, because it looks like it's happening.
According to the stack trace, there seems to be many inline formatting contexts nested. Those are quite stack-heavy, but what's the use case for nesting those so heavily? Oh well, beside the point, because it looks like it's happening.
ko...@chromium.org
[Empty comment from Monorail migration]
ik...@chromium.org
[Empty comment from Monorail migration]
dr...@chromium.org
[Empty comment from Monorail migration]
ko...@chromium.org
[Empty comment from Monorail migration]
ms...@chromium.org
[Empty comment from Monorail migration]
wa...@chromium.org
[Empty comment from Monorail migration]
ik...@chromium.org
[Empty comment from Monorail migration]
wa...@chromium.org
[Empty comment from Monorail migration]
pd...@chromium.org
Our code is used in all sorts of interesting ways (e.g., complex graphs embedded in complex documents) and I think crashing is preferable to failing to render in hard-to-debug ways, as long as this isn't a maintenance/triage burden for the layout team. The stack size on windows has been increased since this bug was filed (https://crrev.com/675518 ). The prepaint treewalk was previously our stack-hungriest layout treewalk and we removed heap-allocation workarounds (https://crrev.com/875398 ) with no issues so far.
pd...@chromium.org
There is a maximum parser-generated dom tree depth of 512 (kMaximumHTMLParserDOMTreeDepth) that is implemented in all browsers (see excellent discussion at https://github.com/whatwg/html/issues/3732 ) but there is no limit for js tree modification.
ms...@chromium.org
[Empty comment from Monorail migration]
ms...@chromium.org
[Empty comment from Monorail migration]
ms...@chromium.org
[Empty comment from Monorail migration]
ko...@chromium.org
[Empty comment from Monorail migration]
ko...@chromium.org
[Empty comment from Monorail migration]
ms...@chromium.org
[Empty comment from Monorail migration]
ko...@chromium.org
[Empty comment from Monorail migration]
ko...@chromium.org
[Empty comment from Monorail migration]
ko...@chromium.org
[Empty comment from Monorail migration]
ko...@chromium.org
[Empty comment from Monorail migration]
ko...@chromium.org
[Empty comment from Monorail migration]
ik...@chromium.org
[Empty comment from Monorail migration]
ko...@chromium.org
[Empty comment from Monorail migration]
ko...@chromium.org
[Empty comment from Monorail migration]
ko...@chromium.org
[Empty comment from Monorail migration]
ko...@chromium.org
[Empty comment from Monorail migration]
yu...@chromium.org
[Empty comment from Monorail migration]
ko...@chromium.org
[Empty comment from Monorail migration]
ko...@chromium.org
[Empty comment from Monorail migration]
ms...@chromium.org
[Empty comment from Monorail migration]
ms...@chromium.org
[Empty comment from Monorail migration]
ko...@chromium.org
[Empty comment from Monorail migration]
ms...@chromium.org
[Empty comment from Monorail migration]
ik...@chromium.org
[Empty comment from Monorail migration]
cl...@chromium.org
[Empty comment from Monorail migration]
cl...@chromium.org
Automatically adding ccs based on OWNERS file / target commit history.
If this is incorrect, please add the ClusterFuzz-Wrong label.
If this is incorrect, please add the ClusterFuzz-Wrong label.
ko...@chromium.org
[Empty comment from Monorail migration]
ms...@chromium.org
[Empty comment from Monorail migration]
dt...@chromium.org
[Empty comment from Monorail migration]
ko...@chromium.org
[Empty comment from Monorail migration]
ko...@chromium.org
[Empty comment from Monorail migration]
tk...@chromium.org
[Empty comment from Monorail migration]
tk...@chromium.org
[Empty comment from Monorail migration]
ms...@chromium.org
[Empty comment from Monorail migration]
ms...@chromium.org
[Empty comment from Monorail migration]
wa...@chromium.org
[Empty comment from Monorail migration]
is...@google.com
This issue was migrated from crbug.com/chromium/721175?no_tracker_redirect=1
[Monorail blocking:crbug.com/chromium/718307 , crbug.com/chromium/762363 ]
[Monorail mergedwith:crbug.com/chromium/1044408 , crbug.com/chromium/1138842 , crbug.com/chromium/1152624 , crbug.com/chromium/1160170 , crbug.com/chromium/1186588 , crbug.com/chromium/1200701 , crbug.com/chromium/1215473 , crbug.com/chromium/1216114 , crbug.com/chromium/1232487 , crbug.com/chromium/1232737 , crbug.com/chromium/1235997 , crbug.com/chromium/1237803 , crbug.com/chromium/1249031 , crbug.com/chromium/1260725 , crbug.com/chromium/1281035 , crbug.com/chromium/1299249 , crbug.com/chromium/1315032 , crbug.com/chromium/1323541 , crbug.com/chromium/1324980 , crbug.com/chromium/1335089 , crbug.com/chromium/1335474 , crbug.com/chromium/1335684 , crbug.com/chromium/1335827 , crbug.com/chromium/1338381 , crbug.com/chromium/1344353 , crbug.com/chromium/1346454 , crbug.com/chromium/1347046 , crbug.com/chromium/1347327 , crbug.com/chromium/1351294 , crbug.com/chromium/1352863 , crbug.com/chromium/1356892 , crbug.com/chromium/1358464 , crbug.com/chromium/1395589 , crbug.com/chromium/1407367 , crbug.com/chromium/1409293 , crbug.com/chromium/1415159 , crbug.com/chromium/1455748 , crbug.com/chromium/1477546 , crbug.com/chromium/1480946 , crbug.com/chromium/1505644 , crbug.com/chromium/1507469 , crbug.com/chromium/1509704 , crbug.com/chromium/1510283 , crbug.com/chromium/1516095 , crbug.com/chromium/1516609 , crbug.com/chromium/1517541 , crbug.com/chromium/760796 , crbug.com/chromium/773574 , crbug.com/chromium/795739 , crbug.com/chromium/797537 , crbug.com/chromium/804089 , crbug.com/chromium/818435 , crbug.com/chromium/827877 , crbug.com/chromium/842889 , crbug.com/chromium/855837 , crbug.com/chromium/857184 , crbug.com/chromium/879946 , crbug.com/chromium/888605 , crbug.com/chromium/930491 , crbug.com/chromium/981941 , crbug.com/chromium/983772 ]
[Monorail components added to Component Tags custom field.]
[Monorail blocking:
[Monorail mergedwith:
[Monorail components added to Component Tags custom field.]
24...@project.gserviceaccount.com
Automatically applying components based on crash stacktrace and information from OWNERS files.
If this is incorrect, please apply the hotlistid:Test-Predator-Wrong-Components.
If this is incorrect, please apply the hotlistid:Test-Predator-Wrong-Components.
24...@project.gserviceaccount.com
Automatically applying components based on crash stacktrace and information from OWNERS files.
If this is incorrect, please apply the hotlistid:Test-Predator-Wrong-Components.
If this is incorrect, please apply the hotlistid:Test-Predator-Wrong-Components.
24...@project.gserviceaccount.com
Automatically applying components based on crash stacktrace and information from OWNERS files.
If this is incorrect, please apply the hotlistid:Test-Predator-Wrong-Components.
If this is incorrect, please apply the hotlistid:Test-Predator-Wrong-Components.
24...@project.gserviceaccount.com
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/a17f9611e4a4d7ede12b3d6a770aa0bf27208f2b (Make size-adjust-01 more focus on `size-adjust`).
If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
24...@project.gserviceaccount.com
Automatically applying components based on crash stacktrace and information from OWNERS files.
If this is incorrect, please apply the hotlistid:Test-Predator-Wrong-Components.
If this is incorrect, please apply the hotlistid:Test-Predator-Wrong-Components.
24...@project.gserviceaccount.com
Automatically applying components based on crash stacktrace and information from OWNERS files.
If this is incorrect, please apply the hotlistid:Test-Predator-Wrong-Components.
If this is incorrect, please apply the hotlistid:Test-Predator-Wrong-Components.
24...@project.gserviceaccount.com
Automatically applying components based on crash stacktrace and information from OWNERS files.
If this is incorrect, please apply the hotlistid:Test-Predator-Wrong-Components.
If this is incorrect, please apply the hotlistid:Test-Predator-Wrong-Components.
24...@project.gserviceaccount.com
Automatically applying components based on crash stacktrace and information from OWNERS files.
If this is incorrect, please apply the hotlistid:Test-Predator-Wrong-Components.
If this is incorrect, please apply the hotlistid:Test-Predator-Wrong-Components.
24...@project.gserviceaccount.com
Automatically applying components based on crash stacktrace and information from OWNERS files.
If this is incorrect, please apply the hotlistid:Test-Predator-Wrong-Components.
If this is incorrect, please apply the hotlistid:Test-Predator-Wrong-Components.
24...@project.gserviceaccount.com
Automatically applying components based on crash stacktrace and information from OWNERS files.
If this is incorrect, please apply the hotlistid:Test-Predator-Wrong-Components.
If this is incorrect, please apply the hotlistid:Test-Predator-Wrong-Components.
ko...@chromium.org
24...@project.gserviceaccount.com
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/6e7487848976f30a8bd3a216e89dafaea48bd979 (Oilpan: Add Destructor to Promptly Free Stack Allocated HeapVector and HeapDeque).
If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
is...@google.com
ti...@chromium.org
Adding `ClusterFuzz-Ignore` hotlist to all `ClusterFuzz-Wrong` issues per crbug.com/40285975 .
Description