IssueTracker

I notice the same issue and LogCat shows the following message:
Google Play services out of date.  Requires 3159100 but found 3136130

Same here.

"Google Play services out of date. Requires 3159100 but found 3136130"

me as well....
Google Play services out of date. Requires 3159100 but found 3136130

I was hopeful that the release of API 18 (4.3) would have created a solution to this, unfortunately it includes version 3158130

Having the same issue:

07-25 00:03:54.998: W/GooglePlayServicesUtil(27293): Google Play services out of date.  Requires 3159100 but found 3158130

same

SAME ! - Google can't do sth working in 100 percent?

same issue - Google Play services out of date.  Requires 3159100 but found 3158130

Having the same issure:

07-26 03:14:00.731: W/GooglePlayServicesUtil(2566): Google Play services out of date.  Requires 3159100 but found 3136130

API 18 (4.3)  same issue
07-26 03:54:03.303: W/GooglePlayServicesUtil(1207): Google Play services out of date.  Requires 3159100 but found 3158130

Same issue here.

Same issue here. How can i fix this bug?

We're working on this. I don't have an ETA yet other than the maddeningly vague "soon".

Thanks for the update @sbarta. It is good that you are keeping us informed. This is a very critical and blocking bug for anyone developing with maps.

FYI also getting same with PlusClient sign in, so this is not just a maps issue:

ConnectionResult.SERVICE_VERSION_UPDATE_REQUIRED

07-30 12:35:50.059: W/GooglePlayServicesUtil(16054): Google Play services out of date.  Requires 3159100 but found 1013

Same page here!

07-31 22:47:40.277: W/GooglePlayServicesUtil(1009): Google Play services out of date.  Requires 3159100 but found 3158130

Thing is: we work under timelines too, and we need this fix quick! I cannot go wondering around asking for cellphones all over the place... I used to have this fixed with my emulators!!

Issue 36949180 requires a change to the emulator images. A comment just added states: "This will be fixed with the next update to the emulator system image, due out within a few weeks."

The Play Services team knows about this issue and is working on it with a high priority. The fix for this will go in the same emulator image in the same timeframe. Sorry I'm being vague about when it'll go out; I don't want to tell you something and then have us miss it. I'll update this bug when I know more.

Just would like to add that we are experiencing this on device as well, not just in AVD.  Not sure if that matters...

Any ETA on this fix? Appreciate your reply.

There's no ETA yet. I think a new version of the Google Play Services add-on in the SDK manager is going out today, but this doesn't help the issue of needing to update the emulator system images.

Any update on this?

Any chance you could put a note in the tutorial/setup documentation as it is infuriating (not to mention a waste of time) to follow steps exactly as described and not get something working. Resorting to Stack Overflow to find a load of hacks (and a lot of incorrect answers) for manually installing the required .apks and finally a link here to see that the issue is at least 3 weeks old with no target fix date.

I agree, please update the documentation while it is not working.

Agreed on updating the documentation. I wasted two days on this issue and it pains me to see it repeated Ad nauseam.

I lost hours on this problem thinking it was my fault.
Is ridiculous that a company like google do shit like that.

This should go out today.

@howardb Thank Jah!

I just updated Android in Eclipse via the SDK Manager.  The first launch of my previously working application on the emulator (using Google APIs - API Level 17) generated the following error:.
 GooglePlayServicesUtil(1105): Google Play services out of date.  Requires 3159100 but found 3136130

Only using a new Emulator (using Google APIs - API Level 18) does the application run.  

Will the older API Level 17 be updated with a new Google Play services?

Sorry, we're only committing to keeping the latest API up-to-date.

How to fix this?
Google Play services out of date.  Requires 3225100 but found 3136130

gone mad with the problem:

Google Play services out of date.  Requires 3264100 but found 3225136

Plz somebody give some fix...

After updating my sdk to API 18, my AVD doesn't play any sound.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/65d374698dd3e5d12454b566c374eae4abd593f1

commit 65d374698dd3e5d12454b566c374eae4abd593f1
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Jul 13 17:49:06 2021

Roll DevTools Frontend from ef157dab2ccf to 517808797a7e (4 revisions)

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ef157dab2ccf..517808797a7e

2021-07-13 sigurds@chromium.org Resolve TODOs in Connections.ts
2021-07-13 dsv@chromium.org Made small preview a little larger to match other icons size.
2021-07-13 sigurds@chromium.org Resolve some more TODOs in InspectorBackend.js
2021-07-13 sigurds@chromium.org Remove special case in animation playback rate button

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1172300,chromium:1228677
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: If360855f362d616294bb54171d7e15ef44223e7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3024704
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#901085}

[modify] https://crrev.com/65d374698dd3e5d12454b566c374eae4abd593f1/DEPS

Same here...
The version of emulator (API 18, Google APIs rev 2) running Google Play services version 3.2.25 but the Play Client Library is of version 3.2.64 (rev 11).
Can we just get somewhere the older version of client library?
Or when you will update emulator with the latest Play services?

Found location of the old Google Play Services client library:
https://dl-ssl.google.com/android/repository/google_play_services_3225130_r10.zip

The issue is that we've paused rollout of the latest version of the Play Services APK, so many of those building with an updated client library can't update the APK on their devices. The plan is to roll back v11 of the client library until we get everything hammered out.

Version incompatibilities with the emulator are a slightly different issue (since the emulator has the APK baked in and can't update it); I'm investigating that.

I've purged version 11 temporarily from the servers as the issue gets fixed.

Note that users who installed r11 need to:
1- Open sdk manager, let it refresh its remote list.
2- Select Google Play Service v11 => Delete package
3- They should see v10 which they can install instead.

I followed the steps to delete the r11 package, but when I refresh the SDK manager, it still stays 11, not 10.  Still getting the "Google Play services out of date" message in LogCat.  Thanks in advance!

Preparing to install archives
Downloading Google Play services, revision 11
Download interrupted: URL not found.
Done. Nothing was installed.

What is this ?
The above message is shown while downloading Google Play Services, rev 11 through SDK manager.

#36 => Thank you mate!

To see Play Services v10 in your SDK manager, you may need to delete the .android/cache directory in your home directory and restart SDK manager.

The SDK Manager should try to refresh the cached version if it's older than 10 minutes. Not sure why it wouldn't be doing that for you.
In any case, you can simply wipe the cache from the UI: SDK Manager > menu Tools > Options > Clear Cache. Then menu Package > Reload.

same as,
Google Play services out of date.  Requires 4030500 but found 3136130

i need help...
10X

Just try this one,
uninstall api 17 Install Api 16 or 15

I got some more differently as Requires 4030500 but found 3025110
What i have to do; if i want version 3025110
and why it is asking

My Problem is I have a google play service revision 13 in my sdk manager. Now I need a diffrent revision of google play service 12 .. when ever i uninstall revision 13 the option stays on revision 13.. So Unable to install revision 12.. I know Mannually i can download and install.. but is there a way to do it via my sdk manager... I am hving the same issue google play service put of date Requires 3159100 but found 3136130...

I have the same problem

Requires 4131530 but found 4132500

this is te value of the metadata
<meta-data android:name="com.google.android.gms.version" android:value="4132500"/>

I can´t change this value
what should i do?

Has there been a further update to this problem ? it occurs while using SDK with api-19 as well. The playservices version i am using is 14.

I get this with an emulator from the latest 'Google APIs (Google Inc.) - API Level 17' when running any of the play services sample code:

  Google Play services out of date.  Requires 4132500 but found 3136130

I know that updating play services is intimately linked with the play store, but Google really needs to find a sensible way to update it out of band on emulators.  The current situation is untenable, and makes developing and testing apps using play services unnecessarily difficult.

same here
Google Play services out of date.  Requires 4132500 but found 3136130

any solutios

[Comment deleted]

Having the same issue here when trying to run on the emulator:
Google Play services out of date.  Requires 5077000 but found 4323030

Really, this development experience has been the worst. Google, you guys should be kinda embarrassed :|

Same here..

Google Play services out of date.  Requires 5077000 but found 3225130

What a non-friendly develop tool, have same issue.
And searching answer from google been 3 days, still struggling.

I got:

Google Play services out of date. Requires 5077000 but found 5053036 when running my app on Emulator. Down grade Google Play services in SDK manager seems not possible. Always display revision 18. How to get a revision to satisfy 5053036 on Emulator?

[Comment deleted]

what is really bad in my case is that I just downloaded the latest Android preview L, google play services revision 18 and they don't work together.

Same issue here Google Play services out of date.  Requires 5077500 but found 5053030. whats should i do?

Im able to reproduce the issue as well:

W/GooglePlayServicesUtil(20531): Google Play services out of date.  Requires 5077000 but found 4034536

Setup:
Google Play services version : 18
Platform : 4.4.2, 4.3, 4.2.2

I've got this message (Android L(DP)):

W/GooglePlayServicesUtil﹕ Google Play services out of date.  Requires 5208000 but found 5089036

I've been getting this error recently as well -
W/GooglePlayServicesUtil﹕ Google Play services out of date.  Requires 5208000 but found 5089036

This fixed it for me  - (https://stackoverflow.com/questions/25203415/after-update-crash-com-google-android-gmsplay-services5-2-8)

Change the Google Play Service version in your build.gradle to the version on your device or emulator.

compile 'com.google.android.gms:play-services:5.0.89'

@sdrosan...@gmail.com: If you change the version to the devices version, what happens if you run the app on a different device? Doesn't seem like a good solution.

I think I solved it for myself, my issue was that I installed Google Play 5.2.08 in my gradle file (compile 'com.google.android.gms:play-services:5.2.08') because 5.0.77 wasn't working.
1. I loaded the app onto my phone and it didn't work,
2. I had the latest update (that I could get on my phone) of google play so telling me to update was stupid
3. I ended up just needing to update my gradle file to the latest **compatible** googlePlay, in my case version 5.0.89.  

i had the same issue whilst trying to test an app on my HTC One...latest play services installed on my phone and in Android studio.

But as others have mentioned, I edited my build.gradle file to 'com.google.android.gms:play-services:5.0.89' and its delivered to my phone and working successfully.

THX

Play service outdated on emulator again. Now getting message:-

Google Play services out of date.  Requires 5089000 but found 5053036

 same : google play services out of date requires 6111000 but found1

same Error from my side : google play services out of date requires 6111000 but found1 5077534.Even though i had updated the services to  latest version still not showing changes.pls help

Fixed with
For Gradle:    
compile 'com.google.android.gms:play-services:5.0.77'
For Eclipse:
Add as library: https://dl-ssl.google.com/android/repository/google_play_services_5077000_r18.zip

If above did not work, try to use older playstore service version of android playstore client.
https://dl-ssl.google.com/android/repository/google_play_services_4132530_r14.zip
https://dl-ssl.google.com/android/repository/google_play_services_4242030_r15.zip
https://dl-ssl.google.com/android/repository/google_play_services_4323030_r16.zip
https://dl-ssl.google.com/android/repository/google_play_services_5077000_r18.zip
https://dl-ssl.google.com/android/repository/google_play_services_5089000_r19.zip
https://dl-ssl.google.com/android/repository/google_play_services_6171000_r21.zip

i have update google play service from sdk but still display in emulator "this app won't work unless you update google play service"..i am using in api 18 4.3.1.

In my understanding the services are already on the device, and your app is just using it. For some devices it might also happen that the "play-services" are outdated. Sooooo....

After adding
compile 'com.google.android.gms:play-services:6.5.87'

I also updated
https://play.google.com/store/apps/details?id=com.google.android.gms&hl=de 
on the device

Now i don't have the warning anymore and it works like a charm.

The simple answer to this is that this problem occurs when the Google Play SDK is updated, but the update of the Google Play Client libraries is not (yet) available in the store. That happens from time to time in some areas (like europe).

The simple solution to that is just to wait a while until yo use the newest google play sdk.

I'm handling this same error, and it's the last of a veeeeery large sack of errors. I've been developing many years with java-eclipse, c#-visual studio, and many IDE's and technologies, and I must say that Android Studio(IntelliJ)-Androdid SDK is the worst programming experience of my life.
I'm starting to hate Google so much that it scares me.

Tim, do you know if we should close this one?

I think we will need to close this one for now. There are 479 results that pop up when searching for crbug.com/1172300, but the code in question almost always uses `any`. While it would be amazing to clean these up, I don't think we are in a position to do so given our engineering resource allocation.

We have done as much as we could here, so let's close this for now and mostly keep it as background information.

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/5113fff1ed69ceaf4e6adc29d02b46c1d5f7aac0

commit 5113fff1ed69ceaf4e6adc29d02b46c1d5f7aac0
Author: Simon Zünd <szuend@chromium.org>
Date: Mon Dec 13 11:11:49 2021

[cleanup] Use 'void' for callback return types in DOMModel

R=tvanderlippe@chromium.org

Bug: 1172300
Change-Id: I04c6bec11cf75a6ae58684f8b40074de35a108db
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3334541
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>

[modify] https://crrev.com/5113fff1ed69ceaf4e6adc29d02b46c1d5f7aac0/front_end/core/sdk/DOMModel.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/b5f5293c34e93b194379e0ddb873eb2a31f4e531

commit b5f5293c34e93b194379e0ddb873eb2a31f4e531
Author: Simon Zünd <szuend@chromium.org>
Date: Mon Dec 13 11:27:06 2021

[cleanup] Remove explicit any usage in OverlayModel.ts

R=tvanderlippe@chromium.org

Bug: 1172300
Change-Id: Iee2e41e960e235b6ef8cf7bdbc2bce67577402be
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3334542
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>

[modify] https://crrev.com/b5f5293c34e93b194379e0ddb873eb2a31f4e531/front_end/core/sdk/OverlayModel.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/06a806c1ed0c3871c2da24db6f0f3d8a1acb6f19

commit 06a806c1ed0c3871c2da24db6f0f3d8a1acb6f19
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Dec 13 15:49:26 2021

Roll DevTools Frontend from 784f3c36176c to 0e3067f96d33 (7 revisions)

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/784f3c36176c..0e3067f96d33

2021-12-13 aerotwist@chromium.org Remove patchColorText from TickingFlameChart
2021-12-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2021-12-13 szuend@chromium.org [cleanup] Remove explicit any usage in OverlayModel.ts
2021-12-13 szuend@chromium.org [cleanup] Use 'void' for callback return types in DOMModel
2021-12-13 szuend@chromium.org [cleanup] Remove unnecessary Closure-style casts
2021-12-13 tvanderlippe@chromium.org Fix deps for ui/legacy/components/utils
2021-12-13 aerotwist@chromium.org Add caching to ThemeSupport.getComputedValue

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1172300,chromium:1278738
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ie806e64e1cacdc7fb64765e6a7e3bcc5a1d31303
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334704
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#951034}

[modify] https://crrev.com/06a806c1ed0c3871c2da24db6f0f3d8a1acb6f19/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/269e9ae3ebd8d9c79fa42e19a8674d45afd8cc9f

commit 269e9ae3ebd8d9c79fa42e19a8674d45afd8cc9f
Author: Tim van der Lippe <tvanderlippe@chromium.org>
Date: Tue Dec 14 13:33:28 2021

Replace any in return values for void

This applies the following regex to the codebase:

=> any

and replaces it with

=> void

All obsolete typescript-eslint disable rules have been removed as well.

R=szuend@chromium.org

Bug: 1172300
Change-Id: I98dc2153f539c68853ed4e9cba8503a4b69763ab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3338347
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>

[modify] https://crrev.com/269e9ae3ebd8d9c79fa42e19a8674d45afd8cc9f/front_end/panels/event_listeners/EventListenersUtils.ts
[modify] https://crrev.com/269e9ae3ebd8d9c79fa42e19a8674d45afd8cc9f/front_end/models/extensions/ExtensionAPI.ts
[modify] https://crrev.com/269e9ae3ebd8d9c79fa42e19a8674d45afd8cc9f/front_end/panels/sources/NavigatorView.ts
[modify] https://crrev.com/269e9ae3ebd8d9c79fa42e19a8674d45afd8cc9f/front_end/panels/elements/ElementsTreeElement.ts
[modify] https://crrev.com/269e9ae3ebd8d9c79fa42e19a8674d45afd8cc9f/front_end/panels/sources/SourcesPanel.ts
[modify] https://crrev.com/269e9ae3ebd8d9c79fa42e19a8674d45afd8cc9f/front_end/entrypoints/heap_snapshot_worker/HeapSnapshot.ts
[modify] https://crrev.com/269e9ae3ebd8d9c79fa42e19a8674d45afd8cc9f/front_end/panels/sources/SourceMapNamesResolver.ts
[modify] https://crrev.com/269e9ae3ebd8d9c79fa42e19a8674d45afd8cc9f/front_end/models/timeline_model/TimelineModel.ts
[modify] https://crrev.com/269e9ae3ebd8d9c79fa42e19a8674d45afd8cc9f/front_end/ui/legacy/components/data_grid/DataGrid.ts
[modify] https://crrev.com/269e9ae3ebd8d9c79fa42e19a8674d45afd8cc9f/extension-api/ExtensionAPI.d.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/0a98c2e84fd83c050532f12f105b57bf06f09dda

commit 0a98c2e84fd83c050532f12f105b57bf06f09dda
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Dec 14 17:13:25 2021

Roll DevTools Frontend from a1121f966ce5 to 5fec567a800a (5 revisions)

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a1121f966ce5..5fec567a800a

2021-12-14 aerotwist@chromium.org Remove patchColorText in ConsoleViewMessage
2021-12-14 tvanderlippe@chromium.org Replace any in return values for void
2021-12-14 dsv@chromium.org Test for source maps loading via chrome-extension://
2021-12-14 szuend@chromium.org [cleanup] Remove unnecessary @interface comments
2021-12-14 marijnh@gmail.com Hide argument tooltip in editor when the content changes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1172300,chromium:1278738,chromium:1279782,chromium:212374
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Iad7168942f76927183cafc858b517e1c03869e11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339231
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#951540}

[modify] https://crrev.com/0a98c2e84fd83c050532f12f105b57bf06f09dda/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/b6a3b2ae8a4c1d5847c2bb1535377e13ee3045be

commit b6a3b2ae8a4c1d5847c2bb1535377e13ee3045be
Author: Johan Bay <jobay@chromium.org>
Date: Mon May 30 14:40:25 2022

Introduce explicit opening/closing tag types in DOM tree outline

We currently have a few runtime type errors from trying to add an
adorner to a `close` html tag element.
This change introduces a more strict TS typing for DOM tree elements
fields that are only applicable for opening tags. This more explicit
typing ensures that we can't accidentally get into an inconsistent state
where only some of the necessary fields are populated.
As part of this work we also remove a few `@ts-expect-error`.

Bug: 1172300
Change-Id: Iaf80517a76b6bd7e8edee115aad441e5101fd19b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3675715
Commit-Queue: Johan Bay <jobay@chromium.org>
Reviewed-by: Changhao Han <changhaohan@chromium.org>

[modify] https://crrev.com/b6a3b2ae8a4c1d5847c2bb1535377e13ee3045be/front_end/panels/elements/ElementsTreeElement.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/f594472f1ce0088bba9ba3f6f6c90388441d017f

commit f594472f1ce0088bba9ba3f6f6c90388441d017f
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon May 30 18:51:32 2022

Roll DevTools Frontend from 52ef35da10bb to b6a3b2ae8a4c (1 revision)

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/52ef35da10bb..b6a3b2ae8a4c

2022-05-30 jobay@chromium.org Introduce explicit opening/closing tag types in DOM tree outline

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1172300
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I6ca57bad87b661582b90cd7c6fd854d2f2e3ebe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3677316
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1008901}

[modify] https://crrev.com/f594472f1ce0088bba9ba3f6f6c90388441d017f/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/03e435c8aa8fb9fb34a2785156cc6d072fd70f2d

commit 03e435c8aa8fb9fb34a2785156cc6d072fd70f2d
Author: Simon Zünd <szuend@chromium.org>
Date: Fri Jan 27 11:41:08 2023

[cleanup] Remove @ts-expect-error in Linkifier

"onLiveLocationUpdate" is always initialized in the constructor
so we don't have to type it as "|undefined".

R=kimanh@chromium.org

Bug: 1172300
Change-Id: Ib7bd0caddadc5e14c879d4ccbbc4acb7a104b74b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4196921
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>

[modify] https://crrev.com/03e435c8aa8fb9fb34a2785156cc6d072fd70f2d/front_end/ui/legacy/components/utils/Linkifier.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/cc5c67849f380f2d0936f11bbdcf1f75c93109bc

commit cc5c67849f380f2d0936f11bbdcf1f75c93109bc
Author: Benedikt Meurer <bmeurer@chromium.org>
Date: Thu Dec 14 09:03:09 2023

[cleanup] Remove a few explicit any's and an unused field.

Bug: chromium:1172300
Change-Id: I482dbb0b0ed85faaa41aa95c950171cf1171804b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5119547
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>

[modify] https://crrev.com/cc5c67849f380f2d0936f11bbdcf1f75c93109bc/front_end/panels/sources/NavigatorView.ts
[modify] https://crrev.com/cc5c67849f380f2d0936f11bbdcf1f75c93109bc/front_end/panels/sources/DebuggerPlugin.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/0e7a1928a715c84e21c27e754fc796a9680c8ffe

commit 0e7a1928a715c84e21c27e754fc796a9680c8ffe
Author: Benedikt Meurer <bmeurer@chromium.org>
Date: Thu Dec 14 09:54:47 2023

[cleanup] Remove `SearchSourcesView` singleton.

Remove the singleton and use a proper revealer to bring up the source
search drawer from other parts of the UI. Also simplify the complicated
view revealing gymnastics to a single `showView()` invocation (and
thereby remove some eslint violations).

Bug: chromium:1379221, chromium:1172300
Change-Id: I9caa1bf29ac917933bef06993cc4bca7e06805ab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5121871
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>

[modify] https://crrev.com/0e7a1928a715c84e21c27e754fc796a9680c8ffe/front_end/panels/sources/sources-meta.ts
[modify] https://crrev.com/0e7a1928a715c84e21c27e754fc796a9680c8ffe/front_end/panels/sources/NavigatorView.ts
[modify] https://crrev.com/0e7a1928a715c84e21c27e754fc796a9680c8ffe/test/e2e/sources/navigator-view_test.ts
[modify] https://crrev.com/0e7a1928a715c84e21c27e754fc796a9680c8ffe/front_end/panels/search/SearchView.ts
[modify] https://crrev.com/0e7a1928a715c84e21c27e754fc796a9680c8ffe/front_end/panels/sources/SearchSourcesView.ts

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/3dff32f397d556f5850cd873040297efdccadb59

commit 3dff32f397d556f5850cd873040297efdccadb59
Author: Nikolay Vitkov <nvitkov@chromium.org>
Date: Wed Jan 17 10:25:50 2024

Remove some uses of TypeScript's `any`

Here are a small group of examples where we can change any to either better match what we want or turn it into `unknown` which is safer typewise.

Bug: b:319814509, chromium:1172300
Change-Id: Ica1723133c3764a52f266709a25696a545d61fb5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5173896
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>

[modify] https://crrev.com/3dff32f397d556f5850cd873040297efdccadb59/test/shared/mocha-extensions.ts
[modify] https://crrev.com/3dff32f397d556f5850cd873040297efdccadb59/test/e2e/recorder/replay_test.ts
[modify] https://crrev.com/3dff32f397d556f5850cd873040297efdccadb59/test/unittests/front_end/models/issues_manager/StubIssue.ts
[modify] https://crrev.com/3dff32f397d556f5850cd873040297efdccadb59/front_end/core/platform/promise-utilities.ts
[modify] https://crrev.com/3dff32f397d556f5850cd873040297efdccadb59/front_end/panels/timeline/CountersGraph.ts
[modify] https://crrev.com/3dff32f397d556f5850cd873040297efdccadb59/front_end/ui/legacy/components/quick_open/FilteredListWidget.ts
[modify] https://crrev.com/3dff32f397d556f5850cd873040297efdccadb59/test/unittests/front_end/panels/application/components/BackForwardCacheView_test.ts
[modify] https://crrev.com/3dff32f397d556f5850cd873040297efdccadb59/front_end/core/common/Revealer.ts
[modify] https://crrev.com/3dff32f397d556f5850cd873040297efdccadb59/front_end/core/sdk/ConsoleModel.ts
[modify] https://crrev.com/3dff32f397d556f5850cd873040297efdccadb59/front_end/core/sdk/ResourceTreeModel.ts
[modify] https://crrev.com/3dff32f397d556f5850cd873040297efdccadb59/front_end/panels/sources/SourcesSearchScope.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/cfc8cd639e1bb61e25aa6b73e20fe0438b08aeb3

commit cfc8cd639e1bb61e25aa6b73e20fe0438b08aeb3
Author: Benedikt Meurer <bmeurer@chromium.org>
Date: Wed Jan 17 10:08:28 2024

[eslint] Allow `any` in rest parameters.

This enables the `ignoreRestArgs` setting[^1] for the ESLint rule
@typescript-eslint/no-explicit-any, which allows the use of `any`
in rest parameters (which is actually a valid use case for `any`)
and thereby reduces the number of pragmas in the code base where
we need to explicitly silence ESLint about this.

Drive-by-fixes: Refine some uses of `any` that can now be removed, and
refactor the heap snapshot worker proxy to make it easier to read and
type properly.

[^1]: https://typescript-eslint.io/rules/no-explicit-any/#ignorerestargs

Bug: b:319814509, chromium:1172300
Change-Id: I713f1fbf2a91348d422fb567c50d08d870e348cf
Doc: http://go/chrome-devtools:eslint-pain-points-design
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5204645
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>

[modify] https://crrev.com/cfc8cd639e1bb61e25aa6b73e20fe0438b08aeb3/front_end/models/extensions/ExtensionAPI.ts
[modify] https://crrev.com/cfc8cd639e1bb61e25aa6b73e20fe0438b08aeb3/.eslintrc.js
[modify] https://crrev.com/cfc8cd639e1bb61e25aa6b73e20fe0438b08aeb3/front_end/core/common/Object.ts
[modify] https://crrev.com/cfc8cd639e1bb61e25aa6b73e20fe0438b08aeb3/front_end/ui/components/legacy_wrapper/LegacyWrapper.ts
[modify] https://crrev.com/cfc8cd639e1bb61e25aa6b73e20fe0438b08aeb3/front_end/ui/legacy/Fragment.ts
[modify] https://crrev.com/cfc8cd639e1bb61e25aa6b73e20fe0438b08aeb3/front_end/panels/profiler/HeapSnapshotProxy.ts
[modify] https://crrev.com/cfc8cd639e1bb61e25aa6b73e20fe0438b08aeb3/front_end/ui/legacy/Context.ts
[modify] https://crrev.com/cfc8cd639e1bb61e25aa6b73e20fe0438b08aeb3/front_end/ui/legacy/ContextMenu.ts
[modify] https://crrev.com/cfc8cd639e1bb61e25aa6b73e20fe0438b08aeb3/front_end/core/common/Revealer.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/1e4a8069a9bde8f1c0c7fe3c78c9655eef8cfc50

commit 1e4a8069a9bde8f1c0c7fe3c78c9655eef8cfc50
Author: Benedikt Meurer <bmeurer@chromium.org>
Date: Wed Jan 17 12:38:35 2024

[cleanu] Remove more explicit uses of `any`.

Bug: chromium:1172300, b:319814509
Change-Id: I4f0623d5a180b6328b55b3e5e9b6083cdcb3bf1a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5204890
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>

[modify] https://crrev.com/1e4a8069a9bde8f1c0c7fe3c78c9655eef8cfc50/front_end/ui/legacy/components/utils/ImagePreview.ts
[modify] https://crrev.com/1e4a8069a9bde8f1c0c7fe3c78c9655eef8cfc50/front_end/core/sdk/DOMModel.ts
[modify] https://crrev.com/1e4a8069a9bde8f1c0c7fe3c78c9655eef8cfc50/front_end/ui/components/text_editor/javascript.ts
[modify] https://crrev.com/1e4a8069a9bde8f1c0c7fe3c78c9655eef8cfc50/front_end/models/source_map_scopes/NamesResolver.ts
[modify] https://crrev.com/1e4a8069a9bde8f1c0c7fe3c78c9655eef8cfc50/front_end/core/sdk/RuntimeModel.ts
[modify] https://crrev.com/1e4a8069a9bde8f1c0c7fe3c78c9655eef8cfc50/front_end/core/sdk/RemoteObject.ts
[modify] https://crrev.com/1e4a8069a9bde8f1c0c7fe3c78c9655eef8cfc50/front_end/panels/emulation/DeviceModeWrapper.ts
[modify] https://crrev.com/1e4a8069a9bde8f1c0c7fe3c78c9655eef8cfc50/front_end/core/sdk/ConsoleModel.ts
[modify] https://crrev.com/1e4a8069a9bde8f1c0c7fe3c78c9655eef8cfc50/front_end/core/sdk/DOMDebuggerModel.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/9a20ac6db78b8fe49291a6576c379b83583729e0

commit 9a20ac6db78b8fe49291a6576c379b83583729e0
Author: Benedikt Meurer <bmeurer@chromium.org>
Date: Wed Jan 17 14:40:22 2024

[cleanup] Remove explicit any use from Widget.

Bug: b:319814509, chromium:1172300
Change-Id: I37da65ffcf4028d0739a0540248c43295b7b0fd3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5205610
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>

[modify] https://crrev.com/9a20ac6db78b8fe49291a6576c379b83583729e0/front_end/ui/legacy/Widget.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/677d5834c5c28a8f317d4e2b0418b52615918196

commit 677d5834c5c28a8f317d4e2b0418b52615918196
Author: Benedikt Meurer <bmeurer@chromium.org>
Date: Fri Jan 19 08:53:35 2024

[cleanup] Change `enum` to `const enum` where possible.

Bug: b:319814509, chromium:1172300
Change-Id: Ie1dc5eb4d39a472949268043485c39896c2568d4
Fixed: chromium:1167717
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5210758
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>

[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/explain/components/ConsoleInsight.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/components/inline_editor/SwatchPopoverHelper.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/application/SharedStorageItemsView.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/layer_viewer/TransformController.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/network/NetworkTimeCalculator.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/components/perf_ui/OverviewGrid.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/host/InspectorFrontendHostAPI.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/PreloadingModel.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/KeyboardShortcut.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/components/perf_ui/FilmStripView.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/FrameManager.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/elements/components/CSSPropertyIconResolver.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/timeline/TimelineUIUtils.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/layer_viewer/PaintProfilerView.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/components/inline_editor/FontEditor.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/common/Settings.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/ActionRegistration.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/Infobar.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/network/forward/UIFilter.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/Dialog.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/ResizerWidget.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/TextPrompt.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/root/Runtime.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/StorageKeyManager.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/protocol_monitor/ProtocolMonitor.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/common/SettingRegistration.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/models/autofill_manager/AutofillManager.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/application/preloading/components/UsedPreloadingView.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/components/color_picker/Spectrum.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/DebuggerModel.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/CPUProfilerModel.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/profiler/ProfileHeader.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/ServiceWorkerCacheModel.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/models/bindings/NetworkProject.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/models/extensions/ExtensionServer.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/sources/TabbedEditorContainer.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/web_audio/graph_visualizer/EdgeView.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/timeline/TimelineFlameChartDataProvider.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/DOMDebuggerModel.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/TargetManager.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/network/RequestTimingView.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/AccessibilityModel.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/IsolateManager.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/LogModel.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/HeapProfilerModel.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/layers/LayerTreeModel.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/models/issues_manager/CorsIssue.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/application/InterestGroupStorageModel.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/InspectorView.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/ServiceWorkerManager.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/profiler/ProfileLauncherView.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/application/DatabaseModel.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/layer_viewer/LayerDetailsView.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/components/perf_ui/FlameChart.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/network/ResourceWebSocketFrameView.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/sources/UISourceCodeFrame.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/models/workspace/FileManager.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/application/AppManifestView.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/ChildTargetManager.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/OverlayModel.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/timeline/TimelineLoader.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/application/SharedStorageModel.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/components/quick_open/CommandMenu.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/models/extensions/RecorderPluginManager.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/Target.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/components/inline_editor/BezierEditor.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/ARIAUtils.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/NetworkManager.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/components/data_grid/DataGrid.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/models/timeline_model/TimelineJSProfile.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/timeline/TimelineTreeView.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/ListModel.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/components/inline_editor/CSSShadowEditor.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/Cookie.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/ContextMenu.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/CPUThrottlingManager.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/sources/SourcesView.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/network/forward/UIRequestLocation.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/CSSModel.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/components/data_grid/ViewportDataGrid.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/models/emulation/DeviceModeModel.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/models/persistence/NetworkPersistenceManager.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/components/utils/Linkifier.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/AutofillModel.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/test/unittests/front_end/core/sdk/FrameManager_test.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/network/NetworkWaterfallColumn.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/timeline/TimelineFlameChartView.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/network/NetworkLogViewColumns.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/host/UserMetrics.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/Toolbar.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/application/DOMStorageModel.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/models/workspace/UISourceCode.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/SplitWidget.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/LayerTreeBase.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/network/NetworkDataGridNode.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/profiler/HeapSnapshotGridNodes.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/components/quick_open/FilteredListWidget.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/timeline/TimelinePanel.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/application/ApplicationPanelSidebar.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/profiler/HeapSnapshotDataGrids.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/ViewRegistration.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/components/source_frame/SourceFrame.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/CSSMatchedStyles.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/common/Console.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/models/workspace_diff/WorkspaceDiff.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/NetworkRequest.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/recorder/extensions/ExtensionManager.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/models/issues_manager/Issue.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/core/sdk/PageResourceLoader.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/application/DatabaseQueryView.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/ui/legacy/Context.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/test/unittests/front_end/core/common/Console_test.ts
[modify] https://crrev.com/677d5834c5c28a8f317d4e2b0418b52615918196/front_end/panels/layer_viewer/Layers3DView.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/97f497e6be3a25ee3d489c31a183cafcb441ba15

commit 97f497e6be3a25ee3d489c31a183cafcb441ba15
Author: Philip Pfaffe <pfaffe@chromium.org>
Date: Fri Jan 19 15:26:41 2024

Revert "[cleanup] Change `enum` to `const enum` where possible."

This reverts commit 677d5834c5c28a8f317d4e2b0418b52615918196.

Reason for revert: Causes layout test failures, see https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/DevTools%20Linux/12365/overview

Original change's description:

Bug: b:319814509, chromium:1172300
Change-Id: Ica35cd9d77ca73602b5a295d5976cd96242192a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5217432
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/explain/components/ConsoleInsight.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/components/inline_editor/SwatchPopoverHelper.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/application/SharedStorageItemsView.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/layer_viewer/TransformController.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/network/NetworkTimeCalculator.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/components/perf_ui/OverviewGrid.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/host/InspectorFrontendHostAPI.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/PreloadingModel.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/KeyboardShortcut.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/components/perf_ui/FilmStripView.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/timeline/TimelineUIUtils.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/FrameManager.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/elements/components/CSSPropertyIconResolver.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/layer_viewer/PaintProfilerView.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/ActionRegistration.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/common/Settings.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/components/inline_editor/FontEditor.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/Infobar.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/network/forward/UIFilter.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/Dialog.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/ResizerWidget.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/TextPrompt.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/root/Runtime.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/StorageKeyManager.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/protocol_monitor/ProtocolMonitor.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/common/SettingRegistration.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/models/autofill_manager/AutofillManager.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/application/preloading/components/UsedPreloadingView.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/DebuggerModel.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/components/color_picker/Spectrum.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/CPUProfilerModel.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/profiler/ProfileHeader.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/ServiceWorkerCacheModel.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/models/bindings/NetworkProject.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/models/extensions/ExtensionServer.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/sources/TabbedEditorContainer.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/web_audio/graph_visualizer/EdgeView.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/timeline/TimelineFlameChartDataProvider.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/DOMDebuggerModel.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/TargetManager.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/network/RequestTimingView.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/AccessibilityModel.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/IsolateManager.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/HeapProfilerModel.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/LogModel.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/layers/LayerTreeModel.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/application/InterestGroupStorageModel.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/models/issues_manager/CorsIssue.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/InspectorView.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/ServiceWorkerManager.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/profiler/ProfileLauncherView.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/application/DatabaseModel.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/layer_viewer/LayerDetailsView.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/components/perf_ui/FlameChart.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/network/ResourceWebSocketFrameView.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/sources/UISourceCodeFrame.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/models/workspace/FileManager.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/application/AppManifestView.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/ChildTargetManager.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/OverlayModel.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/application/SharedStorageModel.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/timeline/TimelineLoader.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/components/quick_open/CommandMenu.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/models/extensions/RecorderPluginManager.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/Target.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/ARIAUtils.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/components/inline_editor/BezierEditor.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/NetworkManager.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/components/data_grid/DataGrid.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/models/timeline_model/TimelineJSProfile.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/timeline/TimelineTreeView.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/ListModel.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/components/inline_editor/CSSShadowEditor.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/ContextMenu.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/Cookie.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/CPUThrottlingManager.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/sources/SourcesView.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/network/forward/UIRequestLocation.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/CSSModel.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/components/data_grid/ViewportDataGrid.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/models/emulation/DeviceModeModel.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/models/persistence/NetworkPersistenceManager.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/components/utils/Linkifier.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/AutofillModel.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/network/NetworkWaterfallColumn.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/test/unittests/front_end/core/sdk/FrameManager_test.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/timeline/TimelineFlameChartView.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/network/NetworkLogViewColumns.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/host/UserMetrics.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/Toolbar.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/models/workspace/UISourceCode.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/application/DOMStorageModel.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/SplitWidget.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/LayerTreeBase.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/network/NetworkDataGridNode.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/profiler/HeapSnapshotGridNodes.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/components/quick_open/FilteredListWidget.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/timeline/TimelinePanel.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/application/ApplicationPanelSidebar.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/profiler/HeapSnapshotDataGrids.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/ViewRegistration.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/components/source_frame/SourceFrame.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/CSSMatchedStyles.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/common/Console.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/models/workspace_diff/WorkspaceDiff.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/NetworkRequest.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/recorder/extensions/ExtensionManager.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/models/issues_manager/Issue.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/core/sdk/PageResourceLoader.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/application/DatabaseQueryView.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/panels/layer_viewer/Layers3DView.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/front_end/ui/legacy/Context.ts
[modify] https://crrev.com/97f497e6be3a25ee3d489c31a183cafcb441ba15/test/unittests/front_end/core/common/Console_test.ts

[Empty comment from Monorail migration]

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/a1cae2d14f603e7867bafefc541cbab72e179f77

commit a1cae2d14f603e7867bafefc541cbab72e179f77
Author: Benedikt Meurer <bmeurer@chromium.org>
Date: Mon Jan 22 08:37:40 2024

[GN] Fix missing/incorrect build dependencies for `meta` targets.

This was noticed with https://crrev.com/c/5210758 (and caused that
CL to be reverted): The `meta` targets only transitively depend on
their imports (most of the time), which means that if one of their
imports change, but this change does not cause the `bundle` target
on which the `meta` target depends to change its output, ninja will
not rebuild the `meta` output. This causes issues specifically with
changing `enum` to `const enum`, as the *-meta.ts files don't get
rebuild correctly.

Fixed: chromium:1520414
Also-by: szuend@chromium.org
Bug: b:319814509, chromium:1172300, chromium:1167717
Change-Id: I436b349f3d99051848c7e7dbf63b35b5926d1448
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5222500
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>

[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/layer_viewer/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/profiler/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/settings/settings-meta.ts
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/linear_memory_inspector/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/screencast/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/entrypoints/main/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/protocol_monitor/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/performance_monitor/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/coverage/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/console/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/network/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/settings/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/js_profiler/js_profiler-meta.ts
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/models/persistence/persistence-meta.ts
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/application/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/media/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/network/network-meta.ts
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/ui/legacy/components/perf_ui/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/core/sdk/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/emulation/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/ui/legacy/components/quick_open/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/elements/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/settings/emulation/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/css_overview/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/ui/legacy/components/quick_open/quick_open-meta.ts
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/browser_debugger/browser_debugger-meta.ts
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/ui/legacy/components/source_frame/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/autofill/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/webauthn/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/sensors/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/ui/legacy/components/object_ui/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/changes/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/developer_resources/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/lighthouse/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/layers/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/web_audio/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/mobile_throttling/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/explain/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/accessibility/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/console/console-meta.ts
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/models/logs/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/timeline/timeline-meta.ts
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/issues/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/browser_debugger/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/security/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/recorder/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/console_counters/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/entrypoints/main/main-meta.ts
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/animation/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/timeline/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/entrypoints/inspector_main/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/sources/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/ui/legacy/components/object_ui/object_ui-meta.ts
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/panels/js_profiler/BUILD.gn
[modify] https://crrev.com/a1cae2d14f603e7867bafefc541cbab72e179f77/front_end/models/persistence/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/624312d849490fdc77222a3fed475acc7fbd3867

commit 624312d849490fdc77222a3fed475acc7fbd3867
Author: Benedikt Meurer <bmeurer@chromium.org>
Date: Mon Jan 22 09:24:09 2024

[cleanup] Change `enum` to `const enum` where possible.

Bug: b:319814509, chromium:1172300
Change-Id: Id68f35541bde3d11182c6bcfb0821094f6747989
Fixed: chromium:1167717
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5222920
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>

[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/explain/components/ConsoleInsight.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/components/inline_editor/SwatchPopoverHelper.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/application/SharedStorageItemsView.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/layer_viewer/TransformController.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/network/NetworkTimeCalculator.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/components/perf_ui/OverviewGrid.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/host/InspectorFrontendHostAPI.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/PreloadingModel.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/KeyboardShortcut.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/components/perf_ui/FilmStripView.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/timeline/TimelineUIUtils.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/FrameManager.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/elements/components/CSSPropertyIconResolver.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/layer_viewer/PaintProfilerView.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/components/inline_editor/FontEditor.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/ActionRegistration.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/common/Settings.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/Infobar.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/network/forward/UIFilter.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/Dialog.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/ResizerWidget.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/root/Runtime.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/TextPrompt.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/StorageKeyManager.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/protocol_monitor/ProtocolMonitor.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/common/SettingRegistration.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/models/autofill_manager/AutofillManager.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/application/preloading/components/UsedPreloadingView.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/components/color_picker/Spectrum.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/DebuggerModel.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/CPUProfilerModel.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/profiler/ProfileHeader.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/ServiceWorkerCacheModel.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/models/bindings/NetworkProject.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/models/extensions/ExtensionServer.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/sources/TabbedEditorContainer.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/web_audio/graph_visualizer/EdgeView.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/timeline/TimelineFlameChartDataProvider.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/DOMDebuggerModel.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/TargetManager.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/network/RequestTimingView.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/AccessibilityModel.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/IsolateManager.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/LogModel.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/HeapProfilerModel.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/layers/LayerTreeModel.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/models/issues_manager/CorsIssue.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/application/InterestGroupStorageModel.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/InspectorView.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/ServiceWorkerManager.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/profiler/ProfileLauncherView.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/application/DatabaseModel.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/layer_viewer/LayerDetailsView.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/network/ResourceWebSocketFrameView.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/components/perf_ui/FlameChart.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/sources/UISourceCodeFrame.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/models/workspace/FileManager.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/application/AppManifestView.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/ChildTargetManager.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/OverlayModel.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/timeline/TimelineLoader.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/application/SharedStorageModel.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/components/quick_open/CommandMenu.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/models/extensions/RecorderPluginManager.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/Target.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/ARIAUtils.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/components/inline_editor/BezierEditor.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/NetworkManager.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/components/data_grid/DataGrid.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/models/timeline_model/TimelineJSProfile.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/timeline/TimelineTreeView.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/ListModel.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/components/inline_editor/CSSShadowEditor.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/ContextMenu.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/Cookie.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/CPUThrottlingManager.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/sources/SourcesView.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/network/forward/UIRequestLocation.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/CSSModel.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/components/data_grid/ViewportDataGrid.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/models/emulation/DeviceModeModel.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/models/persistence/NetworkPersistenceManager.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/components/utils/Linkifier.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/AutofillModel.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/network/NetworkWaterfallColumn.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/test/unittests/front_end/core/sdk/FrameManager_test.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/timeline/TimelineFlameChartView.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/network/NetworkLogViewColumns.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/host/UserMetrics.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/models/workspace/UISourceCode.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/Toolbar.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/application/DOMStorageModel.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/SplitWidget.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/LayerTreeBase.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/network/NetworkDataGridNode.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/profiler/HeapSnapshotGridNodes.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/components/quick_open/FilteredListWidget.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/timeline/TimelinePanel.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/profiler/HeapSnapshotDataGrids.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/application/ApplicationPanelSidebar.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/ViewRegistration.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/components/source_frame/SourceFrame.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/CSSMatchedStyles.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/common/Console.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/models/workspace_diff/WorkspaceDiff.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/NetworkRequest.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/recorder/extensions/ExtensionManager.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/models/issues_manager/Issue.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/core/sdk/PageResourceLoader.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/application/DatabaseQueryView.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/test/unittests/front_end/core/common/Console_test.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/panels/layer_viewer/Layers3DView.ts
[modify] https://crrev.com/624312d849490fdc77222a3fed475acc7fbd3867/front_end/ui/legacy/Context.ts

The following revision refers to this bug:
  https://chromium.googlesource.com/devtools/devtools-frontend/+/30e0c342ff56d23b814737822c396a190a25d4e4

commit 30e0c342ff56d23b814737822c396a190a25d4e4
Author: Benedikt Meurer <bmeurer@chromium.org>
Date: Mon Jan 22 13:08:39 2024

Undo a few `const enum`s which are used by the legacy tests.

Following up on https://crrev.com/c/5222920 a few of these need to be
changed back, since they are used by the legacy test runners directly.

Bug: b:319814509, chromium:1172300, chromium:1167717
Change-Id: Ia67959d252aaf8476df7f05eb1382a239bc1559f
Cq-Include-Trybots: luci.devtools-frontend.try:devtools_frontend_linux_rel
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5224242
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>

[modify] https://crrev.com/30e0c342ff56d23b814737822c396a190a25d4e4/front_end/core/sdk/NetworkRequest.ts
[modify] https://crrev.com/30e0c342ff56d23b814737822c396a190a25d4e4/front_end/panels/profiler/HeapSnapshotGridNodes.ts
[modify] https://crrev.com/30e0c342ff56d23b814737822c396a190a25d4e4/front_end/panels/layers/LayerTreeModel.ts
[modify] https://crrev.com/30e0c342ff56d23b814737822c396a190a25d4e4/front_end/panels/profiler/HeapSnapshotDataGrids.ts

The following revision refers to this bug:
 

commit 5ba1cbe5326640bd72af58dc01a67f14dcc6420a
Author: Benedikt Meurer <bmeurer@google.com>
Date: Mon Jan 22 08:58:33 2024

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/7280f96d8edcbe34ae80367833aa74477917b0f2

commit 7280f96d8edcbe34ae80367833aa74477917b0f2
Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Date: Mon Jan 22 16:48:50 2024

Roll devtools-internal from 4e0cc80c5875 to 1fbe81558291 (3 revisions)

https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/4e0cc80c5875..1fbe81558291

Also rolling transitive DEPS:
  https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7f28655bc9e25129032852b084aa07a171d1cca2..698166359a5ecb172961eb5ea79a8469c06bf9be

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com,liviurau@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1167717,chromium:1172300
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Iedb9a6a5db583a33a6a50d00b6cdea6c959520ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5224369
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1250232}

[modify] https://crrev.com/7280f96d8edcbe34ae80367833aa74477917b0f2/third_party/devtools-frontend/src
[modify] https://crrev.com/7280f96d8edcbe34ae80367833aa74477917b0f2/third_party/devtools-frontend-internal
[modify] https://crrev.com/7280f96d8edcbe34ae80367833aa74477917b0f2/DEPS

This issue was migrated from crbug.com/chromium/1172300?no_tracker_redirect=1

[Monorail blocked-on: crbug.com/chromium/1520414]
[Monorail blocking: crbug.com/chromium/1151919, crbug.com/chromium/1158760]
[Monorail components added to Component Tags custom field.]

Project: devtools/devtools-frontend
Branch: main

commit 7966d4d8121c3042d8dd47730a7e43901f1d64bb
Author: Benedikt Meurer <bmeurer@chromium.org>
Date:   Thu Mar 14 07:47:33 2024

    [cleanup] Fix another bunch of pragmas disabling ESLint rules.
   
    Bug: b:323795352, b:40166562
    Change-Id: I78402d1611ba7a3ee278f1a709d69caf217c0a44
    Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5366408
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Reviewed-by: Simon Zünd <szuend@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>

M       front_end/entrypoints/formatter_worker/ESTreeWalker.ts
M       front_end/entrypoints/formatter_worker/FormatterWorker.ts
M       front_end/entrypoints/wasmparser_worker/WasmParserWorker.ts
M       front_end/models/bindings/DebuggerLanguagePlugins.ts
M       front_end/models/persistence/IsolatedFileSystem.ts
M       front_end/models/source_map_scopes/NamesResolver.ts
M       front_end/models/text_utils/TextUtils.ts
M       front_end/panels/console/ConsoleSidebar.ts
M       front_end/panels/console/ConsoleView.ts
M       front_end/panels/elements/PlatformFontsWidget.ts
M       front_end/panels/network/EventSourceMessagesView.ts
M       front_end/panels/network/NetworkLogViewColumns.ts
M       front_end/panels/network/NetworkTimeCalculator.ts
M       front_end/panels/profiler/LiveHeapProfileView.ts
M       front_end/panels/sources/SourcesPanel.ts
M       front_end/ui/legacy/Geometry.ts
M       front_end/ui/legacy/InplaceEditor.ts
M       front_end/ui/legacy/KeyboardShortcut.ts
M       front_end/ui/legacy/Toolbar.ts
M       front_end/ui/legacy/XElement.ts
M       front_end/ui/legacy/components/perf_ui/NetworkPriorities.ts
M       front_end/ui/legacy/components/source_frame/FontView.ts
M       front_end/ui/legacy/components/utils/Linkifier.ts
M       front_end/ui/legacy/utils/focus-changed.ts
M       front_end/ui/legacy/utils/measured-scrollbar-width.ts

https://chromium-review.googlesource.com/5366408

Project: devtools/devtools-frontend
Branch: main

commit 5ec8780a6c1ec233970557e7fb9daa237044a7fa
Author: Benedikt Meurer <bmeurer@chromium.org>
Date:   Fri Mar 15 10:31:16 2024

    [cleanup] Fix yet another set of eslint-disable pragmas.
   
    Bug: b:323795352, b:40166562
    Change-Id: Idcabed38270750bd67647f67ea3604dab0022226
    Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5372187
    Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
    Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>

M       front_end/core/protocol_client/InspectorBackend.ts
M       front_end/core/sdk/SourceMap.ts
M       front_end/panels/css_overview/CSSOverviewSidebarPanel.ts
M       front_end/panels/elements/ElementsPanel.ts
M       front_end/panels/network/NetworkWaterfallColumn.ts
M       front_end/panels/profiler/CPUProfileFlameChart.ts
M       front_end/panels/profiler/CPUProfileView.ts
M       front_end/panels/profiler/HeapProfileView.ts
M       front_end/panels/profiler/HeapSnapshotDataGrids.ts
M       front_end/panels/profiler/ProfileDataGrid.ts
M       front_end/panels/recorder/testing/RecorderHelpers.ts
M       front_end/panels/timeline/UIDevtoolsUtils.ts
M       front_end/ui/legacy/HistoryInput.ts
M       front_end/ui/legacy/SearchableView.ts

https://chromium-review.googlesource.com/5372187