Audit KMP libraries to ensure proper source splits [403616316]

Fixed

Feature Request

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Mar 14, 2025 09:41PM

Auditing our KMP libraries to make sure we like the platform specific vs common code.

Comments

ap...@google.com <ap...@google.com> #2Mar 14, 2025 10:48PM

At least make BottomSheet can be launched from local like AlertDialog. Right now, it's too hard to have multiple BottomSheets on one screen with BottomSheetScaffold.

ap...@google.com <ap...@google.com> #3Mar 17, 2025 10:35PM

(Maybe I don't where this lives in documentation) I'm looking for a similar behavior in SwiftUI where you can call `.sheet()` to invoke a bottom sheet at any point which overtakes the screen. This behaves just like `.alert` in SwiftUI.

ap...@google.com <ap...@google.com> #4Mar 25, 2025 03:55PM

Re comment#2 and comment#3 - this issue is only tracking the integration of bottom sheets into Navigation Compose so that you can use navController.navigate() to make a bottom sheet appear.

If you'd like to request changes to the ModalBottomSheetLayout and similar APIs, you'll want to file a separate request against Compose.

ap...@google.com <ap...@google.com> #5Mar 25, 2025 03:55PM

Fwiw this change does enable treating bottom sheets more like a window-esque thing, but they definitely won't be local.

ap...@google.com <ap...@google.com> #6Mar 25, 2025 10:51PM

Accompanist now supports this with Navigation Material.

ap...@google.com <ap...@google.com> #7Mar 27, 2025 11:09AM

This feature will be super useful!

ap...@google.com <ap...@google.com> #8Mar 27, 2025 11:09AM

Until this is implemented, could we at least get a warning notice in the documentation?

Not great to find out half way through a migration that this isn't possible.

Looks like we'll need to rework our app's navigation system (currently based on Fragments) just to support bottom sheets with a Bottom Navigation Bar at first glance. From the docs this wasn't clear.

ap...@google.com <ap...@google.com> #9Mar 27, 2025 11:09AM

Re comment#6 - can you explain what you are talking about? A fragment based navigation system is not going to be using Navigation Compose, which is what this issue is about and which is already available via Accompanist Navigation Material to unblock any migration to Navigation Compose from a fragment based system.

BottomSheetDialogFragment, which is what you'd use in a fragment based system, has been supported since dialog destinations were added in Navigation 2.1.0-alpha03 back in 2019.

ap...@google.com <ap...@google.com> #10Mar 27, 2025 11:09AM

Project: platform/frameworks/support
Branch: androidx-main

commit d65d5731e4f0dfe560b43eae886a4fabfa949b84
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Feb 21 02:14:42 2024

Add Navigation Material from Accompanists to androidx

Now that the needed compose material API are stable, we can move the
navigation material module from Accompanists to Androidx. This means we
will have a new compose-material-navigation module that provides support
for bottomsheets.

RelNote: "Providing new Compose Material Navigation module that adds
support for Bottomsheets in Compose Material."
Test: Added tests and samples
Bug: 180247978

Change-Id: Ia93eb757a32b04dac8ab3ebd2d73207a68635b80

A compose/material/material-navigation/api/current.txt
A compose/material/material-navigation/api/res-current.txt
A compose/material/material-navigation/api/restricted_current.txt
A compose/material/material-navigation/build.gradle
A compose/material/material-navigation/samples/build.gradle
A compose/material/material-navigation/samples/src/main/java/androidx/compose/material/navigation/samples/ComposeMaterialNavigationSamples.kt
A compose/material/material-navigation/src/androidTest/java/androidx/compose/material/navigation/BottomSheetNavigatorTest.kt
A compose/material/material-navigation/src/androidTest/java/androidx/compose/material/navigation/NavGraphBuilderTest.kt
A compose/material/material-navigation/src/androidTest/java/androidx/compose/material/navigation/SheetContentHostTest.kt
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/BottomSheet.kt
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/BottomSheetNavigator.kt
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/NavGraphBuilder.kt
A compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/SheetContentHost.kt
M compose/material/material/integration-tests/material-demos/build.gradle
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialDemos.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
M docs-tip-of-tree/build.gradle
M settings.gradle

https://android-review.googlesource.com/2953937

ap...@google.com <ap...@google.com> #11Mar 27, 2025 08:19PM

This has been added internally and will be released as part of the compose.material library, not navigation.

ap...@google.com <ap...@google.com> #12Mar 27, 2025 10:41PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.7.0-alpha04
androidx.compose.material:material-android:1.7.0-alpha04
androidx.compose.material:material-desktop:1.7.0-alpha04

ap...@google.com <ap...@google.com> #13Mar 27, 2025 11:05PM

Is there any fix planned for the material3 library for the above? We are currently using the material3 library in our project and would be helpful for us

ap...@google.com <ap...@google.com> #14Mar 28, 2025 02:21AM

I guess the release that addresses this is actually: androidx.compose.material:material-navigation:1.7.0-alpha04

As #13 said, we are missing this for Material3 bottom sheets. I see that there's another issue tracking that here: https://issuetracker.google.com/issues/328949006

ap...@google.com <ap...@google.com> #15Apr 1, 2025 11:07PM

Some guidance about usage would be very welcome. I get java.lang.IllegalStateException: Could not find Navigator with name "bottomSheet". You must call NavController.addNavigator() for each navigation type. crash and can't find any proper example of this new extension usage:

                Scaffold(
                    bottomBar = {...}
                      
                ) { innerPadding ->

                    NavHost(
                        navController,
                        startDestination = "explore_graph",
                        Modifier.fillMaxSize()
                    ) {
                        // nested graphs

                        bottomSheet("profile_bottom_sheet") { // CRASHES
                            Text("Bottom Sheet", Modifier.padding(16.dp))
                        }
                    }
                }
            }
        }
    }
}

I use androidx.compose.material:material-navigation:1.7.0-beta01, but my project is material3, could it be the reason?

ap...@google.com <ap...@google.com> #16Apr 2, 2025 09:59AM

Re comment#15 - Material Navigation works similarly to Accompanist, whose docs explain how to use it, including these two lines:

val bottomSheetNavigator = rememberBottomSheetNavigator()
val navController = rememberNavController(bottomSheetNavigator)

If you don't use those lines, you'd get that error message.

ap...@google.com <ap...@google.com> #17Apr 2, 2025 07:38PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3571367

Provide NavGraphImpl

Expand for full commit details

Provide NavGraphImpl 
 
Moving all common code to the common source set and allowing the 
specific platforms to use that source. 
 
RelNote: N/A 
Test: all tests pass 
Bug: 403616316 
Change-Id: If77617d32d274ea2f5f76107336293b562fda300

Files:

M navigation/navigation-common/bcv/native/current.txt
M navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavGraph.android.kt
A navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/internal/NavGraphImpl.kt
M navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavGraph.nonAndroid.kt

Hash: 162602b9a59566b2f341aea043de202b72fccbed
Date: Wed Apr 02 01:40:22 2025

ap...@google.com <ap...@google.com> #18Apr 2, 2025 07:39PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3565864

Provide NavDestinationImpl

Expand for full commit details

Provide NavDestinationImpl 
 
Moving all common code to the common source set and allowing the 
specific platforms to use that source. 
 
RelNote: N/A 
Test: all tests pass 
Bug: 403616316 
Change-Id: Ia7ea5ba90d98353147c710bc43780e120f608c84

Files:

M navigation/navigation-common/bcv/native/current.txt
M navigation/navigation-common/build.gradle
M navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavDestination.android.kt
M navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavDestination.kt
A navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/internal/NavDestinationImpl.kt
M navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavDestination.nonAndroid.kt
M navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/internal/NavContext.nonAndroid.kt

Hash: 3c59943b0caac826903b5cbc5d033b69ab0c3b5c
Date: Fri Mar 28 03:56:37 2025

ap...@google.com <ap...@google.com> #19Apr 2, 2025 09:06PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3562704

Move Navigator to common

Expand for full commit details

Move Navigator to common 
 
There is no platform specific code in Navigator. 
 
RelNote: N/A 
Test: all tests pass 
Bug: 403616316 
Change-Id: I28c3cec15401a458124ee8e209d88fb807435fa6

Files:

M navigation/navigation-common/bcv/native/current.txt
D navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/Navigator.android.kt
M navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/Navigator.kt
D navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/Navigator.nonAndroid.kt

Hash: 0ed3a0167619b3af5eabd1e167936ad6acd8dc46
Date: Wed Mar 26 19:59:07 2025

ap...@google.com <ap...@google.com> #20Apr 2, 2025 09:19PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3563405

Move noOpNavigator to common

Expand for full commit details

Move noOpNavigator to common 
 
Moving the implementation of the NoOpNavigator to the common source set 
and deleting the platform specific versions. 
 
RelNote: n/a 
Test: all tests pass 
Bug: 403616316 
Change-Id: I6cae3b46879633059eb50d768819cafb7de95cb6

Files:

D navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NoOpNavigator.android.kt
M navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NoOpNavigator.kt
D navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NoOpNavigator.nonAndroid.kt

Hash: fa6cc966c5fa9773f8c1a5610b0f9252f5fb18f4
Date: Thu Mar 27 00:16:35 2025

ap...@google.com <ap...@google.com> #21Apr 2, 2025 09:24PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3571431

Move ComposeNavGraphNavigator to common

Expand for full commit details

Move ComposeNavGraphNavigator to common 
 
Moving the implementation of the ComposeNavGraphNavigator to the common source set 
and deleting the platform specific versions. 
 
RelNote: n/a 
Test: all tests pass 
Bug: 403616316 
Change-Id: Id01ca3d5db0399c61cba4588f67668213cc5af4b

Files:

D navigation/navigation-compose/src/androidMain/kotlin/androidx/navigation/compose/ComposeNavGraphNavigator.android.kt
M navigation/navigation-compose/src/commonMain/kotlin/androidx/navigation/compose/ComposeNavGraphNavigator.kt
D navigation/navigation-compose/src/nonAndroidMain/kotlin/androidx/navigation/compose/ComposeNavGraphNavigator.nonAndroid.kt

Hash: d41eac2e40be89122d8204321e48e49cd1791f81
Date: Wed Apr 02 05:36:30 2025

ap...@google.com <ap...@google.com> #22Apr 2, 2025 10:51PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3572787

Move ClassType to common

Expand for full commit details

Move ClassType to common 
 
Even though ClassType is only used by tools, we should still provide an 
equal level of support on the Android side. Moving this to common allow 
us to keep this around for other Navigation implementations that are in 
Common. 
 
RelNote: N/A 
Test: ./gradlew checkApi 
Bug: 403616316 
Change-Id: I81efc0571178051fe9ef7ee00fab37378b271876

Files:

M navigation/navigation-common/bcv/native/current.txt
M navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavDestination.android.kt
M navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavDestination.kt
M navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavDestination.nonAndroid.kt

Hash: 58806860cf5cd0eb2ffd4a0886b56b2e48587aa8
Date: Wed Apr 02 21:42:19 2025

ap...@google.com <ap...@google.com> #23Apr 2, 2025 10:51PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3571430

Move NavGraphNavigator to common

Expand for full commit details

Move NavGraphNavigator to common 
 
Moving the implementation of the NavGraphNavigator to the common source set 
and deleting the platform specific versions. 
 
RelNote: n/a 
Test: all tests pass 
Bug: 403616316 
Change-Id: Id28c449a52d14e2df101db25ded4d8e428c37c80

Files:

M navigation/navigation-common/bcv/native/current.txt
D navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavGraphNavigator.android.kt
M navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavGraphNavigator.kt
D navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavGraphNavigator.nonAndroid.kt

Hash: a011b3bc23a80d510086701719d9a1ed88d7a15d
Date: Wed Apr 02 05:22:24 2025

ap...@google.com <ap...@google.com> #24Apr 3, 2025 03:08AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3571370

Move DialogNavigator to common

Expand for full commit details

Move DialogNavigator to common 
 
Moving the implementation of the DialogNavigator to the common source set 
and deleting the platform specific versions. 
 
RelNote: n/a 
Test: all tests pass 
Bug: 403616316 
Change-Id: Iaa801c14d263d7f372dabdc6e08c80d15926ed5b

Files:

D navigation/navigation-compose/src/androidMain/kotlin/androidx/navigation/compose/DialogNavigator.android.kt
M navigation/navigation-compose/src/commonMain/kotlin/androidx/navigation/compose/DialogNavigator.kt
D navigation/navigation-compose/src/nonAndroidMain/kotlin/androidx/navigation/compose/DialogNavigator.nonAndroid.kt

Hash: cc99a247b36eeacb363a87d379bea7da32a86d31
Date: Wed Apr 02 05:51:40 2025

ap...@google.com <ap...@google.com> #25Apr 3, 2025 03:09AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3571369

Move ComposeNavigator to common

Expand for full commit details

Move ComposeNavigator to common 
 
Moving the implementation of the ComposeNavigator to the common source set 
and deleting the platform specific versions. 
 
RelNote: n/a 
Test: all tests pass 
Bug: 403616316 
Change-Id: I76f5ed06735867797b42cc22ef1efcf072200f5f

Files:

D navigation/navigation-compose/src/androidMain/kotlin/androidx/navigation/compose/ComposeNavigator.android.kt
M navigation/navigation-compose/src/commonMain/kotlin/androidx/navigation/compose/ComposeNavigator.kt
D navigation/navigation-compose/src/nonAndroidMain/kotlin/androidx/navigation/compose/ComposeNavigator.nonAndroid.kt

Hash: 27fca1659aa6ae2f085c758cb939e5990e3d8fc2
Date: Wed Apr 02 05:43:44 2025

jb...@google.com <jb...@google.com> #26Apr 3, 2025 07:10PM

Marked as fixed.

This has been completed and will be available in Navigation 2.9.0-beta01.

Issue 403616316

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Mar 14, 2025 10:48PM

ap...@google.com <ap...@google.com> #3Mar 17, 2025 10:35PM

ap...@google.com <ap...@google.com> #4Mar 25, 2025 03:55PM

ap...@google.com <ap...@google.com> #5Mar 25, 2025 03:55PM

ap...@google.com <ap...@google.com> #6Mar 25, 2025 10:51PM

ap...@google.com <ap...@google.com> #7Mar 27, 2025 11:09AM

ap...@google.com <ap...@google.com> #8Mar 27, 2025 11:09AM

ap...@google.com <ap...@google.com> #9Mar 27, 2025 11:09AM

ap...@google.com <ap...@google.com> #10Mar 27, 2025 11:09AM

ap...@google.com <ap...@google.com> #11Mar 27, 2025 08:19PM

ap...@google.com <ap...@google.com> #12Mar 27, 2025 10:41PM

ap...@google.com <ap...@google.com> #13Mar 27, 2025 11:05PM

ap...@google.com <ap...@google.com> #14Mar 28, 2025 02:21AM

ap...@google.com <ap...@google.com> #15Apr 1, 2025 11:07PM

ap...@google.com <ap...@google.com> #16Apr 2, 2025 09:59AM

ap...@google.com <ap...@google.com> #17Apr 2, 2025 07:38PM

ap...@google.com <ap...@google.com> #18Apr 2, 2025 07:39PM

ap...@google.com <ap...@google.com> #19Apr 2, 2025 09:06PM

ap...@google.com <ap...@google.com> #20Apr 2, 2025 09:19PM

ap...@google.com <ap...@google.com> #21Apr 2, 2025 09:24PM

ap...@google.com <ap...@google.com> #22Apr 2, 2025 10:51PM

ap...@google.com <ap...@google.com> #23Apr 2, 2025 10:51PM

ap...@google.com <ap...@google.com> #24Apr 3, 2025 03:08AM

ap...@google.com <ap...@google.com> #25Apr 3, 2025 03:09AM

jb...@google.com <jb...@google.com> #26Apr 3, 2025 07:10PM

Add comment

Issue metadata