Fixed
Status Update
Comments
au...@google.com <au...@google.com> #2
I'm pretty far from being a C++ expert, but I think this may be due to holding a reference to the Config
beyond it's lifetime?
See StartDiscovery()
:
void StartDiscovery() {
...
g_state->task_runner->PostTask([]() {
// optional<Config> created here
auto config = GetConfigForAllInterfaces();
if (!config) {
return;
}
// long-lived reference of config given to OpenScreen
g_state->service = discovery::CreateDnsSdService(g_state->task_runner.get(),
g_state->reporting_client.get(), *config);
for (int i = 0; i < kNumADBDNSServices; ++i) {
auto receiver = std::make_unique<ServiceReceiver>(
g_state->service.get(), kADBDNSServices[i], OnServiceReceiverResult);
receiver->StartDiscovery();
...
}
...
// config destructed here
});
}
pr...@google.com <pr...@google.com>
au...@google.com <au...@google.com> #3
A word on impact:
- We rely on WiFi debugging because we use the USB port for additional devices.
- This has made WiFi based debugging unreliable and painful to use because when ADB crashes the connection is lost and is not automatically re-created. Often it can required manually toggling WiFi debugging on the tablet.
Description
Release a stable version of the benchmark baseline gradle plugin that fixes Gradle isolated project feature.
1.3.3 was released on 10/16/2024 and doesn't have the fixes. 1.4.0-* is still in alpha. Given 1.4.0 is taking a while, we should release a bugfix release 1.3.4 that has the fixes.
A starting point is r.android.com/3548580