Fixed
Status Update
Comments
ro...@google.com <ro...@google.com>
dx...@google.com <dx...@google.com> #2
Tested the issue on chrome version #127.0.6533.120 using Mac 14.6.1 as per comment#1
Steps to reproduce:
---------------------------
1.Launched chrome browser
2.Opened given link:http://44.216.23.255 and seen "open" and onopen event got fired
3.Turn off the wifi and observed "offline" event fired
Attaching screencast for reference
Reporter@ Could you please review the attached screencast and let us know if anything being missed here also please confirm if point:3 is the issue you are pointing to? please provide screencast of actual and expected behaviour for better understanding and further triaging the issue.
Note: Requesting you to copy the entire content of "chrome://version/?show-variations-cmd" details and please copy paste the info in .txt file format.
Thanks..!!
Steps to reproduce:
---------------------------
1.Launched chrome browser
2.Opened given link:
3.Turn off the wifi and observed "offline" event fired
Attaching screencast for reference
Reporter@ Could you please review the attached screencast and let us know if anything being missed here also please confirm if point:3 is the issue you are pointing to? please provide screencast of actual and expected behaviour for better understanding and further triaging the issue.
Note: Requesting you to copy the entire content of "chrome://version/?show-variations-cmd" details and please copy paste the info in .txt file format.
Thanks..!!
ro...@google.com <ro...@google.com>
ap...@google.com <ap...@google.com> #3
Your screencast confirms the incorrect behavior.
I have attached a screencast that shows the expected behavior.
Of course, chrome doesn't behave in the expected way anymore, so my screencast uses Safari to show the correct behavior. When working correctly, the browser emits "close" and "error" events when the websocket is no longer connected (such as when wifi is disconnected). You'll notice chrome does not do this in your screencast, but Safari does do it in my screencast. Chrome used to emit the "close" and "error" events but it doesn't anymore. I would like Chrome to be fixed so it behaves correctly. Chrome should follow the websocket spec and emit the "close" and "error" events when a websocket is closed.
I have attached a screencast that shows the expected behavior.
Of course, chrome doesn't behave in the expected way anymore, so my screencast uses Safari to show the correct behavior. When working correctly, the browser emits "close" and "error" events when the websocket is no longer connected (such as when wifi is disconnected). You'll notice chrome does not do this in your screencast, but Safari does do it in my screencast. Chrome used to emit the "close" and "error" events but it doesn't anymore. I would like Chrome to be fixed so it behaves correctly. Chrome should follow the websocket spec and emit the "close" and "error" events when a websocket is closed.
Description
Remove SupportLibWebViewChromiumFactory.java .
DEV_SUFFIX
fromPAYMENT_REQUEST
inRemove
@RestrictTo(RestrictTo.Scope.LIBRARY_GROUP)
from:a. PaymentRequest methods in WebSettingsCompat.java .
b. WebViewFeature.PAYMENT_REQUEST .
Run
./gradlew updateApi
before uploading the patch for review.Ask for review from a WebView owner and request an API review (peconn@ or aurimas@).