Obsolete
Status Update
Comments
nt...@chromium.org <nt...@chromium.org>
nt...@chromium.org <nt...@chromium.org> #2
Basic implementation here (https://chromium-review.googlesource.com/c/chromium/src/+/1594279 ), although it's probably worth considering if we can mitigate the cons noted above.
bu...@chops-service-accounts.iam.gserviceaccount.com <bu...@chops-service-accounts.iam.gserviceaccount.com> #3
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/3d5958c033a2703849dcbe86422e2b4edca99a10
commit 3d5958c033a2703849dcbe86422e2b4edca99a10
Author: Nate Fischer <ntfschr@chromium.org>
Date: Wed May 15 20:33:32 2019
AW docs: WebView shell doesn't support flags
WebView shell does not support flags. It can be confusing why this is
the case, so this updates docs to mention this explicitly and link to
the relevant crbug.
Bug: 918221, 959425
Test: tools/md_browser/md_browser.py
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I905a254bbb58bdf5b5fe4c29065de5d74653a843
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/1612126
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660101}
[modify]https://crrev.com/3d5958c033a2703849dcbe86422e2b4edca99a10/android_webview/docs/webview-shell.md
commit 3d5958c033a2703849dcbe86422e2b4edca99a10
Author: Nate Fischer <ntfschr@chromium.org>
Date: Wed May 15 20:33:32 2019
AW docs: WebView shell doesn't support flags
WebView shell does not support flags. It can be confusing why this is
the case, so this updates docs to mention this explicitly and link to
the relevant crbug.
Bug: 918221, 959425
Test: tools/md_browser/md_browser.py
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I905a254bbb58bdf5b5fe4c29065de5d74653a843
Reviewed-on:
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#660101}
[modify]
[Deleted User] <[Deleted User]> #5
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.
Sorry for the inconvenience if the bug really should have been left as Available.
For more details visithttps://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Sorry for the inconvenience if the bug really should have been left as Available.
For more details visit
nt...@chromium.org <nt...@chromium.org> #6
[Empty comment from Monorail migration]
ma...@gmail.com <ma...@gmail.com> #7
[Comment Deleted]
ka...@gmail.com <ka...@gmail.com> #8
[Comment Deleted]
mi...@gmail.com <mi...@gmail.com> #9
[Comment Deleted]
mi...@gmail.com <mi...@gmail.com> #10
[Comment Deleted]
ro...@gmail.com <ro...@gmail.com> #11
[Comment Deleted]
an...@gmail.com <an...@gmail.com> #12
[Comment Deleted]
is...@google.com <is...@google.com> #13
This issue was migrated from crbug.com/chromium/959425?no_tracker_redirect=1
[Monorail blocking:crbug.com/chromium/893766 ]
[Monorail components added to Component Tags custom field.]
[Monorail blocking:
[Monorail components added to Component Tags custom field.]
[Deleted User] <[Deleted User]> #14 Restricted
Restricted
nt...@chromium.org <nt...@chromium.org> #15
Not worth pursuing this at this point. Closing this old bug.
m8...@gmail.com <m8...@gmail.com> #16
Comment has been deleted.
lm...@gmail.com <lm...@gmail.com> #17
Excelente
Description
Pros:
* `out/Default/bin/system_webview_shell_apk --args='--foo --bar' launch <URL>` will do something meaningful rather than crashing
Cons:
* users might be surprised this has side-effects for other apps, although that's already the status quo with `system_webview_apk argv --args='--foo --bar'`. IMO the right fix would be restore the old flag state after launching the app (do we only read the file once during startup?)
* if users write to the flag file with `system_webview_apk argv --args='--foo --bar'` and *then* call `system_webview_shell_apk launch` (with no args), they might be surprised the latter call removes previously-written CLI flags [1]. This might be mitigated by letting "--args" append to existing flags, and restoring the old flags after startup.
I think, if there's a known-to-be-safe time after startup when we can restore previous flags, I think the pros outweigh the cons. Otherwise, maybe we should just document the current behavior is WAI for these reasons. But, the known-to-be-safe time would have to work for Chrome/WebView/ContentShell/etc.
[1]