Generic return types [62103620]

Verified

Bug

android_arch-1.0.0-alpha3

Status Update

No update yet.

Description

ze...@gmail.com

created issue #1

May 25, 2017 10:20PM

Component used: Room
Version used: 1.0.0.aplha1
Devices/Android versions reproduced on: All

- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).

I would be cool if return types could be generic or even an Object and the mapping could be done on the output. That way i do not need to create a new Dao for every model in my project.

Comments

yb...@google.com <yb...@google.com> #2May 26, 2017 04:22AM

Assigned to yb...@google.com.

since these are in public API (:/) we need to do this in 1.2

ze...@gmail.com <ze...@gmail.com> #3May 26, 2017 03:10PM

since it is already marked as deprecated, we can probably do it by now.

yb...@google.com <yb...@google.com> Jun 8, 2017 04:40PM

Marked as fixed.

yb...@google.com <yb...@google.com> Jun 15, 2017 10:00PM

Verified by yb...@google.com.

bs...@gmail.com <bs...@gmail.com> #4Aug 8, 2017 01:52PM

Opening diff shortly

ze...@gmail.com <ze...@gmail.com> #5Aug 8, 2017 02:02PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

ze...@gmail.com <ze...@gmail.com> #6Aug 8, 2017 02:03PM

Or Better with dynamic queries

@Query(query)
List<T> getAll(String query);
or
@Query(query)
Flowable<List<User>> getAll(Query query);

bs...@gmail.com <bs...@gmail.com> #7Aug 8, 2017 09:49PM

The "Dao" below works. I can have other Dao heroing the GenericDao.

@Dao
public interface GenericDao<T> {
@Insert(onConflict = OnConflictStrategy.REPLACE)
void insert(T... entity);

@Update
void update(T... entity);

@Delete
void delete(T... entity);
}

However, GenericDao can not be included in my Database class