Verified
Status Update
No update yet.
Comments
yb...@google.com
yb...@google.com
zt...@gmail.com
since these are in public API (:/) we need to do this in 1.2
yb...@google.com
since it is already marked as deprecated, we can probably do it by now.
ky...@gmail.com
Opening diff shortly
zt...@gmail.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
pm...@google.com
+1 to Flowable emitting an empty List
+1 to Kyle's point, if you run a query for a single element and it doesn't come back Maybe seems like the most appropriate response (https://github.com/ReactiveX/RxJava/wiki/What's-different-in-2.0#maybe ). As the onComplete represents a 0 (from the options of 0 or 1). I think for events where you want a Single responses this is a solid API choice.
As for the Infinite stream of a single objects, I agree with Zak's approach.
+1 to Kyle's point, if you run a query for a single element and it doesn't come back Maybe seems like the most appropriate response (
As for the Infinite stream of a single objects, I agree with Zak's approach.
yb...@google.com
shipped maybe and single in alpha 5.
Zak, for a Flowable<Optional<T>> solution, i think we'll wait for now mostly because it can easily be solved by Flowable<List<T>>.
We have some plans to allow compile time plugins, which will probably be the right way to add such customizations. (post 1.0).
Zak, for a Flowable<Optional<T>> solution, i think we'll wait for now mostly because it can easily be solved by Flowable<List<T>>.
We have some plans to allow compile time plugins, which will probably be the right way to add such customizations. (post 1.0).
Description
Version used: 1.0.0-alpha1
There should be support for the Maybe reactive base type for one off queries that do not care about live updates. In the current RxRoom implementation, queries that do not return a result are filtered out before they get to the downstream subscribers. Adding support for Maybe would allow us to query for a query that may or may not return a result, and act accordingly with our normal RxJava operators.
See: