LiveDataReactiveStreams.fromPublisher() never unsubscribes from the source publisher [62609183]

Fixed

Bug

Status Update

No update yet.

Description

bo...@gmail.com

created issue #1

Jun 14, 2017 08:35AM

Component used: LiveData + ReactiveStreams artifact
Version used: 1.0.0-alpha2

Looking at the source of LiveDataReactiveStreams.fromPublisher() the Publisher that is passed in is never unsubscribed. This means that the underlying Publisher has no opportunity for releasing resources and stopping work which may result in memory leaks and other bugs. I would have expected the Publisher to be unsubscribed in LiveData onInActive() callback and subscribed in onActive() as this signals that there are consumers interested in the LiveData.

Alternatively I think the publisher should at least be unsubscribed then the associated LifecycleOwner goes away (when the Lifecycle moves to destroyed).

Comments

yb...@google.com <yb...@google.com> Jun 14, 2017 09:32PM

Assigned to jn...@google.com.

ne...@gmail.com <ne...@gmail.com> #2Aug 5, 2017 01:08PM

since these are in public API (:/) we need to do this in 1.2

fl...@google.com <fl...@google.com> Sep 15, 2017 05:03PM

Reassigned to fl...@google.com.

fl...@google.com <fl...@google.com> Sep 29, 2017 02:24PM

Accepted by fl...@google.com.

fl...@google.com <fl...@google.com> #3Sep 29, 2017 04:44PM

since it is already marked as deprecated, we can probably do it by now.

bo...@gmail.com <bo...@gmail.com> #4Sep 29, 2017 04:57PM

Opening diff shortly

ne...@gmail.com <ne...@gmail.com> #5Sep 29, 2017 07:33PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

bo...@gmail.com <bo...@gmail.com> #6Oct 1, 2017 06:06PM

One thing that should be considered is completion of the source publisher. If it has completed, then there's no need to resubscribe again; the latest value can be cached forever in the LiveData in that case. This prevents duplicate events.

yb...@google.com <yb...@google.com> #7Oct 4, 2017 08:32PM

Marked as fixed.

we've changed the default behavior to unsub and also documented it throughly.