OnLifecycleEvent annotated methods are not called in child classes [63474615]

Fixed

Bug

Status Update

No update yet.

Description

bo...@gmail.com

created issue #1

Jul 8, 2017 05:13PM

Component used: Lifecycle
Version used: 1.0.0-alpha3
Devices/Android versions reproduced on: N/A

I am trying to have a base class that has @OnLifecycleEvent annotated methods, and a child class that also has them. When I do that, only the base class methods get called.

Is this a known restriction? If yes, I couldn't find it documented anywhere.

Comments

bo...@gmail.com <bo...@gmail.com> #2Jul 8, 2017 05:14PM

since these are in public API (:/) we need to do this in 1.2

bo...@gmail.com <bo...@gmail.com> #3Jul 8, 2017 05:26PM

since it is already marked as deprecated, we can probably do it by now.

yb...@google.com <yb...@google.com> Jul 9, 2017 08:03PM

Assigned to se...@google.com.

se...@google.com <se...@google.com> #4Jul 11, 2017 12:57AM

Opening diff shortly

bo...@gmail.com <bo...@gmail.com> #5Jul 11, 2017 05:51AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

bo...@gmail.com <bo...@gmail.com> #6Jul 14, 2017 08:41PM

Indeed I can reproduce the issue with a simple project (see attachment) where the base class and the child class are in 2 modules. If the annotationProcessor is commented, it works as expected. If it's enabled, only the child class method is called.

Test4.zip

896 KB

Download

se...@google.com <se...@google.com> #7Jul 14, 2017 10:36PM

Thank you, now I can reproduce it, looks we doesn't correctly different modules in our annotation processor.

yb...@google.com <yb...@google.com> Oct 19, 2017 01:03AM

Marked as fixed.