IssueTracker

Is hyphenation done in line layout? Anyone know about our hyphenation dictionary?

[Monorail components: -Blink Blink>Layout]

[Empty comment from Monorail migration]

Thanks for filing the issue!

@Reporter: Could you please share a sample test file satisfying the conditions mentioned in https://crbug.com/chromium/973102#c0, which helps us to triage this further in a better way.

On which platform is this? The dictionaries are OS specific.

It's simple, create an HTML file that contains these words and change its content so that the words are at the end of the line. As I said, you'll have to play depending on your screen size and everything, I cannot provide a universal test case. You're probably used to doing this, I only do this on my local computer which is inaccessible to you.

My OS is Android 7.1.1 on a Sony Xperia Z5 Compact, but the issue has been reported to me from a user of Samsung Internet 9.2.10.15 on some Samsung device. So it does affect multiple devices.

Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Unable to reproduce.

Still occurs here. What did you  try to reproduce as you failed? I just opened my website in Chrome on Windows (latest stable) and I can see this.

PS: Chrome on Windows now supports hyphenation. And it's just as broken as it was before on other platforms when I initially reported this.

Reporter, it would be greatly help us to analyze if you could share any reproducing URLs for our investigations.

I guess the page reporter is seeing has lang="en" or lang="en-uk".

Tests: https://jsbin.com/boxamav/edit?html,output
(may need to shorten "12345" or make it longer depends on fonts)

* Win/Linux/ChromeOS Chrome hyphenates at:
  - "start-up" for "en-us"
  - "star-tup" for "en-uk" and "en"
* Mac Chrome and Safari hyphenates at:
  - "start-up" for "en-us" and "en"
  - "star-tup" for "en-uk"
* Firefox doesn't hyphenate at either point.

Two points need investigations:
* I'm not sure if "star-tup" is the correct hyphenation for UK English.
* When the lang is "en", should it be "en-us" or "en-uk"? Currently, Chrome matches Android behavior, but from the tests, Safari seems to use "en-us" for "en".

[Monorail components: -Blink>Layout Blink>Layout>Inline]

My page lang value is set to "en". Does "en-uk" exist after all? AFAIK the ISO country code for UK is still "GB". At least all browsers offer me to send "en-GB" in the accepted languages header.

Anyway, you can see the effect here: https://ygoe.de/en

Both words appear in the content. Please note that hyphenation is only active for page widths below 420 pixels. You may also need to edit the content to place the words at a line end (open developer tools, find the parent <p> element and add the contenteditable attribute, then edit the text on the page before each word to place it where you want).

Thanks, sorry, you're right, not "en-uk", but "en-gb".

Confirmed a few things:
1. "star-tup" is not a correct hyphenation even for "en-gb".

2. Android, and Chrome Android/Win/Linux/ChromeOS uses "en-GB" when "en" is set.
https://android.googlesource.com/platform/frameworks/base/+/master/core/jni/android_text_Hyphenator.cpp#143
From the test result, it looks like macOS uses "en-US" when "en" is set.
The "hyphenator.js" uses "en-us" when "en" is set.
https://github.com/mnater/Hyphenator/blob/master/Hyphenator.js#L93

3. Our "en-gb" dictionary is up-to-date with the TeX hyphenation dictionary.
https://github.com/hyphenation/tex-hyphen/tree/master/misc

4. The "en-gb" dictionary has the "r1tu" entry, meaning to hyphenate as "r-tu". This entry does not exist in the "en-us" dictionary. The "hyphenator.js" has this entry too.
https://github.com/mnater/Hyphenator/blob/master/patterns/en-gb.js

5. Firefox and hyphenator.js does not hyphenate "startup" at all.

I'm still not sure whether the issue is in the "en-gb" TeX dictionary (reproduces on macOS too) or in the hyphenator code (not reproducible on Firefox and hyphenator.js,) and also not sure whether to map "en" to "en-gb" or to "en-us".

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/a2c814f8d7db0008fc653d99532e5e7b8ff64732

commit a2c814f8d7db0008fc653d99532e5e7b8ff64732
Author: Koji Ishii <kojii@chromium.org>
Date: Tue Jun 22 01:06:11 2021

Change "en" hyphenation to use "en-us" instead of "en-gb"

When the specified langauge is "en", this patch changes to use
the "en-us" hyphenation dictionary instead of the "en-gb".

It looks like this behavior matches the other browsers.

Android maps "en" to "en-gb", but because Android takes the
language from the system, it is usually more specific (i.e.,
"en-us" or "en-gb", not "en".) On the other hand, CSS
prohibits using the system language <crbug.com/676270> that
the use of "en" is more common.

Bug: 973102
Change-Id: I7547725b9d30fc137f987fb200fa2e4b699d2c21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2975039
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#894484}

[modify] https://crrev.com/a2c814f8d7db0008fc653d99532e5e7b8ff64732/third_party/blink/renderer/platform/text/hyphenation/hyphenation_minikin.cc
[modify] https://crrev.com/a2c814f8d7db0008fc653d99532e5e7b8ff64732/third_party/blink/renderer/platform/text/hyphenation_test.cc