Room: Only field/method names are evaluated for finding a proper Room field getter, ignoring getter return type, so Room can find a getter "appropriate" even though it's return type doesn't match field [63733651]

Can't Repro

Bug

Status Update

No update yet.

Description

ga...@gmail.com

created issue #1

Jul 16, 2017 01:10PM

Only field/method names are evaluated for finding a proper Room field getter, ignoring getter return type, so Room can find a getter "appropriate" even though it's return type doesn't match the field type, and it doesn't throw any build time error.

Look at screenshot!

Component used: Room
Version used: 1.0.0-alpha4
Devices/Android versions reproduced on: not relevant

bug.jpg

76 KB

View

Download

Comments

ga...@gmail.com <ga...@gmail.com> #2Jul 16, 2017 09:19PM

But now it comes to mind, shouldn't you also be checking exactly which field is being returned? So getter shouldn't be valid even if the name and return type seem right, if field that is being returned isn't also the one we're finding a getter for..

yb...@google.com <yb...@google.com> #3Jul 17, 2017 04:19PM

Assigned to yb...@google.com.

we cannot check exactly which field is returned without using private annotation processor calls.
we'll fix this type check though.

yb...@google.com <yb...@google.com> Sep 15, 2017 12:20AM

Reassigned to fl...@google.com.

fl...@google.com <fl...@google.com> #4Sep 15, 2017 12:23PM

Status: Won't Fix (Not Reproducible)

Can't reproduce it. Added another unit test to cover the relation field getter type case.

Issue 63733651

Description

Issue summary

Comments

ga...@gmail.com <ga...@gmail.com> #2Jul 16, 2017 09:19PM

yb...@google.com <yb...@google.com> #3Jul 17, 2017 04:19PM

yb...@google.com <yb...@google.com> Sep 15, 2017 12:20AM

fl...@google.com <fl...@google.com> #4Sep 15, 2017 12:23PM

Add comment

Issue metadata