java.io.IOException: Failed to generate v1 signature when assets contain "Icon\r" (Mac filesystem icon) files [63885809]

Infeasible

Bug

[AOSP] mac

release notes

Migrated-Tools-Gradle

Status Update

No update yet.

Description

ms...@gmail.com

created issue #1

Jul 20, 2017 02:55PM

I get this error sometimes when I switch my app branches! and it solve randomly. I am not sure if it is a bug in AS or my system but I am sure my code is fine!

I also tried deleting my debug.keystore, restarting AS and system(!!!) but it didn't solved.

Here is a full log from gradle:

----------------------------------------------------------------------

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':chris-app:packageDemoDebug'.
> java.io.IOException: Failed to generate v1 signature

* Try:
Run with --info or --debug option to get more log output.

* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':chris-app:packageDemoDebug'.
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:100)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:70)
at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:64)
at org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54)
at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)
at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:88)
at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:52)
at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:52)
at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)
at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)
at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)
at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.run(DefaultTaskGraphExecuter.java:243)
at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:336)
at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:328)
at org.gradle.internal.progress.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:197)
at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:107)
at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:236)
at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:225)
at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.processTask(DefaultTaskPlanExecutor.java:124)
at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.access$200(DefaultTaskPlanExecutor.java:80)
at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker$1.execute(DefaultTaskPlanExecutor.java:105)
at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker$1.execute(DefaultTaskPlanExecutor.java:99)
at org.gradle.execution.taskgraph.DefaultTaskExecutionPlan.execute(DefaultTaskExecutionPlan.java:625)
at org.gradle.execution.taskgraph.DefaultTaskExecutionPlan.executeWithTask(DefaultTaskExecutionPlan.java:580)
at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.run(DefaultTaskPlanExecutor.java:99)
at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46)
at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:55)
Caused by: org.gradle.tooling.BuildException: java.io.IOException: Failed to generate v1 signature
at com.android.build.gradle.internal.scope.OutputScope.lambda$parallelForEachOutput$10(OutputScope.java:240)
at com.android.build.gradle.internal.scope.OutputScope.parallelForEachOutput(OutputScope.java:235)
at com.android.build.gradle.internal.scope.OutputScope.parallelForEachOutput(OutputScope.java:196)
at com.android.build.gradle.internal.scope.OutputScope.parallelForEachOutput(OutputScope.java:180)
at com.android.build.gradle.tasks.PackageAndroidArtifact.doFullTaskAction(PackageAndroidArtifact.java:466)
at com.android.build.gradle.internal.tasks.IncrementalTask.taskAction(IncrementalTask.java:80)
at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)
at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$IncrementalTaskAction.doExecute(DefaultTaskClassInfoStore.java:168)
at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:134)
at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:121)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$1.run(ExecuteActionsTaskExecuter.java:122)
at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:336)
at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:328)
at org.gradle.internal.progress.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:197)
at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:107)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:111)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:92)
... 27 more
Caused by: java.lang.RuntimeException: java.io.IOException: Failed to generate v1 signature
Caused by: java.io.IOException: Failed to generate v1 signature
at com.android.apkzlib.sign.SigningExtension.onOutputZipReadyForUpdate(SigningExtension.java:297)
at com.android.apkzlib.sign.SigningExtension.access$200(SigningExtension.java:55)
at com.android.apkzlib.sign.SigningExtension$1.lambda$beforeUpdate$2(SigningExtension.java:175)
at com.android.apkzlib.zip.ZFile.notify(ZFile.java:2099)
at com.android.apkzlib.zip.ZFile.update(ZFile.java:871)
at com.android.apkzlib.zip.ZFile.close(ZFile.java:1161)
at com.android.apkzlib.zfile.ApkZFileCreator.close(ApkZFileCreator.java:172)
at com.google.common.io.Closer.close(Closer.java:216)
at com.android.builder.internal.packaging.IncrementalPackager.close(IncrementalPackager.java:332)
at com.android.build.gradle.tasks.PackageAndroidArtifact.doTask(PackageAndroidArtifact.java:698)
at com.android.build.gradle.tasks.PackageAndroidArtifact.splitFullAction(PackageAndroidArtifact.java:520)
at com.android.build.gradle.internal.scope.OutputScope.lambda$parallelForEachOutput$6(OutputScope.java:185)
at com.android.build.gradle.internal.scope.OutputScope.lambda$parallelForEachOutput$7(OutputScope.java:202)
at com.android.build.gradle.internal.scope.OutputScope.lambda$null$8(OutputScope.java:224)
"
at com.android.apksig.internal.apk.v1.V1SchemeSigner.checkEntryNameValid(V1SchemeSigner.java:406)
at com.android.apksig.internal.apk.v1.V1SchemeSigner.generateManifestFile(V1SchemeSigner.java:373)
at com.android.apksig.internal.apk.v1.V1SchemeSigner.sign(V1SchemeSigner.java:253)
at com.android.apksig.DefaultApkSignerEngine.outputJarEntries(DefaultApkSignerEngine.java:372)
at com.android.apkzlib.sign.SigningExtension.onOutputZipReadyForUpdate(SigningExtension.java:295)
... 13 more

BUILD FAILED in 2m 49s

------------------------------------------------------------

Build: 3.0 Canary 7, AI-171.4182969, 201707142150,

AI-171.4182969, JRE 1.8.0_152-release-884-b01x64 JetBrains s.r.o, OS Mac OS X(x86_64) v10.12.6 unknown, screens 1920x1080, 1280x800; Retina

IMPORTANT: Please read

https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Comments

uc...@google.com <uc...@google.com> #2Jul 20, 2017 10:16PM

Thanks for the feedback. To help us troubleshoot this issue further, we will need more information. Please share detailed reproduction steps and as much as possible of the following information when it applies if you haven’t already:

1. Android Studio version and OS type and version
2. Screenshots or videos of the issue
3. idea.log file (select Help > Show Log in Finder / Explorer)
4. Thread dumps if the issue is a freezing or non-responding UI.

For more information on what’s needed and how to obtain this information please read the guide at

https://developer.android.com/studio/report-bugs#studio-bugs

ms...@gmail.com <ms...@gmail.com> #3Jul 26, 2017 05:42AM

1) See in my original post

2) See attached screen recording
Opened a scratch file and tried to type an "@" symbol. You can see that in the keyboard viewer

Btw this issue only occurs in text editor

3) See attached log file

How to reproduce:
- Open any project
- Open a source file
- Try to type "@"-Symbol

4) There is no freeze or stuck UI/process in AS

ms...@gmail.com <ms...@gmail.com> #4Jul 26, 2017 08:03AM

I found out that if you remove the following shortcut, it works again. Does it make sense to set a different shortcut ?

ey...@gmail.com <ey...@gmail.com> #5Jul 28, 2017 07:05AM

I can't repro on Linux. This might be a general IntelliJ shortcut system issue.

The shortcut mentioned in comment #4 is Option-L, Option-F which isn't anywhere near @. Additionally, the shortcut is only supposed to active inside the Logcat tool window.

That said, I suppose I could change the shortcut to something else on Mac's. I don't have a Mac so I can't test this nor can I check if any shortcut I choose will be in conflict with something.

ey...@gmail.com <ey...@gmail.com> #6Jul 28, 2017 07:07AM

Adarsh, please advise

ms...@gmail.com <ms...@gmail.com> #7Aug 2, 2017 09:31AM

The video shows that a non-English keyboard layout is being used (I believe it's German given the autocompletions). This relocates the @ symbol onto the L key such that ⌥L will type an @.

Given how macOS allows typing special characters, I assume this is a Mac-only issue. I also suspect any other keyboard shortcuts that start with ⌥ will produce the same behavior.

EDIT: I think the underlying issue is this one.

je...@google.com <je...@google.com> #8Aug 2, 2017 08:02PM

Assigned to kl...@google.com.

Hmm, so I'm looking for other Alt- bindings on my Linux and I can see a few:

Alt-Q -> Context info
Alt-J -> Add selection for Next Occurrence
Alt-O -> Export Results
Alt-M -> Amend Commit

Does this happen for these too? If not, what are these actions bound to on Mac?

kl...@google.com <kl...@google.com> #9Aug 2, 2017 09:13PM

Reassigned to je...@google.com.

I'm hesitant to change the default binding because it might result in conflicting with some other layout. IntelliJ and Android Studio is currently not localized and is offered only in English. HAving said that, it seems like the clear workaround is to either remove the existing key binding or remap to something else that works.

je...@google.com <je...@google.com> #10Aug 7, 2017 04:20PM

Reassigned to hu...@google.com.

@amy, do you think this is worth documenting somewhere?

hu...@google.com <hu...@google.com> #11Aug 8, 2017 01:04AM

Yes, I can document this on the logcat and known issues pages. Will am to send a CL by the end of next week. Thanks for looping me in!

ey...@gmail.com <ey...@gmail.com> #12Aug 8, 2017 02:52AM

This issue is also in Electric Eel, please change that for mac. It is stopping me from coding annotation such as compose code, very annoying. If not, make the short cut deactivable.

Please see issue 265528494. This shall be a p1 issue, which makes AS Studio useless.

ms...@gmail.com <ms...@gmail.com> #13Aug 10, 2017 03:48PM

Is there a work round? Any hints are really appreciated.

hu...@google.com <hu...@google.com> #14Aug 10, 2017 04:50PM

The workaround works for me now, thanks to #4 I made a detailed description to remove the keymap for "alt" + "L" on mac at https://stackoverflow.com/a/75127936/3569768

ms...@gmail.com <ms...@gmail.com> #15Aug 11, 2017 07:23AM

hu...@google.com <hu...@google.com> #16Aug 19, 2017 01:24AM

Can you reproduce this issue consistently? It would be great if you could reproduce it without changing branches (e.g., by looking at the diff between the two branches and figuring out the smallest change that would trigger the issue).

ms...@gmail.com <ms...@gmail.com> #17Sep 6, 2017 04:55PM

After more investigation using "gradle assemble --stacktrace" I found that the issue is with zip process:

Error:org.gradle.tooling.BuildException: Failed to generate v1 signature
Error:java.io.IOException: Failed to generate v1 signature
Error:com.android.apksig.apk.ApkFormatException: Unsupported character 0x0d in ZIP entry name "assets/.../Icon?"

There was a file named "Icon?" in my project which causes the crash.
I deleted the file and now everything is working fine.

This issue showed up in all versions after Android Studio Canary 4!
You can close this issue if there is nothing to do for fixing it!

hu...@google.com <hu...@google.com> #18Sep 8, 2017 11:33PM

Reassigned to kl...@google.com.

3.0 Canary 4 is about the time we added that "Unsupported character" check, so that's why it happens from that version forward.

@Alex, it looks like we should not fail on the "?" character right? (Or maybe it is some encoded character that we fail to convert to a char type.) Could you look at the "CR, LF, and NUL are not permitted in ZIP entry names" change in V1SchemeSigner and confirm whether there is a bug in that code?

kl...@google.com <kl...@google.com> #19Sep 11, 2017 04:35PM

Reassigned to hu...@google.com.

I'm confused. Why do you think that it is the '?' character which is to blame? The error message in

comment #17

explicitly calls out the 0x0d character, not the '?' character.

hu...@google.com <hu...@google.com> #20Sep 11, 2017 05:04PM

From

comment #17

, it's true that the exception is thrown for the 0x0d character; but also from the same comment, if the reporter removes the file named "Icon?" then there is no exception. Therefore, I was wondering if if there could be anything problematic with the V1SchemeSigner.checkEntryNameValid method (I know it's unlikely, but it's worth checking).

@Mohsen Mirhoseini: Could you show us the full path of that "Icon?" file? Is there any irregular character in that file? And where do you think the '?' character come from? My best guess is that the '?' character is actually the '\0' character but the system has to show it in the form of a '?' character.

ms...@gmail.com <ms...@gmail.com> #21Sep 11, 2017 05:30PM

It is not `?` character, I think it is `Icon` end with two \r (according to my .gitignore_global -> Icon<CR><CR>), which is a mac file system icon you or other applications can assign to folders and according to this link, it is very easy to make one!

http://www.hongkiat.com/blog/customize-mac-folder-icon/

It is hidden and you should press command + shift + . to make it visible.

Screen Shot 2017-09-11 at 13.27.20.png

127 KB

View

Download

hu...@google.com <hu...@google.com> #22Sep 11, 2017 05:55PM

Status: Won't Fix (Infeasible)

I see, in that case I'm afraid you will have to remove the file because we currently don't support file names with these characters during signing. (@Alex, please correct me if I'm wrong.)

I'm not sure how we can work around this issue, looks like I will have to close this as impossible to fix.

Thanks for your report and the prompt response!

ey...@gmail.com <ey...@gmail.com> #23Sep 11, 2017 05:59PM

I got this again when I disconnected the device I was deploying to while the app was building. Subsequent builds failed with the same error until I did a clean build.

kl...@google.com <kl...@google.com> #24Sep 11, 2017 06:08PM

Correct. JAR signatures (aka v1 APK signatures) do not support file names containing CR characters. The reason is that file names are listed in META/MANIFEST.MF and META-INF/*.SF files without any escaping, yet CR character is treated as a line delimiter in these files.

hu...@google.com <hu...@google.com> #25Sep 11, 2017 06:15PM

@Eliezer Graber: Are you also on a Mac and your assets contain "Icon\r" files? (If not, please consider filing another bug with us for better tracking.) Can you reproduce the issue consistently?

ms...@gmail.com <ms...@gmail.com> #26Sep 11, 2017 06:16PM

Good to know, as I mentioned I have solved my project issue by removing that file, but it could be a warning or an error with more details during build time from Android Studio in later versions.

Thanks

ja...@google.com <ja...@google.com> #27Sep 13, 2017 05:20PM