IssueTracker

The issue is that Jetifier modifies jars and does not remove signatures. Below is the original class:

Classfile /tmp/non-jetified/org/bouncycastle/jce/provider/ExtCRLException.class
  Last modified Mar 1, 2015; size 362 bytes
  MD5 checksum 3968a716f9e60e1ad36c34157bd0239f
class org.bouncycastle.jce.provider.ExtCRLException extends java.security.cert.CRLException
  minor version: 0
  major version: 49
  flags: ACC_SUPER
Constant pool:
   #1 = Utf8               <init>
   #2 = Utf8               cause
   #3 = Utf8               getCause
   #4 = Utf8               java/security/cert/CRLException
   #5 = Utf8               org/bouncycastle/jce/provider/ExtCRLException
   #6 = Class              #4             // java/security/cert/CRLException
   #7 = Class              #5             // org/bouncycastle/jce/provider/ExtCRLException
   #8 = Utf8               Ljava/lang/Throwable;
   #9 = Utf8               (Ljava/lang/String;)V
  #10 = Utf8               ()Ljava/lang/Throwable;
  #11 = Utf8               (Ljava/lang/String;Ljava/lang/Throwable;)V
  #12 = NameAndType        #2:#8          // cause:Ljava/lang/Throwable;
  #13 = NameAndType        #1:#9          // "<init>":(Ljava/lang/String;)V
  #14 = Fieldref           #7.#12         // org/bouncycastle/jce/provider/ExtCRLException.cause:Ljava/lang/Throwable;
  #15 = Methodref          #6.#13         // java/security/cert/CRLException."<init>":(Ljava/lang/String;)V
  #16 = Utf8               Code
{
  java.lang.Throwable cause;
    descriptor: Ljava/lang/Throwable;
    flags:

  org.bouncycastle.jce.provider.ExtCRLException(java.lang.String, java.lang.Throwable);
    descriptor: (Ljava/lang/String;Ljava/lang/Throwable;)V
    flags:
    Code:
      stack=2, locals=3, args_size=3
         0: aload_0
         1: aload_1
         2: invokespecial #15                 // Method java/security/cert/CRLException."<init>":(Ljava/lang/String;)V
         5: aload_0
         6: aload_2
         7: putfield      #14                 // Field cause:Ljava/lang/Throwable;
        10: return

  public java.lang.Throwable getCause();
    descriptor: ()Ljava/lang/Throwable;
    flags: ACC_PUBLIC
    Code:
      stack=1, locals=1, args_size=1
         0: aload_0
         1: getfield      #14                 // Field cause:Ljava/lang/Throwable;
         4: areturn
}

One processed with Jetifier:

Classfile /tmp/jetified/org/bouncycastle/jce/provider/ExtCRLException.class
  Last modified Oct 14, 2019; size 362 bytes
  MD5 checksum 76bc557706ee3480e53d88b21316913f
class org.bouncycastle.jce.provider.ExtCRLException extends java.security.cert.CRLException
  minor version: 0
  major version: 49
  flags: ACC_SUPER
Constant pool:
   #1 = Utf8               org/bouncycastle/jce/provider/ExtCRLException
   #2 = Class              #1             // org/bouncycastle/jce/provider/ExtCRLException
   #3 = Utf8               java/security/cert/CRLException
   #4 = Class              #3             // java/security/cert/CRLException
   #5 = Utf8               cause
   #6 = Utf8               Ljava/lang/Throwable;
   #7 = Utf8               <init>
   #8 = Utf8               (Ljava/lang/String;Ljava/lang/Throwable;)V
   #9 = Utf8               (Ljava/lang/String;)V
  #10 = NameAndType        #7:#9          // "<init>":(Ljava/lang/String;)V
  #11 = Methodref          #4.#10         // java/security/cert/CRLException."<init>":(Ljava/lang/String;)V
  #12 = NameAndType        #5:#6          // cause:Ljava/lang/Throwable;
  #13 = Fieldref           #2.#12         // org/bouncycastle/jce/provider/ExtCRLException.cause:Ljava/lang/Throwable;
  #14 = Utf8               getCause
  #15 = Utf8               ()Ljava/lang/Throwable;
  #16 = Utf8               Code
{
  java.lang.Throwable cause;
    descriptor: Ljava/lang/Throwable;
    flags:

  org.bouncycastle.jce.provider.ExtCRLException(java.lang.String, java.lang.Throwable);
    descriptor: (Ljava/lang/String;Ljava/lang/Throwable;)V
    flags:
    Code:
      stack=2, locals=3, args_size=3
         0: aload_0
         1: aload_1
         2: invokespecial #11                 // Method java/security/cert/CRLException."<init>":(Ljava/lang/String;)V
         5: aload_0
         6: aload_2
         7: putfield      #13                 // Field cause:Ljava/lang/Throwable;
        10: return

  public java.lang.Throwable getCause();
    descriptor: ()Ljava/lang/Throwable;
    flags: ACC_PUBLIC
    Code:
      stack=1, locals=1, args_size=1
         0: aload_0
         1: getfield      #13                 // Field cause:Ljava/lang/Throwable;
         4: areturn
}


Changes in the constants pool cause changes in the code (indices change), which causes different MD5 checksums. This means that signatures will not match any more.

This started happening in 3.6.0-beta01 because we are using Jetifier with copyUnmodifiedLibsAlso=true flag (previously it was false).

@Chris You can work around this by updating gradle.properties with:

android.jetifier.blacklist=.*bcprov.*

This will avoid Jetifying the bouncycastle library.

Thanks Ivan!

Pending fix in: https://android-review.googlesource.com/c/platform/frameworks/support/+/1151460

did this fix make it in for 3.6?

Jetifier 1.0.0-beta08 was released and has a fix for this.

To avoid waiting for new Android Studio you can workaround this in the meantime by forcing usage of a new version of jetifier in gradle:
buildscript {
   dependencies {
       classpath 'com.android.tools.build:gradle:x.y.z'
       classpath 'com.android.tools.build.jetifier:jetifier-processor:1.0.0-beta08' // <- Add this
   }
}

Jetifier 1.0.0-beta08, which has the fix for this issue, will be integrated into AGP 3.6.0-rc01 and 4.0.0-alpha06: https://android.googlesource.com/platform/tools/base/+/ef5e56702b626b6be642ecce7d0078b7b1a81bcb

What's happening is that the signing step of the APK building pipeline is presented with a pre-existing META-INF/MANIFEST.MF which, for some reason, does not contain the Manifest-Version attribute in its main section, making it an illegal/malformed manifest. Please assign to an owner of the APK building pipeline to investigate further.

Hung, could you have a look. thx

@#5 (Eliezer Graber): Is it possible that you cook up a small project and share with us?

I'm sorry, but I haven't been able to repro it.

I am not sure if this error is related to previous one, but after updating to recent Android Studio 3.0 Beta 1, I get this new error message and I am still unable to update my Android Studio to any new builds after Canary 4:

--------------------------------------------------------------------------------

Error:Cause: java.lang.NullPointerException
        at sun.nio.fs.UnixPath.normalizeAndCheck(UnixPath.java:77)
        at sun.nio.fs.UnixPath.<init>(UnixPath.java:71)
        at sun.nio.fs.UnixFileSystem.getPath(UnixFileSystem.java:281)
        at java.nio.file.Paths.get(Paths.java:84)
        at com.android.build.gradle.internal.scope.BuildOutput.getOutputPath(BuildOutput.java:222)
        at com.android.build.gradle.internal.scope.BuildOutputs.lambda$load$2(BuildOutputs.java:243)
        at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
        at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1376)
        at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
        at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
        at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
        at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
        at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)
        at com.android.build.gradle.internal.scope.BuildOutputs.load(BuildOutputs.java:245)
        at com.android.build.gradle.internal.scope.BuildOutputs.load(BuildOutputs.java:184)
        at com.android.build.gradle.internal.scope.BuildOutputs.load(BuildOutputs.java:140)
        at com.android.build.gradle.internal.ide.BuildOutputsSupplier.lambda$get$1(BuildOutputsSupplier.java:55)
        at com.google.common.collect.ImmutableList.forEach(ImmutableList.java:397)
        at com.android.build.gradle.internal.ide.BuildOutputsSupplier.get(BuildOutputsSupplier.java:50)
        at com.android.build.gradle.internal.ide.BuildOutputsSupplier.get(BuildOutputsSupplier.java:35)
        at com.android.build.gradle.internal.ide.AndroidArtifactImpl.getOutputs(AndroidArtifactImpl.java:134)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.gradle.tooling.internal.adapter.ProtocolToModelAdapter$ReflectionMethodInvoker.invoke(ProtocolToModelAdapter.java:592)
        at org.gradle.tooling.internal.adapter.ProtocolToModelAdapter$AdaptingMethodInvoker.invoke(ProtocolToModelAdapter.java:397)
        at org.gradle.tooling.internal.adapter.ProtocolToModelAdapter$PropertyCachingMethodInvoker.invoke(ProtocolToModelAdapter.java:625)
        at org.gradle.tooling.internal.adapter.ProtocolToModelAdapter$SafeMethodInvoker.invoke(ProtocolToModelAdapter.java:647)
        at org.gradle.tooling.internal.adapter.ProtocolToModelAdapter$SupportedPropertyInvoker.invoke(ProtocolToModelAdapter.java:670)
        at org.gradle.tooling.internal.adapter.ProtocolToModelAdapter$InvocationHandlerImpl.invoke(ProtocolToModelAdapter.java:356)
        at com.sun.proxy.$Proxy216.getOutputs(Unknown Source)
        at com.android.tools.idea.gradle.project.model.ide.android.IdeAndroidArtifactImpl.<init>(IdeAndroidArtifactImpl.java:57)
        at com.android.tools.idea.gradle.project.model.ide.android.IdeVariantImpl.lambda$new$1(IdeVariantImpl.java:63)
        at com.android.tools.idea.gradle.project.model.ide.android.ModelCache.lambda$computeIfAbsent$0(ModelCache.java:31)
        at java.util.HashMap.computeIfAbsent(HashMap.java:1126)
        at com.android.tools.idea.gradle.project.model.ide.android.ModelCache.computeIfAbsent(ModelCache.java:31)
        at com.android.tools.idea.gradle.project.model.ide.android.IdeModel.copy(IdeModel.java:74)
        at com.android.tools.idea.gradle.project.model.ide.android.IdeVariantImpl.<init>(IdeVariantImpl.java:62)
        at com.android.tools.idea.gradle.project.model.ide.android.IdeAndroidProjectImpl.lambda$new$4(IdeAndroidProjectImpl.java:88)
        at com.android.tools.idea.gradle.project.model.ide.android.ModelCache.lambda$computeIfAbsent$0(ModelCache.java:31)
        at java.util.HashMap.computeIfAbsent(HashMap.java:1126)
        at com.android.tools.idea.gradle.project.model.ide.android.ModelCache.computeIfAbsent(ModelCache.java:31)
        at com.android.tools.idea.gradle.project.model.ide.android.IdeModel.copy(IdeModel.java:74)
        at com.android.tools.idea.gradle.project.model.ide.android.IdeAndroidProjectImpl.<init>(IdeAndroidProjectImpl.java:87)
        at com.android.tools.idea.gradle.project.model.ide.android.IdeAndroidProjectImpl.<init>(IdeAndroidProjectImpl.java:68)
        at com.android.tools.idea.gradle.project.model.AndroidModuleModel.<init>(AndroidModuleModel.java:131)
        at com.android.tools.idea.gradle.project.sync.idea.AndroidGradleProjectResolver.populateModuleContentRoots(AndroidGradleProjectResolver.java:214)
        at org.jetbrains.plugins.gradle.service.project.AbstractProjectResolverExtension.populateModuleContentRoots(AbstractProjectResolverExtension.java:103)
        at org.jetbrains.plugins.gradle.service.project.GradleProjectResolver.doResolveProjectInfo(GradleProjectResolver.java:366)
        at org.jetbrains.plugins.gradle.service.project.GradleProjectResolver.access$200(GradleProjectResolver.java:79)
        at org.jetbrains.plugins.gradle.service.project.GradleProjectResolver$ProjectConnectionDataNodeFunction.fun(GradleProjectResolver.java:902)
        at org.jetbrains.plugins.gradle.service.project.GradleProjectResolver$ProjectConnectionDataNodeFunction.fun(GradleProjectResolver.java:886)
        at org.jetbrains.plugins.gradle.service.execution.GradleExecutionHelper.execute(GradleExecutionHelper.java:218)
        at org.jetbrains.plugins.gradle.service.project.GradleProjectResolver.resolveProjectInfo(GradleProjectResolver.java:139)
        at org.jetbrains.plugins.gradle.service.project.GradleProjectResolver.resolveProjectInfo(GradleProjectResolver.java:79)
        at com.intellij.openapi.externalSystem.service.remote.RemoteExternalSystemProjectResolverImpl.lambda$resolveProjectInfo$0(RemoteExternalSystemProjectResolverImpl.java:37)
        at com.intellij.openapi.externalSystem.service.remote.AbstractRemoteExternalSystemService.execute(AbstractRemoteExternalSystemService.java:59)
        at com.intellij.openapi.externalSystem.service.remote.RemoteExternalSystemProjectResolverImpl.resolveProjectInfo(RemoteExternalSystemProjectResolverImpl.java:37)
        at com.intellij.openapi.externalSystem.service.remote.wrapper.ExternalSystemProjectResolverWrapper.resolveProjectInfo(ExternalSystemProjectResolverWrapper.java:45)
        at com.intellij.openapi.externalSystem.service.internal.ExternalSystemResolveProjectTask.doExecute(ExternalSystemResolveProjectTask.java:66)
        at com.intellij.openapi.externalSystem.service.internal.AbstractExternalSystemTask.execute(AbstractExternalSystemTask.java:139)
        at com.intellij.openapi.externalSystem.service.internal.AbstractExternalSystemTask.execute(AbstractExternalSystemTask.java:125)
        at com.intellij.openapi.externalSystem.util.ExternalSystemUtil$3.execute(ExternalSystemUtil.java:388)
        at com.intellij.openapi.externalSystem.util.ExternalSystemUtil$5.run(ExternalSystemUtil.java:445)
        at com.intellij.openapi.progress.impl.CoreProgressManager$TaskRunnable.run(CoreProgressManager.java:726)
        at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcess$1(CoreProgressManager.java:176)
        at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:556)
        at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:501)
        at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:66)
        at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:163)
        at com.intellij.openapi.progress.impl.ProgressManagerImpl$1.run(ProgressManagerImpl.java:137)
        at com.intellij.openapi.application.impl.ApplicationImpl$2.run(ApplicationImpl.java:334)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)


--------------------------------------------------------------------------------

Android Studio 3.0 Beta 1
Build #AI-171.4243858, built on August 4, 2017
JRE: 1.8.0_152-release-915-b01 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Mac OS X 10.12.6

@#13: It's a different error. Please see our known issues at the top of this page: https://developer.android.com/studio/build/gradle-plugin-3-0-0.html

Yes you where right, I fixed this issue by cleaning and adding new Android support libraries and also adding google as project repository. but after all previous issue (java.io.IOException: Failed to generate v1 signature) back again.

Can you reproduce this issue consistently? It would be great if you could reproduce it without changing branches (e.g., by looking at the diff between the two branches and figuring out the smallest change that would trigger the issue).

After more investigation using "gradle assemble --stacktrace" I found that the issue is with zip process:

    Error:org.gradle.tooling.BuildException: Failed to generate v1 signature
    Error:java.io.IOException: Failed to generate v1 signature
    Error:com.android.apksig.apk.ApkFormatException: Unsupported character 0x0d in ZIP entry name "assets/.../Icon?"

There was a file named "Icon?" in my project which causes the crash.
I deleted the file and now everything is working fine.

This issue showed up in all versions after Android Studio Canary 4!
You can close this issue if there is nothing to do for fixing it!

3.0 Canary 4 is about the time we added that "Unsupported character" check, so that's why it happens from that version forward.

@Alex, it looks like we should not fail on the "?" character right? (Or maybe it is some encoded character that we fail to convert to a char type.) Could you look at the "CR, LF, and NUL are not permitted in ZIP entry names" change in V1SchemeSigner and confirm whether there is a bug in that code?

I'm confused. Why do you think that it is the '?' character which is to blame? The error message in comment #17 explicitly calls out the 0x0d character, not the '?' character.

From comment #17, it's true that the exception is thrown for the 0x0d character; but also from the same comment, if the reporter removes the file named "Icon?" then there is no exception. Therefore, I was wondering if if there could be anything problematic with the V1SchemeSigner.checkEntryNameValid method (I know it's unlikely, but it's worth checking).

@Mohsen Mirhoseini: Could you show us the full path of that "Icon?" file? Is there any irregular character in that file? And where do you think the '?' character come from? My best guess is that the '?' character is actually the '\0' character but the system has to show it in the form of a '?' character.

It is not `?` character, I think it is `Icon` end with two \r (according to my .gitignore_global -> Icon<CR><CR>), which is a mac file system icon you or other applications can assign to folders and according to this link, it is very easy to make one!
http://www.hongkiat.com/blog/customize-mac-folder-icon/

It is hidden and you should press command + shift + . to make it visible.

I see, in that case I'm afraid you will have to remove the file because we currently don't support file names with these characters during signing. (@Alex, please correct me if I'm wrong.)

I'm not sure how we can work around this issue, looks like I will have to close this as impossible to fix.

Thanks for your report and the prompt response!

I got this again when I disconnected the device I was deploying to while the app was building. Subsequent builds failed with the same error until I did a clean build.

Correct. JAR signatures (aka v1 APK signatures) do not support file names containing CR characters. The reason is that file names are listed in META/MANIFEST.MF and META-INF/*.SF files without any escaping, yet CR character is treated as a line delimiter in these files.

@Eliezer Graber: Are you also on a Mac and your assets contain "Icon\r" files? (If not, please consider filing another bug with us for better tracking.) Can you reproduce the issue consistently?

Good to know, as I mentioned I have solved my project issue by removing that file, but it could be a warning or an error with more details during build time from Android Studio in later versions.

Thanks

Please add to the list of known issues for 3.0.

I have the same error, tried a few things including removing every instance of "\n" in the project, I'm on Windows so I don't have any "Icon\r" file. If anyone knows how to fix this please share! Going back to v2 on this project in the meanwhile.

@João Sardinha: For better tracking, please leave your comments at Issue 67394465 (which reports the same exception but is not related to the use of "Icon\r" files). Also attach a sample project if you can. Thanks!