Fixed
Status Update
No update yet.
Comments
[Deleted User] <[Deleted User]>
since these are in public API (:/) we need to do this in 1.2
se...@google.com
since it is already marked as deprecated, we can probably do it by now.
se...@google.com
Opening diff shortly
[Deleted User] <[Deleted User]>
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
se...@google.com
No, we weren't aware of that. But we added tests for underlying issue.
[Deleted User] <[Deleted User]>
Great. Super happy to help!
Description
Version used: 1.0.0-alpha7
Devices/Android versions reproduced on: Nexus 6 (7.0 NBD92D), Emulator Nexus 4 API 25, and possibly any device
- Situation / Use case
App is using LiveData for network calls.
Activity queries the network observing on a newly created LiveData for that call
There is a background data processing that uses `observeForever` and `removeObserver` to observe ALL network calls generated by any activity.
Once called `removeObserver` from this background data processing the activity currently in foreground (resumed) does not receive the callback.
- Attached is a minimum example of it.
In the example:
The Application instantiates a BackgroundDataProcessing (that calls observeForever/removeObserver) that creates a list of the data and a BackgroundDataObserver that observes to the list of data and logs it.
The MainActivity queries the network LiveData that returns a result 1.5 seconds later. As a piece of automation to demo the bug, the MainActivity will start a new MainActivity in 3 seconds.
The BackgroundDataObserver always receives the value updates and the MainActivity never receives it. If comment out the line `source.removeObserver(this);` on the `BackgroundDataProcessing`, the MainActivity starts receiving those events (but we'll also be leaking memory)
I hope it helps.