Order of member variables changes the database schema [64290754]

Fixed

Bug

Status Update

No update yet.

Description

de...@gmail.com

created issue #1

Aug 2, 2017 03:17PM

Component used: ROOM
Version used: 1.0.0-alpha8

If I change the order of the member variables within an @Entity Class, I am forced to provide a migration.

Before:

@Entity(tableName = "contacts")
public class ContactEntity {

@PrimaryKey(autoGenerate = true)
private Long id;

@ColumnInfo(name = "phone")
private String phone;

@ColumnInfo(name = "name")
private String name;

@ColumnInfo(name = "mail")
private String mail;
}

After:

@Entity(tableName = "contacts")
public class ContactEntity {

@PrimaryKey(autoGenerate = true)
private Long id;

@ColumnInfo(name = "name")
private String name;

@ColumnInfo(name = "phone")
private String phone;

@ColumnInfo(name = "mail")
private String mail;
}

Is this intended behaviour?

If yes, how would such a migration look like?

Comments

se...@google.com <se...@google.com> #2Aug 2, 2017 03:20PM

Assigned to ya...@google.com.

hmm it should not ask for a transaction. In fact, we don't want a transaction.
Can you show us that error?

yaraki@, i think we should check if we are already in a transaction before sending vacuum and if so, print a warning and skip vacuum.

mm...@commonsware.com <mm...@commonsware.com> #3Oct 21, 2017 07:19PM

Hello, when I call clearAllTables Room throws an error saying that I should start a Transaction. So I did that, and now the method throws that VACUUM cannot run inside a Transaction.

yb...@google.com <yb...@google.com> #4Oct 28, 2017 06:40PM

Reassigned to yb...@google.com.

Can you share the error message saying that a Transaction is needed?

yb...@google.com <yb...@google.com> #5Dec 19, 2017 06:06PM

I catch the exception again. As you can see below. but I have see that that error only happen when I run clearAllTables in Main Thread.

I know that we should not do that, and when I run clearAllTables in a background thread it runs without errors.

So I believe that the exception gives a wrong message.

04-02 07:04:06.133 4197-4197/br.com.mobilesales.influxlexical E/AndroidRuntime: FATAL EXCEPTION: main
Process: br.com.mobilesales.influxlexical, PID: 4197
java.lang.IllegalStateException: Cannot perform this operation because there is no current transaction.
at android.database.sqlite.SQLiteSession.throwIfNoTransaction(SQLiteSession.java:915)
at android.database.sqlite.SQLiteSession.endTransaction(SQLiteSession.java:398)
at android.database.sqlite.SQLiteDatabase.endTransaction(SQLiteDatabase.java:524)
at android.arch.persistence.db.framework.FrameworkSQLiteDatabase.endTransaction(FrameworkSQLiteDatabase.java:90)
at android.arch.persistence.room.RoomDatabase.endTransaction(RoomDatabase.java:261)
at br.com.mobilesales.influxlexical.data.source.local.AppDatabase_Impl.clearAllTables(AppDatabase_Impl.java:355)
at br.com.mobilesales.influxlexical.InfluxLexicalApplication$override.logoffUser(InfluxLexicalApplication.java:154)
at br.com.mobilesales.influxlexical.InfluxLexicalApplication$override.access$dispatch(InfluxLexicalApplication.java)
at br.com.mobilesales.influxlexical.InfluxLexicalApplication.logoffUser(InfluxLexicalApplication.java)
at br.com.mobilesales.influxlexical.MainActivity.onOptionsItemSelected(MainActivity.kt:247)
at android.app.Activity.onMenuItemSelected(Activity.java:3204)
at android.support.v4.app.FragmentActivity.onMenuItemSelected(FragmentActivity.java:380)
at android.support.v7.app.AppCompatActivity.onMenuItemSelected(AppCompatActivity.java:195)
at android.support.v7.view.WindowCallbackWrapper.onMenuItemSelected(WindowCallbackWrapper.java:108)
at android.support.v7.view.WindowCallbackWrapper.onMenuItemSelected(WindowCallbackWrapper.java:108)
at android.support.v7.app.ToolbarActionBar$2.onMenuItemClick(ToolbarActionBar.java:63)
at android.support.v7.widget.Toolbar$1.onMenuItemClick(Toolbar.java:203)
at android.support.v7.widget.ActionMenuView$MenuBuilderCallback.onMenuItemSelected(ActionMenuView.java:780)
at android.support.v7.view.menu.MenuBuilder.dispatchMenuItemSelected(MenuBuilder.java:822)
at android.support.v7.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:171)
at android.support.v7.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:973)
at android.support.v7.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:963)
at android.support.v7.widget.ActionMenuView.invokeItem(ActionMenuView.java:624)
at android.support.v7.view.menu.ActionMenuItemView.onClick(ActionMenuItemView.java:150)
at android.view.View.performClick(View.java:5637)
at android.view.View$PerformClick.run(View.java:22429)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6119)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

yb...@google.com <yb...@google.com> #6Jan 4, 2018 10:45PM

Marked as fixed.

clearAllTables is not supposed to be run in a main thread. It is annotated with @WorkerThread, and you should always run it in a background thread.

Issue 64290754