Order of member variables changes the database schema [64290754]

Fixed

Bug

Status Update

No update yet.

Description

de...@gmail.com

created issue #1

Aug 2, 2017 03:17PM

Component used: ROOM
Version used: 1.0.0-alpha8

If I change the order of the member variables within an @Entity Class, I am forced to provide a migration.

Before:

@Entity(tableName = "contacts")
public class ContactEntity {

@PrimaryKey(autoGenerate = true)
private Long id;

@ColumnInfo(name = "phone")
private String phone;

@ColumnInfo(name = "name")
private String name;

@ColumnInfo(name = "mail")
private String mail;
}

After:

@Entity(tableName = "contacts")
public class ContactEntity {

@PrimaryKey(autoGenerate = true)
private Long id;

@ColumnInfo(name = "name")
private String name;

@ColumnInfo(name = "phone")
private String phone;

@ColumnInfo(name = "mail")
private String mail;
}

Is this intended behaviour?

If yes, how would such a migration look like?

Comments

se...@google.com <se...@google.com> #2Aug 2, 2017 03:20PM

Assigned to ya...@google.com.

since these are in public API (:/) we need to do this in 1.2

mm...@commonsware.com <mm...@commonsware.com> #3Oct 21, 2017 07:19PM

since it is already marked as deprecated, we can probably do it by now.

yb...@google.com <yb...@google.com> #4Oct 28, 2017 06:40PM

Reassigned to yb...@google.com.

Opening diff shortly

yb...@google.com <yb...@google.com> #5Dec 19, 2017 06:06PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

yb...@google.com <yb...@google.com> #6Jan 4, 2018 10:45PM

Marked as fixed.

this is fixed for the next version.

note that, you still need a version upgrade to get the new behavior since we didn't want to change the existing schema files.

Issue 64290754