Fixed
Status Update
No update yet.
Comments
se...@google.com
since these are in public API (:/) we need to do this in 1.2
fl...@google.com
yb...@google.com
since it is already marked as deprecated, we can probably do it by now.
yb...@google.com
Opening diff shortly
yb...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
Description
Version used: 1.0.0-alpha8
Given the following entity:
@Entity(tableName = "foo")
public class FooEntity {
@PrimaryKey
@ColumnInfo(name = "bar")
private String bar;
@ColumnInfo(name = "baz")
private String baz;
public FooEntity(String bar, String baz) {
this.bar= bar;
this.baz= baz;
}
}
I'm able to insert the follwing entities into the database without errors:
new FooEntity(null, "one");
new FooEntity(null, "two");
new FooEntity(null, "three");
Is this behaviour intended? Should PrimaryKey columns be NonNull by default (not sure especially with multi column primary keys and auto increment columns)?
If null is a valid value for a primary key column, I believe there should by a primary key violation if I try to put the same key multiple times into the table.