GrantPermissionRule does not provide WRITE_EXTERNAL_STORAGE [64389280]

Bug

Status Update

No update yet.

Description

ze...@gmail.com

created issue #1

Aug 4, 2017 05:13PM

Library used (Espresso, Runner, Rules etc.):
Version used: Rules 1.0.0

What steps will reproduce the problem?
1. Use new GrantPermissionRule with WRITE_EXTERNAL_STORAGE in your test

@Rule
public GrantPermissionRule mRuntimePermissionRule =
GrantPermissionRule.grant(Manifest.permission.WRITE_EXTERNAL_STORAGE);

2. Use a method in app code which tries to write to internal sdcard (create a new folder on external sdcard)

In my Application.java:

public void createDir() throws IOException {
new File(Environment.getExternalStorageDirectory() + "/test").createNewFile();
}

How are you running your tests (via Android Studio, Gradle, adb, etc.)?
Android Studio

What is the expected output? What do you see instead?
In the app settings the permission is enabled and the call should work but it throws the following exception:

java.io.IOException: Permission denied
at java.io.UnixFileSystem.createFileExclusively0(Native Method)
at java.io.UnixFileSystem.createFileExclusively(UnixFileSystem.java:280)
at java.io.File.createNewFile(File.java:948)
at test.app.directory.Application.createDir(EarApplication.java:253)
at test.app.directory.ExternalDirTest.test(ExternalDirTest.java:24)
at java.lang.reflect.Method.invoke(Native Method)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at android.support.test.rule.GrantPermissionRule$RequestPermissionStatement.evaluate(GrantPermissionRule.java:109)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:58)
at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:369)
at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1932)

Comments

sl...@google.com <sl...@google.com> #2Aug 4, 2017 10:38PM

Thanks. We will take a look. Even though we need to figure out a way to reliably detect when a Service is actually shutdown. Thanks for the sample project makes it a lot easier to reproduce the issue.

ze...@gmail.com <ze...@gmail.com> #3Aug 7, 2017 10:42AM

Thanks for reporting this issue. I think we make use of IBinder.java#linkToDeath() to guarantee successful shutdown after each test.

http://developer.android.com/reference/android/os/IBinder.html#linkToDeath(android.os.IBinder.DeathRecipient, int)

logcat.txt

591 KB

View

Download

ze...@gmail.com <ze...@gmail.com> #4Aug 7, 2017 05:10PM

I don't know the inner workings of this, but there seems to be a connection to

Issue 36949180

: ServiceTestRule.bindService() returns null on 2nd invocation.

Issue 36949180

has a workaround where you repeat "serviceRule.bindService(intent)" until it no longer returns null. I tried the FooServiceTest in multiple-service-calls-test.tgz in my own project setting and test 2 to 5 failed. However, all tests succeeded after changing the bindService() method to repeatedly bind inside a while loop until the returned binder is not null.

sl...@google.com <sl...@google.com> #5Aug 25, 2017 12:41AM

Fixed in next Runner/Rules v1.0 release.

ze...@gmail.com <ze...@gmail.com> #6Sep 26, 2017 05:32PM

Hi sorry for the late response:

I get the following respone from the command:

requested permissions:
android.permission.INTERNET
android.permission.WRITE_EXTERNAL_STORAGE
android.permission.READ_EXTERNAL_STORAGE
android.permission.RECORD_AUDIO
android.permission.SET_ALARM
android.permission.RECEIVE_BOOT_COMPLETED
android.permission.WAKE_LOCK
android.permission.ACCESS_NETWORK_STATE
android.permission.ACCESS_FINE_LOCATION
install permissions:
android.permission.RECEIVE_BOOT_COMPLETED: granted=true
android.permission.INTERNET: granted=true
android.permission.ACCESS_NETWORK_STATE: granted=true
android.permission.WAKE_LOCK: granted=true
runtime permissions:
android.permission.WRITE_EXTERNAL_STORAGE: granted=true
android.permission.RECORD_AUDIO: granted=true
ACTIVITY MANAGER URI PERMISSIONS (dumpsys activity permissions)
time="26.9.2017, 18:55" type=MOVE_TO_FOREGROUND package=com.google.android.packageinstaller class=com.android.packageinstaller.permission.ui.ManagePermissionsActivity
time="26.9.2017, 18:56" type=MOVE_TO_BACKGROUND package=com.google.android.packageinstaller class=com.android.packageinstaller.permission.ui.ManagePermissionsActivity
time="26.9.2017, 19:14" type=MOVE_TO_FOREGROUND package=com.google.android.packageinstaller class=com.android.packageinstaller.permission.ui.GrantPermissionsActivity
time="26.9.2017, 19:14" type=MOVE_TO_BACKGROUND package=com.google.android.packageinstaller class=com.android.packageinstaller.permission.ui.GrantPermissionsActivity
time="26.9.2017, 19:20" type=MOVE_TO_FOREGROUND package=com.google.android.packageinstaller class=com.android.packageinstaller.permission.ui.GrantPermissionsActivity
time="26.9.2017, 19:20" type=MOVE_TO_BACKGROUND package=com.google.android.packageinstaller class=com.android.packageinstaller.permission.ui.GrantPermissionsActivity

So it seems that the permission is granted. But I get all the time the exception.

ta...@gmail.com <ta...@gmail.com> #7Oct 19, 2017 12:27PM

I experienced the same issue using Rules 1.0.1 on Nexus 5X running Android 8.0

I found a workaround for this issue where I also grant the 'Manifest.permission.READ_EXTERNAL_STORAGE' permission and then things work as expected.
So instead of:
GrantPermissionRule.grant(Manifest.permission.WRITE_EXTERNAL_STORAGE);
I use:
GrantPermissionRule.grant(Manifest.permission.WRITE_EXTERNAL_STORAGE, Manifest.permission.READ_EXTERNAL_STORAGE);

The issue could be (this is just my guess):
'GrantPermissionRule.grant(Manifest.permission.WRITE_EXTERNAL_STORAGE)' only grants write permission. However, when requesting the write permission using the Android system dialog both the write and read permissions are granted. This is also the expected behaviour as described in the Manifest.permission class:

https://developer.android.com/reference/android/Manifest.permission.html#READ_EXTERNAL_STORAGE

"Any app that declares the WRITE_EXTERNAL_STORAGE permission is implicitly granted this permission."

sl...@google.com <sl...@google.com> Nov 15, 2017 07:35PM

Assigned to sl...@google.com.

eg...@gmail.com <eg...@gmail.com> #8Nov 17, 2017 02:18PM

Experienced same problem after updating hockey sdk to version 5.0.3.

After investigating I found that hockey sdk declares following in AndroidManifest.xml:
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" android:maxSdkVersion="18" />

While my app main library just defines following in AndroidManifest.xml:
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>

Fixed by changing main library manifest to following:
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"
tools:node="replace" />

be...@gmail.com <be...@gmail.com> #9Nov 24, 2017 03:48PM

Experience same problem with Manifest.permission.READ_CONTACTS and android.Manifest.permission.WRITE_CONTACTS permission

sl...@google.com <sl...@google.com> #10Dec 11, 2017 11:21PM

Marked as fixed.

Fix will be available in 1.0.2-alpha2

ri...@gmail.com <ri...@gmail.com> #11Dec 18, 2017 04:24PM

I am also experiencing the same issue with Manifest.permission.ACCESS_FINE_LOCATION

fr...@gmail.com <fr...@gmail.com> #12Jan 25, 2018 07:30PM

How do I import 1.0.2-alpha2 into my project?

[Deleted User] <[Deleted User]> #13Mar 13, 2018 02:21PM

When should we expect a build of 1.0.2-alpha2 with this fix?

nk...@google.com <nk...@google.com> #14Mar 13, 2018 04:15PM

alpha2 is not released just yet

dr...@gmail.com <dr...@gmail.com> #15Apr 19, 2018 02:22PM

I tested on beta1 for ACCESS_FINE_LOCATION and it still does not work.

nk...@google.com <nk...@google.com> Apr 19, 2018 05:26PM

Status: Assigned (reopened)

vb...@gmail.com <vb...@gmail.com> #16Jul 2, 2018 08:49AM

Any progress on this issue?

lu...@gmail.com <lu...@gmail.com> #17Jul 2, 2018 11:37AM

Same problem here trying to grant access WRITE_EXTERNAL_STORAGE with latest 1.0.2

mu...@gmail.com <mu...@gmail.com> #18Sep 12, 2018 10:16AM

The API isn't working for me too.

I get this in the logcat everytime I try to run my test: "junit.framework.AssertionFailedError: Failed to grant permissions, see logcat for details"
And I have done things very simple and straigt forward

@RunWith(AndroidJUnit4.class)
public class MainTest {

@Rule
public GrantPermissionRule grantPermissionRule = GrantPermissionRule.grant(Manifest.permission.WRITE_EXTERNAL_STORAGE);

private Context context;

@Before
public void setup() {
context = InstrumentationRegistry.getTargetContext();
}
}

pa...@finanzen.net <pa...@finanzen.net> #19Nov 29, 2018 02:03PM

This one fixed it for me. It works only with replace node for me:

<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" tools:node="replace"/>
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" tools:node="replace" />

al...@gmail.com <al...@gmail.com> #20May 8, 2019 12:30PM

I am also experiencing the same issue with rules:1.0.2 while testing a custom view on an emulated Nexus 5 API 27.

Build: 3.4, AI-183.5429.30.34.5452501, 201904100040,

AI-183.5429.30.34.5452501, JRE 1.8.0_152-release-1343-b01x64 JetBrains s.r.o, OS Mac OS X(x86_64) v10.14.4, screens 1680x1050

Android Gradle Plugin: 3.4.0
Gradle: 5.2

sl...@google.com <sl...@google.com> Mar 23, 2020 07:08PM

Status: New

gu...@gmail.com <gu...@gmail.com> #21Jan 16, 2021 02:42PM

i am still experience same issue.

here's my config

"androidx.test:core:1.3.0",
"androidx.test:rules:1.3.0",

su...@gmail.com <su...@gmail.com> #22Jul 14, 2021 09:36AM

Any update on this issue?
I was facing the same issue, the following code won't work on Android R physical device:

    @Rule
    public GrantPermissionRule rule = GrantPermissionRule.grant(
            Manifest.permission.ACCESS_FINE_LOCATION,
            Manifest.permission.WRITE_EXTERNAL_STORAGE
    );

av...@gmail.com <av...@gmail.com> #23Mar 15, 2022 07:39PM

tools:node="replace" adding this to permission on manifest worked for me.

ae...@google.com <ae...@google.com> #24Sep 14, 2023 06:30PM

This bug has not been updated in over a year. Please reopen if this is still an issue or requires addition inspection.