GrantPermissionRule does not provide WRITE_EXTERNAL_STORAGE [64389280]

Bug

Status Update

No update yet.

Description

ze...@gmail.com

created issue #1

Aug 4, 2017 05:13PM

Library used (Espresso, Runner, Rules etc.):
Version used: Rules 1.0.0

What steps will reproduce the problem?
1. Use new GrantPermissionRule with WRITE_EXTERNAL_STORAGE in your test

@Rule
public GrantPermissionRule mRuntimePermissionRule =
GrantPermissionRule.grant(Manifest.permission.WRITE_EXTERNAL_STORAGE);

2. Use a method in app code which tries to write to internal sdcard (create a new folder on external sdcard)

In my Application.java:

public void createDir() throws IOException {
new File(Environment.getExternalStorageDirectory() + "/test").createNewFile();
}

How are you running your tests (via Android Studio, Gradle, adb, etc.)?
Android Studio

What is the expected output? What do you see instead?
In the app settings the permission is enabled and the call should work but it throws the following exception:

java.io.IOException: Permission denied
at java.io.UnixFileSystem.createFileExclusively0(Native Method)
at java.io.UnixFileSystem.createFileExclusively(UnixFileSystem.java:280)
at java.io.File.createNewFile(File.java:948)
at test.app.directory.Application.createDir(EarApplication.java:253)
at test.app.directory.ExternalDirTest.test(ExternalDirTest.java:24)
at java.lang.reflect.Method.invoke(Native Method)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at android.support.test.rule.GrantPermissionRule$RequestPermissionStatement.evaluate(GrantPermissionRule.java:109)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:58)
at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:369)
at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1932)

Comments

sl...@google.com <sl...@google.com> #2Aug 4, 2017 10:38PM

+1, but Deferred does not solve the Observer problem that Rx and LiveData do, so I guess Google should implement Channels instead of LiveData which is actually a Kotlin Coroutine counterpart. Looking forward to this as I've decided not to use RxJava in most of future projects due to Kotlin Coroutines..

ze...@gmail.com <ze...@gmail.com> #3Aug 7, 2017 10:42AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e78cceffeac28f0028342990c1391c640edf453c
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed Nov 28 12:40:24 2018

Room Support for Coroutines

This change allows users to define suspend functions in DAOs with
@Query, @Insert, @Update and @Delete. The new artifact room-coroutine
defines a helper classes for supporting the feature.

Bug: 69474692
Test: ./gradlew room:integration-tests:kotlintestapp:cC
Change-Id: Id73a6b845df3f21f99d14cb6980130dcf3885c81

M buildSrc/src/main/kotlin/androidx/build/PublishDocsRules.kt
A room/compiler/src/main/kotlin/androidx/room/ext/KotlinMetadataElement.kt
D room/compiler/src/main/kotlin/androidx/room/ext/KotlinMetadataProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/ext/element_ext.kt
M room/compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
M room/compiler/src/main/kotlin/androidx/room/processor/DeletionMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/InsertionMethodProcessor.kt
A room/compiler/src/main/kotlin/androidx/room/processor/MethodProcessorDelegate.kt
M room/compiler/src/main/kotlin/androidx/room/processor/PojoProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/RawQueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/ShortcutMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/UpdateMethodProcessor.kt
A room/compiler/src/main/kotlin/androidx/room/solver/query/result/CoroutineResultBinder.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
A room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/CoroutineDeleteOrUpdateMethodBinder.kt
A room/compiler/src/main/kotlin/androidx/room/solver/shortcut/binder/CoroutineInsertMethodBinder.kt
M room/compiler/src/main/kotlin/androidx/room/solver/shortcut/result/DeleteOrUpdateMethodAdapter.kt
M room/compiler/src/main/kotlin/androidx/room/solver/shortcut/result/InsertMethodAdapter.kt
M room/compiler/src/main/kotlin/androidx/room/vo/RelationCollector.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
A room/coroutines/build.gradle
A room/coroutines/src/main/AndroidManifest.xml
A room/coroutines/src/main/java/androidx/room/CoroutinesRoom.kt
M room/integration-tests/kotlintestapp/build.gradle
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/dao/BooksDao.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/BooksDaoTest.kt
A room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/SuspendRoomDispatcherTest.kt
M settings.gradle

https://android-review.googlesource.com/833705

https://goto.google.com/android-sha1/e78cceffeac28f0028342990c1391c640edf453c

logcat.txt

591 KB

View

Download

ze...@gmail.com <ze...@gmail.com> #4Aug 7, 2017 05:10PM

So do you support any Coroutine "observables" like channels? Or these are just one-off suspending calls?

sl...@google.com <sl...@google.com> #5Aug 25, 2017 12:41AM

For now we'll be just supporting one-off suspend functions in Room 2.1.0-alpha03. Coroutines stream functionality with channels is still a work in progress.

ze...@gmail.com <ze...@gmail.com> #6Sep 26, 2017 05:32PM

Relating to the original request, how about allowing a return type of Deferred<LiveData<T>> which suspends until LiveData<T>'s value has been set the first time?

ta...@gmail.com <ta...@gmail.com> #7Oct 19, 2017 12:27PM

I just tested out Room 2.1.0-alpha03 and added suspend to all of my functions.... there appears to be an issue with functions that use @Query() and UPDATE and DELETE queries. Examples:

Code Example 1:
@Query("DELETE FROM individual")
suspend fun deleteAll()
Error:
Deletion methods must either return void or return int (the number of deleted rows).

Code Example 2:
@Query("UPDATE individual SET firstName = :firstName WHERE id = :id")
suspend fun updateFirstName(id: Long, firstName: String)
Error:
Not sure how to convert a Cursor to this method's return type (kotlin.Unit).

sl...@google.com <sl...@google.com> Nov 15, 2017 07:35PM

Assigned to sl...@google.com.

eg...@gmail.com <eg...@gmail.com> #8Nov 17, 2017 02:18PM

Async return types with @Query that perform UPDATE, DELETE or INSERT are not yet supported. This also applies to coroutines. We are actively working on adding this for the next alpha of 2.1.0. Subscribe to the bug for updates:

https://issuetracker.google.com/issues/120227284

be...@gmail.com <be...@gmail.com> #9Nov 24, 2017 03:48PM

Hello.
Any updates on returning Channel<T> from DAO?
Will contributions be accepted for that feature?

sl...@google.com <sl...@google.com> #10Dec 11, 2017 11:21PM

Marked as fixed.

Channels are experimental right now so we probably want to wait until it is stable.

ri...@gmail.com <ri...@gmail.com> #11Dec 18, 2017 04:24PM

Channels +1

fr...@gmail.com <fr...@gmail.com> #12Jan 25, 2018 07:30PM

Marking as fix since core coroutines are supported in 2.1, in the mean time we'll keep an eye on the Channels API to potentially support it once its upgraded out of experimental.

https://issuetracker.google.com/issues/127328278

[Deleted User] <[Deleted User]> #13Mar 13, 2018 02:21PM

Is it expected that we still have to ensure that suspended functions aren't dispatched from the main thread?
The first call (eg `final SupportSQLiteStatement _stmt = __preparedStmtOfDeleteAll.acquire();`) is not wrapped in a callable and can't be done on the ui thread, so we still have to wrap suspensions with our own context.

nk...@google.com <nk...@google.com> #14Mar 13, 2018 04:15PM

Kotlinx.coroutines 1.2 released with cold stream abstraction Flow:

https://kotlin.github.io/kotlinx.coroutines/kotlinx-coroutines-core/kotlinx.coroutines.flow/-flow/index.html

It's in "preview" status, but maybe we also could expect some experimental version of Room with Flow support for observable requests

dr...@gmail.com <dr...@gmail.com> #15Apr 19, 2018 02:22PM

I tested on beta1 for ACCESS_FINE_LOCATION and it still does not work.

nk...@google.com <nk...@google.com> Apr 19, 2018 05:26PM

Status: Assigned (reopened)

vb...@gmail.com <vb...@gmail.com> #16Jul 2, 2018 08:49AM

Any progress on this issue?

lu...@gmail.com <lu...@gmail.com> #17Jul 2, 2018 11:37AM

Same problem here trying to grant access WRITE_EXTERNAL_STORAGE with latest 1.0.2

mu...@gmail.com <mu...@gmail.com> #18Sep 12, 2018 10:16AM

The API isn't working for me too.

I get this in the logcat everytime I try to run my test: "junit.framework.AssertionFailedError: Failed to grant permissions, see logcat for details"
And I have done things very simple and straigt forward

@RunWith(AndroidJUnit4.class)
public class MainTest {

@Rule
public GrantPermissionRule grantPermissionRule = GrantPermissionRule.grant(Manifest.permission.WRITE_EXTERNAL_STORAGE);

private Context context;

@Before
public void setup() {
context = InstrumentationRegistry.getTargetContext();
}
}

pa...@finanzen.net <pa...@finanzen.net> #19Nov 29, 2018 02:03PM

This one fixed it for me. It works only with replace node for me:

<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" tools:node="replace"/>
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" tools:node="replace" />

al...@gmail.com <al...@gmail.com> #20May 8, 2019 12:30PM

I am also experiencing the same issue with rules:1.0.2 while testing a custom view on an emulated Nexus 5 API 27.

Build: 3.4, AI-183.5429.30.34.5452501, 201904100040,

AI-183.5429.30.34.5452501, JRE 1.8.0_152-release-1343-b01x64 JetBrains s.r.o, OS Mac OS X(x86_64) v10.14.4, screens 1680x1050

Android Gradle Plugin: 3.4.0
Gradle: 5.2

sl...@google.com <sl...@google.com> Mar 23, 2020 07:08PM

Status: New

gu...@gmail.com <gu...@gmail.com> #21Jan 16, 2021 02:42PM

i am still experience same issue.

here's my config

"androidx.test:core:1.3.0",
"androidx.test:rules:1.3.0",

su...@gmail.com <su...@gmail.com> #22Jul 14, 2021 09:36AM

Any update on this issue?
I was facing the same issue, the following code won't work on Android R physical device:

    @Rule
    public GrantPermissionRule rule = GrantPermissionRule.grant(
            Manifest.permission.ACCESS_FINE_LOCATION,
            Manifest.permission.WRITE_EXTERNAL_STORAGE
    );

av...@gmail.com <av...@gmail.com> #23Mar 15, 2022 07:39PM

tools:node="replace" adding this to permission on manifest worked for me.

ae...@google.com <ae...@google.com> #24Sep 14, 2023 06:30PM

This bug has not been updated in over a year. Please reopen if this is still an issue or requires addition inspection.