Fixed
Status Update
No update yet.
Comments
yb...@google.com
sh...@google.com
sh...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: George Mount <
Link:
Fix focus move within child AndroidViews
Expand for full commit details
Fix focus move within child AndroidViews
Fixes: 389994198
Fixes: 391378895
Relnote: "Fixes focus travel within child AndroidViews where it
can sometimes jump out of the child to the ComposeView"
Sometimes the native FocusFinder doesn't act properly and finds
the wrong View when searching. This CL changes the FocusFinder to
use a newer copy of FocusFinder for all focus search operations
in AndroidComposeView.
Test: new test, manual testing
Change-Id: I678c864afe086879c5c45b018dd82da4f23be440
Files:
- M
compose/ui/ui/src/androidInstrumentedTest/AndroidManifest.xml - M
compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/FocusListenerTest.kt - A
compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/TestActivity2.kt - A
compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/viewinterop/MixedFocusChangeTest.kt - M
compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt - M
compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/FocusFinderCompat.android.kt
Hash: b028bcc322095634123da91c7146bac9e23c13c7
Date: Tue Jan 14 13:48:11 2025
Description
Version used: 1.0.0-alpha9
Devices/Android versions reproduced on: all
When converting a legacy app over to Room, there exists cases where we really need to do destructive migrations. However, I don't want to use fallbackToDestructiveMigration() as I really don't want to default to destructive migrations for future revisions.
It would be nice if I could do something like
addMigration(
new DestructiveMigration(1),
new DestructiveMigration(2),
MIGRATION_3_4);
Where new DestructiveMigration would migrate from 1 to the current database version, destroying and recreating everything. This would allow us to upgrade those users as if they were just using our app from the start.
Note that we can't have endVersion other than the current version as we don't know what the database looked like for any other endVersion to know what tables we need to create.