Fixed
Status Update
Comments
sl...@google.com <sl...@google.com>
nk...@google.com <nk...@google.com> #2
Duplicate of internal issue
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 45a1bc4a15b5b10d0635d79fb55df2aced5a2a4a
Author: Alan Viverette <alanv@google.com>
Date: Thu May 14 18:06:25 2020
Only apply DayNight changes to Activity-hosted delegates
Dialogs can't receive configuration change callbacks, so there's no point
in updating their configurations. They'll have to be destroyed and re-
created by their host activities. Also, dialogs were eating the changes.
Fixes: 155379937
Test: NightModeForegroundDialogTestCase and appcompat test suite
Change-Id: Ifa18d9d42268ec8821223942dc6c817ecabbed7f
A appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/NightModeDialogFragment.java
A appcompat/appcompat/src/androidTest/java/androidx/appcompat/app/NightModeForegroundDialogTestCase.kt
M appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDelegate.java
M appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDelegateImpl.java
Description
Version used: 3.0.1
What steps will reproduce the problem?
1. Declare 2 identical tests
2. register CountingIdlingResource in junit Before and unregister it in junit After
3. perform some async operation and manage idling resource before and after it
4. second test most of the time fails but only if first is run before it.
How are you running your tests (via Android Studio, Gradle, adb, etc.)?
Android Studio, Device: Nexus 5x Os ver. 7.1.2, all animations settings set to 0.5x
What is the expected output? What do you see instead?
Expected: all tests pass
Actual: Second test fails very often
Sample project attached.
Reason:
Espresso is static and keeps outdated idling resources in IdlingResourceRegistry.
It sync its state with IdlingRegistry on first onView() operation in second test which for unknown reason (probably) unregister correct idling resource.