Wrong state after invoking startActivityForResult [65665621]

Fixed

Bug

Status Update

No update yet.

Description

fa...@gmail.com

created issue #1

Sep 14, 2017 01:18PM

Component used: LifecycleRegistry
Version used: 1.0.0-alpha9
Devices/Android versions reproduced on: Android 5 (it works on Android 8)

I have a strange problem connected to a MutableLiveData that doesn't trigger the observer when updated in onActivityResult. The cause seems to be a wrong state in LifecycleRegistry, in the following example the println in onResume prints "resume CREATED". Between startActivityForResult and onResume the state is set to CREATED even if the Activity remains always started (because the other activity is not full screen).

You can reproduce this issue using this Activity:

class LiveDataTestActivity : AppCompatActivity(), LifecycleRegistryOwner {

private val lifecycle = LifecycleRegistry(this)

override fun getLifecycle() = lifecycle

private val myLiveData = MutableLiveData<Int>().apply { value = 0 }

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
val textView = TextView(this).apply {
text = "AAAA"
setOnClickListener {
val sendIntent = Intent().apply {
action = Intent.ACTION_SEND
putExtra(Intent.EXTRA_TEXT, "This is my text to send.")
type = "text/plain"
}
startActivityForResult(sendIntent, 123)
}
}
setContentView(textView)

myLiveData.observe(this, Observer<Int> {
textView.text = it.toString()
})
}

override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) {
super.onActivityResult(requestCode, resultCode, data)
myLiveData.value = (myLiveData.value ?: 0) + 1
println("Value ${myLiveData.value}")
}

override fun onResume() {
super.onResume()
println("resume ${lifecycle.currentState}")
}
}

Comments

yb...@google.com <yb...@google.com> Sep 15, 2017 12:07AM

Assigned to se...@google.com.

fa...@gmail.com <fa...@gmail.com> #2Sep 15, 2017 08:55AM

since these are in public API (:/) we need to do this in 1.2

yb...@google.com <yb...@google.com> Sep 28, 2017 10:07PM

Reassigned to sh...@google.com.

yb...@google.com <yb...@google.com> Sep 29, 2017 07:47PM

Reassigned to yb...@google.com.

yb...@google.com <yb...@google.com> #3Sep 30, 2017 12:48AM

since it is already marked as deprecated, we can probably do it by now.

yb...@google.com <yb...@google.com> Oct 3, 2017 09:13PM

Reassigned to sh...@google.com.

sh...@google.com <sh...@google.com> Oct 4, 2017 09:33PM

Accepted by sh...@google.com.

sh...@google.com <sh...@google.com> #4Oct 12, 2017 12:45AM

Opening diff shortly

sh...@google.com <sh...@google.com> Oct 16, 2017 10:41PM

Marked as fixed.

yb...@google.com <yb...@google.com> #5Oct 16, 2017 11:24PM

Status: Assigned (reopened)

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

yb...@google.com <yb...@google.com> Oct 18, 2017 02:06AM

Marked as fixed.

va...@gmail.com <va...@gmail.com> #6Jan 24, 2018 08:58AM

Norm

ms...@gmail.com <ms...@gmail.com> #7Feb 27, 2018 04:25AM

Fragment ransaction bug:

UncaughtException
java.lang.IllegalStateException: The specified child already has a parent. You must call removeView() on the child's parent first.
at android.view.ViewGroup.addViewInner(ViewGroup.java:4937)
at android.view.ViewGroup.addView(ViewGroup.java:4768)
at android.view.ViewGroup.addView(ViewGroup.java:4708)
at android.view.ViewGroup.addView(ViewGroup.java:4681)
at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1425)
at android.support.v4.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManager.java:1750)
at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1819)
at android.support.v4.app.BackStackRecord.executePopOps(BackStackRecord.java:855)
at android.support.v4.app.FragmentManagerImpl.executeOps(FragmentManager.java:2587)
at android.support.v4.app.FragmentManagerImpl.executeOpsTogether(FragmentManager.java:2377)
at android.support.v4.app.FragmentManagerImpl.removeRedundantOperationsAndExecute(FragmentManager.java:2332)
at android.support.v4.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:2239)
at android.support.v4.app.FragmentManagerImpl$1.run(FragmentManager.java:700)
at android.os.Handler.handleCallback(Handler.java:790)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6494)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

Issue 65665621

Description

Issue summary

Comments

yb...@google.com <yb...@google.com> Sep 15, 2017 12:07AM

fa...@gmail.com <fa...@gmail.com> #2Sep 15, 2017 08:55AM

yb...@google.com <yb...@google.com> Sep 28, 2017 10:07PM

yb...@google.com <yb...@google.com> Sep 29, 2017 07:47PM

yb...@google.com <yb...@google.com> #3Sep 30, 2017 12:48AM

yb...@google.com <yb...@google.com> Oct 3, 2017 09:13PM

sh...@google.com <sh...@google.com> Oct 4, 2017 09:33PM

sh...@google.com <sh...@google.com> #4Oct 12, 2017 12:45AM

sh...@google.com <sh...@google.com> Oct 16, 2017 10:41PM

yb...@google.com <yb...@google.com> #5Oct 16, 2017 11:24PM

yb...@google.com <yb...@google.com> Oct 18, 2017 02:06AM

va...@gmail.com <va...@gmail.com> #6Jan 24, 2018 08:58AM

ms...@gmail.com <ms...@gmail.com> #7Feb 27, 2018 04:25AM

Add comment

Issue metadata