TestRequestBuilder crash when running test in class with @Ignore [65828576]

Fixed

Bug

Status Update

No update yet.

Description

dr...@gmail.com

created issue #1

Sep 18, 2017 03:50PM

If I add the JUnit @Ignore annotation to my test class at the class level (rather than at the method level) and then try to run an individual test method from that class using "adb shell am instrument" and the "-e class com.example.MyTestClass#myTest" argument, I see ATSL crashing with the following stack trace.

This is using version 0.5 of the runner artifact.

E/TestExecutor( 5297): Fatal exception when running tests
E/TestExecutor( 5297): java.lang.NullPointerException: Attempt to invoke interface method 'int java.lang.CharSequence.length()' on a null object reference
E/TestExecutor( 5297): at java.util.regex.Matcher.reset(Matcher.java:177)
E/TestExecutor( 5297): at java.util.regex.Matcher.<init>(Matcher.java:90)
E/TestExecutor( 5297): at java.util.regex.Pattern.matcher(Pattern.java:297)
E/TestExecutor( 5297): at android.support.test.internal.runner.TestRequestBuilder$MethodFilter.stripParameterizedSuffix(TestRequestBuilder.java:503)
E/TestExecutor( 5297): at android.support.test.internal.runner.TestRequestBuilder$MethodFilter.shouldRun(TestRequestBuilder.java:486)
E/TestExecutor( 5297): at android.support.test.internal.runner.TestRequestBuilder$ClassAndMethodFilter.shouldRun(TestRequestBuilder.java:421)
E/TestExecutor( 5297): at org.junit.runner.manipulation.Filter$3.shouldRun(Filter.java:112)
E/TestExecutor( 5297): at org.junit.runners.ParentRunner.shouldRun(ParentRunner.java:434)
E/TestExecutor( 5297): at org.junit.runners.ParentRunner.filter(ParentRunner.java:382)
E/TestExecutor( 5297): at org.junit.runner.manipulation.Filter.apply(Filter.java:97)
E/TestExecutor( 5297): at android.support.test.internal.runner.TestRequestBuilder$LenientFilterRequest.getRunner(TestRequestBuilder.java:381)
E/TestExecutor( 5297): at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
E/TestExecutor( 5297): at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
E/TestExecutor( 5297): at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
E/TestExecutor( 5297): at com.example.MyTestRunner.onStart(MyTestRunner.java:89)
E/TestExecutor( 5297): at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)

Comments

uc...@google.com <uc...@google.com> Sep 18, 2017 09:04PM

Assigned to ja...@google.com.

ja...@google.com <ja...@google.com> #2Sep 21, 2017 12:53AM

Reassigned to sl...@google.com.

I've found this code fragment in the newest API 23 SDK's source code

WifiServiceImpl.java Line964

if (!canReadPeerMacAddresses && !isActiveNetworkScorer && !isLocationEnabled()) {
return new ArrayList<ScanResult>();
}

It could explain this issue.The method "isLocationEnabled" read Location settings then returns false at this condition, and getScanResults returns null.

sl...@google.com <sl...@google.com> #3Sep 21, 2017 05:30PM

Accepted by sl...@google.com.

Thank you for your comment.

getScanResults() returns current results on Lollipop and older even if GPS is disabled.
Scan results should have no relation to GPS.

sl...@google.com <sl...@google.com> Nov 15, 2017 08:04PM

Marked as fixed.

st...@gmail.com <st...@gmail.com> #4Nov 8, 2024 03:03AM

I had confirmed the same with Nexus 5 Preview 3 (build num.: MPA44G).

Issue 65828576